[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Alan Conway  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |EOL
Last Closed||2016-04-07 11:33:46



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Vít Ondruch  changed:

   What|Removed |Added

 Comment #21 is|1   |0
private||
 Comment #31 is|1   |0
private||
 Comment #17 is|1   |0
private||
 Comment #35 is|1   |0
private||
 Comment #30 is|1   |0
private||
  Comment #5 is|1   |0
private||
 Comment #24 is|1   |0
private||
 Comment #27 is|1   |0
private||
  Comment #8 is|1   |0
private||
 Comment #34 is|1   |0
private||
 Comment #29 is|1   |0
private||
 CC||vondr...@redhat.com



--- Comment #36 from Vít Ondruch  ---
@Irina

Please don't make the comments private. There is nothing secrete in them and
somebody could be prevented from seeing them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Till Maas  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman  changed:

   What|Removed |Added

  Flags|needinfo?(iboverma@redhat.c |
   |om) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman  changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Alan Pevec  changed:

   What|Removed |Added

 CC||ape...@gmail.com,
   ||ibove...@redhat.com
  Flags||needinfo?(iboverma@redhat.c
   ||om)



--- Comment #33 from Alan Pevec  ---
python-qpid is still not available in Fedora Rawhide repo, please rebuild it in
fc24 target

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman  changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #32 from Jon Ciesla  ---
This is unretired.  You should be able to commit changes to the git repo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

  Flags|needinfo?(limburgher@gmail. |
   |com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #28 from Jon Ciesla limburg...@gmail.com ---
Looks unretired now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 CC||limburg...@gmail.com
  Flags||needinfo?(limburgher@gmail.
   ||com)



--- Comment #26 from Irina Boverman ibove...@redhat.com ---
I am not sure if this package has been unretired or not, the master still has
this, but the flag (fedora-cvs) has been removed...

$ ls
dead.package

$ git status
# On branch master

What is suppose to happen next?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #25 from Jon Ciesla limburg...@gmail.com ---
Now SCM request present.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #22 from Alan Conway acon...@redhat.com ---
PASS

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /home/aconway/tmp/review
  /review-python-qpid/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/acls/name/python-qpid
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: *No copyright* Apache (v2.0). Detailed output of licensecheck
 in /home/aconway/tmp/review/review-python-qpid/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm  4.4
 Note: %defattr present but not needed
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
 qpid-common
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file 

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Alan Conway acon...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1061750 is||
   obsolete||



--- Comment #23 from Alan Conway acon...@redhat.com ---
Created attachment 1066400
  -- https://bugzilla.redhat.com/attachment.cgi?id=1066400action=edit
fedora-review files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Alan Conway acon...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1062162 is||
   obsolete||



--- Comment #18 from Irina Boverman ibove...@redhat.com ---
Created attachment 1062220
  -- https://bugzilla.redhat.com/attachment.cgi?id=1062220action=edit
Package spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1062163 is||
   obsolete||



--- Comment #19 from Irina Boverman ibove...@redhat.com ---
Created attachment 1062221
  -- https://bugzilla.redhat.com/attachment.cgi?id=1062221action=edit
source rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1062166 is||
   obsolete||



--- Comment #20 from Irina Boverman ibove...@redhat.com ---
Created attachment 106
  -- https://bugzilla.redhat.com/attachment.cgi?id=106action=edit
Results of the fedora-review tool

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1061654 is||
   obsolete||



--- Comment #15 from Irina Boverman ibove...@redhat.com ---
Created attachment 1062163
  -- https://bugzilla.redhat.com/attachment.cgi?id=1062163action=edit
source rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1061657 is||
   obsolete||



--- Comment #16 from Irina Boverman ibove...@redhat.com ---
Created attachment 1062166
  -- https://bugzilla.redhat.com/attachment.cgi?id=1062166action=edit
Results of the fedora-review tool

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1061651 is||
   obsolete||



--- Comment #14 from Irina Boverman ibove...@redhat.com ---
Created attachment 1062162
  -- https://bugzilla.redhat.com/attachment.cgi?id=1062162action=edit
Package spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|acon...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #7 from Irina Boverman ibove...@redhat.com ---
Testing using python-qpid-messaging installed bits:

$ rpm -ql python-qpid-messaging
/usr/lib64/python2.7/site-packages/_qpid_messaging.so
/usr/lib64/python2.7/site-packages/qpid_messaging.py
/usr/lib64/python2.7/site-packages/qpid_messaging.pyc
/usr/lib64/python2.7/site-packages/qpid_messaging.pyo
/usr/share/doc/python-qpid-messaging
/usr/share/doc/python-qpid-messaging-0.34/examples
/usr/share/doc/python-qpid-messaging-0.34/examples/console
/usr/share/doc/python-qpid-messaging-0.34/examples/drain
/usr/share/doc/python-qpid-messaging-0.34/examples/hello
/usr/share/doc/python-qpid-messaging-0.34/examples/hello_xml
/usr/share/doc/python-qpid-messaging-0.34/examples/server
/usr/share/doc/python-qpid-messaging-0.34/examples/spout
/usr/share/doc/python-qpid-messaging-0.34/examples/statistics.py
/usr/share/doc/python-qpid-messaging-0.34/examples/statistics.pyc
/usr/share/doc/python-qpid-messaging-0.34/examples/statistics.pyo
/usr/share/doc/python-qpid-messaging/LICENSE

$ cd /usr/share/doc/python-qpid-messaging-0.34/examples

$ python hello
Hello world!

$ python spout -c 5 'my-queue;{create:always}'

Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:0'},
content_type='text/plain', content='')
Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:1'},
content_type='text/plain', content='')
Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:2'},
content_type='text/plain', content='')
Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:3'},
content_type='text/plain', content='')
Message(properties={'spout-id': '8d29304a-ead5-4482-b0cf-c764fab4f00f:4'},
content_type='text/plain', content='')

$ python drain 'my-queue'

Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id':
'8d29304a-ead5-4482-b0cf-c764fab4f00f:0'}, content_type='text/plain',
content='')
Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id':
'8d29304a-ead5-4482-b0cf-c764fab4f00f:1'}, content_type='text/plain',
content='')
Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id':
'8d29304a-ead5-4482-b0cf-c764fab4f00f:2'}, content_type='text/plain',
content='')
Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id':
'8d29304a-ead5-4482-b0cf-c764fab4f00f:3'}, content_type='text/plain',
content='')
Message(properties={'x-amqp-0-10.routing-key': 'my-queue', 'spout-id':
'8d29304a-ead5-4482-b0cf-c764fab4f00f:4'}, content_type='text/plain',
content='')

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1059990 is||
   obsolete||
 Attachment|review? |
 #1059990 Flags||



--- Comment #9 from Irina Boverman ibove...@redhat.com ---
Created attachment 1061649
  -- https://bugzilla.redhat.com/attachment.cgi?id=1061649action=edit
Package spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1059992 is||
   obsolete||



--- Comment #11 from Irina Boverman ibove...@redhat.com ---
Created attachment 1061654
  -- https://bugzilla.redhat.com/attachment.cgi?id=1061654action=edit
source rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment|0   |1
#1061649 is||
   obsolete||



--- Comment #10 from Irina Boverman ibove...@redhat.com ---
Created attachment 1061651
  -- https://bugzilla.redhat.com/attachment.cgi?id=1061651action=edit
Package spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #12 from Irina Boverman ibove...@redhat.com ---
Created attachment 1061657
  -- https://bugzilla.redhat.com/attachment.cgi?id=1061657action=edit
Results of the fedora-review tool

$ fedora-review -n python-qpid
INFO: Processing local files: python-qpid
INFO: Getting .spec and .srpm Urls from : Local files in
/home/iboverma/python-qpid
INFO:   -- SRPM url:
file:///home/iboverma/python-qpid/python-qpid-0.32-9.fc24.src.rpm
INFO:   -- Spec url: file:///home/iboverma/python-qpid/python-qpid.spec
INFO: Using review directory: /home/iboverma/python-qpid/review-python-qpid
INFO: Downloading (Source0):
http://www.apache.org/dyn/closer.cgi/qpid/0.32/qpid-python-0.32.tar.gz
INFO: Running checks and generating report
INFO: Results and/or logs in:
/home/iboverma/python-qpid/review-python-qpid/results
INFO: Build completed
INFO: Installing built package(s)
INFO: Active plugins: Python, Generic, Shell-api
INFO: Starting new HTTPS connection (1): admin.fedoraproject.org
INFO:  ExclusiveArch dependency checking disabled, enable with EXARCH flag

Review template in: /home/iboverma/python-qpid/review-python-qpid/review.txt
fedora-review is automated tool, but *YOU* are responsible for manually
reviewing the results and finishing the review. Do not just copy-paste
the results without understanding them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #13 from Alan Conway acon...@redhat.com ---
Created attachment 1061750
  -- https://bugzilla.redhat.com/attachment.cgi?id=1061750action=edit
fedora-review files

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===

Noted by aconway


- /usr/bin/qpid-python-test is not a user executable, don't package or package
under libexec.

Summary of fedora-review failed manual checks
-

MUST
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
 Note: %clean present but not required
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
/usr/lib/python2.7/site-packages/qpid
 aconway: I think this directory should be owned by the python-qpid
package?

SHOULD
[!]: Package does not include license text files separate from upstream.
 aconway: LICENSE.txt is not from upstream, but I don't see why this is an
issue.
[!]: %check is present and all tests pass.
 aconway: there's no %check. Manual tests look OK.

fedora-review automatic issues
--

- Package contains BR: python2-devel or python3-devel
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in
/home/aconway/tmp/review/review-python-qpid/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/acls/name/python-qpid
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


= MUST items =

Generic:
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
 Note: %clean present but not required
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: *No copyright* Apache (v2.0). Detailed output of licensecheck
 in /home/aconway/tmp/review/review-python-qpid/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
/usr/lib/python2.7/site-packages/qpid
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Each %files section contains %defattr if rpm  4.4
 Note: %defattr present but not needed
[X]: Package contains desktop file if it is a GUI application.
[X]: Development files must be in a -devel package
 (aconway: does not apply to python libraries)
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[X]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or 

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #6 from Irina Boverman ibove...@redhat.com ---
Testing mock build:

$ rpm -q -a | grep qpid
qpid-proton-c-0.9-5.fc23.x86_64
rubygem-qpid_messaging-0.32.0-3.fc23.x86_64
perl-qpid-proton-0.9-5.fc23.x86_64
qpid-proton-java-javadoc-0.9-2.fc23.noarch
qpid-cpp-client-devel-0.34-1.fc24.x86_64
python-qpid-qmf-0.32-1.fc24.x86_64
qpid-cpp-server-ha-0.34-1.fc24.x86_64
qpid-cpp-server-devel-0.34-1.fc24.x86_64
qpid-qmf-debuginfo-0.32-1.fc24.x86_64
libqpid-dispatch-0.4-3.fc23.x86_64
python-qpid-proton-0.9-5.fc23.x86_64
qpid-proton-c-devel-0.9-5.fc23.x86_64
rubygem-qpid_messaging-doc-0.32.0-3.fc23.noarch
qpid-dispatch-tools-0.4-3.fc23.x86_64
qpid-dispatch-router-0.4-3.fc23.x86_64
rubygem-qpid_proton-0.9.0-2.fc23.x86_64
qpid-proton-java-0.9-2.fc23.noarch
qpid-proton-c-devel-doc-0.9-5.fc23.noarch
python-qpid-proton-doc-0.9-5.fc23.noarch
qpid-cpp-server-0.34-1.fc24.x86_64
python-qpid-common-0.32-9.fc24.noarch
qpid-qmf-0.32-1.fc24.x86_64
qpid-tools-0.32-9.fc24.noarch
qpid-cpp-server-rdma-0.34-1.fc24.x86_64
qpid-qmf-devel-0.32-1.fc24.x86_64
python-qpid-messaging-0.34-1.fc24.x86_64
qpid-cpp-server-linearstore-0.34-1.fc24.x86_64
perl-qpid-messaging-0.34-1.fc24.x86_64
qpid-cpp-debuginfo-0.34-1.fc24.x86_64
libqpid-dispatch-devel-0.4-3.fc23.x86_64
rubygem-qpid_proton-doc-0.9.0-2.fc23.noarch
qpid-dispatch-router-docs-0.4-3.fc23.noarch
qpid-cpp-client-0.34-1.fc24.x86_64
python-qpid-0.32-9.fc24.noarch
qpid-cpp-client-rdma-0.34-1.fc24.x86_64
ruby-qpid-qmf-0.32-1.fc24.x86_64
qpid-cpp-server-xml-0.34-1.fc24.x86_64
qpid-cpp-client-devel-docs-0.34-1.fc24.noarch

$ git clone git://git.apache.org/qpid.git qpid-0.32

$ git checkout -t remotes/origin/0.32
Branch 0.32 set up to track remote branch 0.32 from origin.
Switched to a new branch '0.32'

$ cd qpid

[root@mrg19 qpid]# ./python/qpid-python-test
qpid.tests.codec.BitTestCase.test_bit1
. pass
qpid.tests.codec.BitTestCase.test_bit2
. pass
qpid.tests.codec.BitTestCase.test_bit3
. pass
qpid.tests.codec.BitTestCase.test_bit_decode_0
. pass
qpid.tests.codec.BitTestCase.test_bit_decode_1
. pass
qpid.tests.codec.BooleanTestCase.test_false_decode
. pass
qpid.tests.codec.BooleanTestCase.test_false_encode
. pass
qpid.tests.codec.BooleanTestCase.test_true_decode
.. pass
qpid.tests.codec.BooleanTestCase.test_true_encode
.. pass
qpid.tests.codec.ContentTestCase.test_content_inline
... pass
qpid.tests.codec.ContentTestCase.test_content_inline_decode
 pass
qpid.tests.codec.ContentTestCase.test_content_reference
 pass
qpid.tests.codec.ContentTestCase.test_content_reference_decode
. pass
qpid.tests.codec.FieldTableTestCase.test_field_table_decode
 pass
qpid.tests.codec.FieldTableTestCase.test_field_table_multiple_name_value_pair
.. pass
qpid.tests.codec.FieldTableTestCase.test_field_table_name_value_pair
... pass
qpid.tests.codec.IntegerTestCase.test_octet_out_of_upper_range
. pass
qpid.tests.codec.IntegerTestCase.test_ulong_int
 pass
qpid.tests.codec.IntegerTestCase.test_ulong_int_decode
. pass
qpid.tests.codec.IntegerTestCase.test_ulong_int_out_of_lower_range
. pass
qpid.tests.codec.IntegerTestCase.test_ulong_int_out_of_upper_range
. pass
qpid.tests.codec.IntegerTestCase.test_ulong_int_with_fraction
.. pass
qpid.tests.codec.IntegerTestCase.test_ulong_long_int
... pass
qpid.tests.codec.IntegerTestCase.test_ulong_long_int_decode
 pass
qpid.tests.codec.IntegerTestCase.test_ulong_long_int_out_of_lower_range
 pass
qpid.tests.codec.IntegerTestCase.test_ulong_long_int_out_of_upper_range
 pass
qpid.tests.codec.IntegerTestCase.test_ulong_long_int_with_fraction
. pass
qpid.tests.codec.IntegerTestCase.test_unsigned_octet

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Attachment||review?
 #1059990 Flags||



--- Comment #2 from Irina Boverman ibove...@redhat.com ---
Created attachment 1059990
  -- https://bugzilla.redhat.com/attachment.cgi?id=1059990action=edit
Package spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #3 from Irina Boverman ibove...@redhat.com ---
Created attachment 1059992
  -- https://bugzilla.redhat.com/attachment.cgi?id=1059992action=edit
source rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #4 from Irina Boverman ibove...@redhat.com ---
Attached revised spec file and source RPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100

Irina Boverman ibove...@redhat.com changed:

   What|Removed |Added

 Blocks||1251146




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1251146
[Bug 1251146] Re-organise qpid-cpp package, un-retire python-qpid package,
add qpid-tools and qpid-tests packages.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1248100



--- Comment #1 from Irina Boverman ibove...@redhat.com ---
I am removing python bits from qpid-cpp and rebasing both packages to 0.34
upstream. These changes will be made in rawhide and F23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review