[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328

Ilya Gradina  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
  Flags|needinfo?(ilya.gradina@gmai |
   |l.com)  |
Last Closed||2016-03-14 04:52:56



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rubygem-connection-pool

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328

Mamoru TASAKA  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Mamoru TASAKA  ---
Okay, now

* spec file clean
* source matches upstream
* license ok
* builds clean
* installation clean
* at least the following works

$ ruby -e "require 'connection_pool'; puts ConnectionPool::VERSION"
2.2.0

-
   This package (rubygem-connection_pool) is
   APPROVED by mtasaka
-

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328



--- Comment #4 from Ilya Gradina  ---
Hi Mamoru,

thx), I fixed all yours notes:

New Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-connection_pool.spec
New SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-connection_pool-2.2.0-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328



--- Comment #3 from Mamoru TASAKA  ---
Basically okay. Some requests and recommendations:

* Unneeded document files
  - %{gem_instdir}/test
As written on "Do not ship tests" in 
   
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
 
, we request test/ directory *not* shipped in the rebuilt
binary rpm.

  - Gemfile
This is needed only for test suite and not needed
on runtime.

  - Rakefile
This is alike "Makefile" on autotools system and 
not needed on runtime.

  - %{gem_instdir}/connection_pool.gemspec
This is usually needed only when creating gem itself
and not needed on runtime
(Note: %{gem_spec} is needed)

* Other documentation recommendations
   * Mark %doc
  - Mark Changes.md as %doc

   * README.md
  - I would recommend that this file should be
moved to main package because this says "README".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328

Mamoru TASAKA  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org
  Flags||fedora-review?



--- Comment #2 from Mamoru TASAKA  ---
Taking.

I would appreciate if you would review my review request (bug 1289850).

Note:
It seems that you have already submitted many rubygem related
package reviews which are not taken by any reviewers yet.
I would suggest you offer review swaps as written on:
https://fedoraproject.org/wiki/Package_Review_Process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267328] Review Request: rubygem-connection_pool - Generic connection pool for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267328



--- Comment #1 from Ilya Gradina  ---
(In reply to Ilya Gradina from comment #0)
> Spec URL:
> https://github.com/ilgrad/fedora-packages/blob/master/rubygems/rubygem-
> connection_pool.spec
> SRPM URL:
> https://github.com/ilgrad/fedora-packages/blob/master/rubygems/rubygem-
> connection_pool-2.2.0-1.fc24.src.rpm
> Description: Generic connection pool for Ruby.
> Fedora Account System Username: ilgrad

Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-connection_pool.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review