[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #24 from Fedora Update System --- python-mne-0.10-5.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-12-28 17:58:24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #23 from Fedora Update System --- python-mne-0.10-5.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-mne' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-5c687cbb72 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #22 from Fedora Update System --- python-mne-0.10-5.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-5c687cbb72 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Bug 1276880 depends on bug 1279223, which changed state. Bug 1279223 Summary: Review Request: python-h5io - Read and write simple Python objects using HDF5 https://bugzilla.redhat.com/show_bug.cgi?id=1279223 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Bug 1276880 depends on bug 1279225, which changed state. Bug 1279225 Summary: Review Request: python-jdcal - Julian dates from proleptic Gregorian and Julian calendars https://bugzilla.redhat.com/show_bug.cgi?id=1279225 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #21 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-mne -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Julien Enselme changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #20 from Julien Enselme --- > Can you approve package if this is last issue. I will apply ur patch when > will import package. Good for me. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #19 from Igor Gnatenko --- (In reply to Julien Enselme from comment #18) > Created attachment 1093436 [details] > Correct the non-executable-scripts Thanks. Can you approve package if this is last issue. I will apply ur patch when will import package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #18 from Julien Enselme --- Created attachment 1093436 --> https://bugzilla.redhat.com/attachment.cgi?id=1093436&action=edit Correct the non-executable-scripts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880
--- Comment #17 from Julien Enselme ---
I found what the problem is: in the code you use to remove the shebang, you use
two times %{modname} instead of one (see the attach patch).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #16 from Julien Enselme --- All of them: Rpmlint (from fedora review) --- Checking: python2-mne-0.10-4.fc24.noarch.rpm python3-mne-0.10-4.fc24.noarch.rpm python-mne-0.10-4.fc24.src.rpm python2-mne.noarch: E: explicit-lib-dependency python-matplotlib python2-mne.noarch: W: spelling-error Summary(en_US) Magnetoencephalography -> Electroencephalography, Electroencephalograph, Electroencephalogram python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_freeview_bem_surfaces.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_compare_fiff.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_watershed_bem.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_make_scalp_surfaces.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_maxfilter.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_bti2fiff.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_compute_proj_eog.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_coreg.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_flash_bem.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_report.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_browse_raw.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_flash_bem_model.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/stats/cluster_level.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_clean_eog_ecg.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_compute_proj_ecg.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_kit2fiff.py 644 /usr/bin/env python2-mne.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mne/commands/mne_surf2bem.py 644 /usr/bin/env python2-mne.noarch: W: no-manual-page-for-binary mne-2.7 python2-mne.noarch: W: no-manual-page-for-binary mne-2 python2-mne.noarch: W: no-manual-page-for-binary python2-mne python3-mne.noarch: E: explicit-lib-dependency python3-matplotlib python3-mne.noarch: W: spelling-error Summary(en_US) Magnetoencephalography -> Electroencephalography, Electroencephalograph, Electroencephalogram python3-mne.noarch: W: invalid-url URL: http://martinos.org/mne/ timed out python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_make_scalp_surfaces.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_flash_bem.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_kit2fiff.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_bti2fiff.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_report.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_clean_eog_ecg.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_compare_fiff.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_watershed_bem.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_maxfilter.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_browse_raw.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/stats/cluster_level.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_compute_proj_ecg.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_flash_bem_model.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_surf2bem.py 644 /usr/bin/env python3-mne.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/mne/commands/mne_freeview_be
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #15 from Igor Gnatenko --- For which scripts? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #14 from Julien Enselme --- I still get the non-executable errors. It is strange since I think your code to correct it is correct. Sadly, I don't have much time to dig into it today. Maybe tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #13 from Igor Gnatenko --- New SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/python-mne-0.10-4.fc24.src.rpm New SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/python-mne.spec Fixed non-executable. Docs I will think after pushing to repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #12 from Igor Gnatenko --- Those are used by bindir/mne in: cmd_path = op.join(mne_bin_dir, 'commands', 'mne_%s.py' % cmd) sys.exit(subprocess.call([sys.executable, cmd_path] + sys.argv[2:])) so I can just remove shebangs and it will be ok. will do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880
--- Comment #11 from Julien Enselme ---
Almost good:
- Please fix the non-executable-script issues before I approve the package.
- The documentation is quite huge because of the examples. I suggest that you
create a doc package anyway. Furthermore if a user install both the python2 and
python3 version, he/she won't have the examples twice. Not blocking.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 1562 files have
unknown license. Detailed output of licensecheck in /tmp/1276880
-python-mne/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 819200 bytes in 260 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-mne , python3-mne
[?]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all sup
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #10 from Igor Gnatenko --- Julien, sorry for typo =) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #9 from Igor Gnatenko --- New SRPM: https://ignatenkobrain.fedorapeople.org/neurofedora/python-mne-0.10-3.fc24.src.rpm New SPEC: https://ignatenkobrain.fedorapeople.org/neurofedora/python-mne.spec - Fix unbundling jdcal now I have the same results as before unbundling. Julian, please review =) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 --- Comment #8 from Igor Gnatenko --- sorry, sources haven't been uploaded correctly (src.rpm). scp: /home/fedora/ignatenkobrain/public_html/neurofedora//python-mne-0.10-2.fc24.src.rpm: Disk quota exceeded I fixed storage size and restarted it and it will upload sources correctly in 15-20 mins. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1276880] Review Request: python-mne - Magnetoencephalography (MEG) and Electroencephalography (EEG) data analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1276880 Julien Enselme changed: What|Removed |Added Summary|Review Request: python-mne |Review Request: python-mne |- Magnetoencephalography|- Magnetoencephalography |(MEG) and |(MEG) and |Electroencephalography |Electroencephalography |(EEG) |(EEG) data analysis -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
