[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #19 from Fedora Update System  ---
jssc-2.8.0-3.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #18 from Fedora Update System  ---
jssc-2.8.0-3.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-12 23:23:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #17 from gil cattaneo  ---
Hi,
sorry for the noise.

This is not necessary:
Please, remove 
%doc %{_javadocdir}/%{name}
Please, use: %files javadoc -f .mfiles-javadoc
Please, remove
Requires:java-headless
Requires:jpackage-utils

The requirements list is generated with Fedora java tools 
(javapackages-tools >> javapackages-local)

and install license file also in this sub package
e.g.

%files javadoc -f .mfiles-javadoc
%license COPYING

%package javadoc
Summary:Javadoc for %{name} package
BuildArch:  noarch
Please, remove >> Requires:   %{name} = %{version}
This is "contrary" to the guidelines of Fedora
is usually applied in this way. but in this case is not necessary/ useless
Requires:   %{name} = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #14 from gil cattaneo  ---
(In reply to Damian Wrobel from comment #13)
> (In reply to gil cattaneo from comment #10)
> > instead of maven-local you should use javapackages-local
> > 
> Gil, thanks for your hints, I started to look at them and compare with
> packaging guidelines [1] and I found that e.g. [1] clearly states the
> following:
> 
> "Java packages MUST BuildRequire their respective build system:
> 
> BuildRequires: maven-local for packages built with Maven"
> 
> and there is no single reference that javapackages-local can be used as a
> substitute for maven-local in this case.

Only if the package provide a pom.xml file and use that for build the package
in this case you use only java-devel. javapackages-local is enough

> So is there any specification on top of it which overwrites this or I
> misunderstood or missed something?
> 
> [1]. https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires
see also
https://fedorahosted.org/released/javapackages/doc/#_generic_java_builds
regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #15 from gil cattaneo  ---
Other trick
Remove
BuildRequires:jpackage-utils
BuildRequires:maven-local

Requires:java-headless
Requires:jpackage-utils

and add 
BuildRequires:javapackages-local

because jpackage-utils is an alias of javapackages-tools

.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #13 from Damian Wrobel  ---
(In reply to gil cattaneo from comment #10)
> instead of maven-local you should use javapackages-local
> 
Gil, thanks for your hints, I started to look at them and compare with
packaging guidelines [1] and I found that e.g. [1] clearly states the
following:

"Java packages MUST BuildRequire their respective build system:

BuildRequires: maven-local for packages built with Maven"

and there is no single reference that javapackages-local can be used as a
substitute for maven-local in this case.

So is there any specification on top of it which overwrites this or I
misunderstood or missed something?

[1]. https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #16 from gil cattaneo  ---
Damian javapackages-tools-doc package provides
https://fedorahosted.org/released/javapackages/doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
jssc-2.8.0-3.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update jssc'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7e3ce91e3d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #12 from Fedora Update System  ---
jssc-2.8.0-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update jssc'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1ed622527

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #10 from gil cattaneo  ---
hi
in 
install -d %{buildroot}%{jni} \
   %{buildroot}%{_jnidir} \


%{buildroot}%{_jnidir} is not necessary
maven-local or javapackages-local handle the jar file in "automatic"

%{_jnidir}/%{name}.jar

is also not usefull
%attr(644, root, root) %{_datadir}/maven-metadata/%{name}.xml
you should changes as

%files -f .mfiles
%license COPYING
%doc README.txt
%{jni}/


javadoc should be installed by

%mvn_install -J javadoc

and install -d %{buildroot}%{_javadocdir}/%{name} is no more necessary

instead of maven-local you should use javapackages-local

Regards, and sorry for the noise

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #7 from Fedora Update System  ---
jssc-2.8.0-3.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7e3ce91e3d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #9 from Damian Wrobel  ---
(In reply to Dennis Chen from comment #5)
> Approved.

Dennis,

Thank you for reviewing this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #8 from Fedora Update System  ---
jssc-2.8.0-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-b1ed622527

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/jssc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #3 from Damian Wrobel  ---
Please find updated both spec & srpm with fixes for all aforementioned issues.

Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/jssc.spec
SRPM URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/jssc-2.8.0-3.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #4 from Upstream Release Monitoring 
 ---
dwrobel's scratch build of jssc-2.8.0-3.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11980040

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Dennis Chen  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Dennis Chen  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Dennis Chen  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #2 from Dennis Chen  ---
Hi, I'd be happy to review this formally.

MUST FIX:
 - The SPEC File does not match the source RPM.
 - JSSC seems to be have some code licensed GPLv3+ and others LGPLv3+. Using
the FSF compatibility matrix, the combination must be distributed GPLv3+.

Everything else seems fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Dennis Chen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||barracks...@gmail.com
   Assignee|nob...@fedoraproject.org|barracks...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505

Damian Wrobel  changed:

   What|Removed |Added

 Blocks||1194551




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1194551
[Bug 1194551] Arduino 1.6.5 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #1 from Upstream Release Monitoring 
 ---
dwrobel's scratch build of jssc-2.8.0-1.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11686916

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review