[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685



--- Comment #6 from Fedora Update System  ---
python-pywt-0.3.0-2.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-12 23:23:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-pywt-0.3.0-2.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pywt'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-d61d5c30f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685



--- Comment #4 from Fedora Update System  ---
python-pywt-0.3.0-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-d61d5c30f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
- latest version is packaged
- license is OK
- license file is present, %license is used
- latest python packaging template is used
- provides/requires are sane
- package builds and installs

All looks good. Package is APPROVED.




(BTW.: I don't think that the rule of preserving timestamps on files applies if
you *modify* them. So I'd use plain 'sed -i' instead of the thing with .new and
renaming, but of course doing it in the complicated way is also OK ;))

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685



--- Comment #2 from Igor Gnatenko  ---
Spec URL: https://ignatenkobrain.fedorapeople.org/neurofedora/python-pywt.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/neurofedora/python-pywt-0.3.0-2.fc24.src.rpm

Fixed all issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=644899



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Original review is 644899.

Development has obviously been picked up again, so the reasons for retirement
are voided.

Why do you need separate documentation for python2 and python3? Even if there
are some small difference, I don't think they are important enough to pay for
the overhead of packagers and build time and disk usage and potential user
confusion.

Also, the docs are >1MB, so it might be nice to split them out into a separate
-doc package.

Tests in /usr/lib/python3.5/site-packages/pywt/tests/ have
#!/usr/bin/env python
Should be changed to #!/usr/bin/python3.5.

Looks good otherwise. Rpmlint complains about /usr/bin/env, but has only false
positives apart from that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1280485 (python-PyMVPA)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1280485
[Bug 1280485] Review Request: python-PyMVPA - Multivariate pattern analysis
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-pywt



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review