[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-12 23:23:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056



--- Comment #9 from Fedora Update System  ---
libminc-2.3.00-2.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
libminc-2.3.00-2.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libminc'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056



--- Comment #7 from Fedora Update System  ---
libminc-2.3.00-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
libminc-2.3.00-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libminc'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056



--- Comment #5 from Fedora Update System  ---
libminc-2.3.00-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-a6ab47275f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056



--- Comment #2 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> %{_libdir}/cmake/LIBMINC/ → this looks suspicious. Cmake puts everything in
> /usr/share/cmake asaic, nothing provides /usr/lib/cmake in Fedora.
arch-dependent packages should go to libdir/cmake/*
> 
> I don't think libminc-devel should require cmake. It should be possible to
> link to the library using other build systems, and cmake is a fairly large
> dep.
will remore
> 
> Rpmlint
> ---
> Checking: libminc-2.3.00-1.fc24.i686.rpm
>   libminc-devel-2.3.00-1.fc24.i686.rpm
>   libminc-debuginfo-2.3.00-1.fc24.i686.rpm
>   libminc-2.3.00-1.fc24.src.rpm
> libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0
> exit@GLIBC_2.0
looks like you got it 2 times, probably bug in rpmlint? What does it mean?
> libminc-debuginfo.i686: W: spurious-executable-perm
> /usr/src/debug/libminc-libminc-2-3-00/volume_io/Geometry/tensors.c
will do chmod -x on that file.
> 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> - latest version is packaged
> - BSD license is OK
> - license file is present, %license is used
> - tests are present and pass
> - ldconfig is called
> - Provides/Requires look sane, apart from the cmake dep.
> 
> Looks fine apart from the minor issues listed above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Ah, OK, I think I messed up the repoquery call. So ignore the part about
/usr/lib/cmake.

>> libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0
>> exit@GLIBC_2.0
> looks like you got it 2 times, probably bug in rpmlint? What does it mean?

Calling exit from shared libs is discouraged because it would kill the
applications, the library should return an error instead. But it is not a
packaging issue, just a (possible) bug or misdesign in the library. You can
safely ignore it.

OK, so apart from the small fixes, everything is OK. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
%{_libdir}/cmake/LIBMINC/ → this looks suspicious. Cmake puts everything in
/usr/share/cmake asaic, nothing provides /usr/lib/cmake in Fedora.

I don't think libminc-devel should require cmake. It should be possible to link
to the library using other build systems, and cmake is a fairly large dep.

Rpmlint
---
Checking: libminc-2.3.00-1.fc24.i686.rpm
  libminc-devel-2.3.00-1.fc24.i686.rpm
  libminc-debuginfo-2.3.00-1.fc24.i686.rpm
  libminc-2.3.00-1.fc24.src.rpm
libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0
exit@GLIBC_2.0
libminc-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/libminc-libminc-2-3-00/volume_io/Geometry/tensors.c
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

- latest version is packaged
- BSD license is OK
- license file is present, %license is used
- tests are present and pass
- ldconfig is called
- Provides/Requires look sane, apart from the cmake dep.

Looks fine apart from the minor issues listed above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Igor Gnatenko  changed:

   What|Removed |Added

Summary|Review Request: libimnc -   |Review Request: libminc -
   |Core library and API of the |Core library and API of the
   |MINC toolkit|MINC toolkit



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1279064 (minc-tools)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1279064
[Bug 1279064] Review Request: minc-tools - Basic minc-tools from former
minc repository
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review