[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #34 from Fedora Update System  ---
copy-jdk-configs-1.1-3.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-12-17 02:32:38 |2016-02-26 21:01:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #33 from Fedora Update System  ---
copy-jdk-configs-1.1-3.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #31 from Fedora Update System  ---
copy-jdk-configs-1.1-3.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aa6237387c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #32 from Fedora Update System  ---
copy-jdk-configs-1.1-3.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4ee40e04b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #30 from Fedora Update System  ---
copy-jdk-configs-1.1-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4ee40e04b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #29 from Fedora Update System  ---
copy-jdk-configs-1.1-3.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aa6237387c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #28 from Fedora Update System  ---
copy-jdk-configs-1.1-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update copy-jdk-configs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-02d81c02d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #27 from Fedora Update System  ---
copy-jdk-configs-1.1-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update copy-jdk-configs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c7f9f6130e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #25 from Fedora Update System  ---
copy-jdk-configs-1.1-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-c7f9f6130e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #24 from Fedora Update System  ---
copy-jdk-configs-1.1-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-02d81c02d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #26 from Fedora Update System  ---
copy-jdk-configs-1.1-1.fc22 has been pushed to the Fedora 22 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-17 02:32:38



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #23 from Fedora Update System  ---
copy-jdk-configs-1.1-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #22 from Fedora Update System  ---
copy-jdk-configs-1.1-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update copy-jdk-configs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-dba945af4a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #21 from Fedora Update System  ---
copy-jdk-configs-1.1-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'yum --enablerepo=epel-testing update copy-jdk-configs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-1472d4279f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #9 from jiri vanek  ---
I noticed there was missing dist tag in release. Fixed.

Spec URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v5/copy-jdk-configs.spec
SRPM URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v5/copy-jdk-configs-1.0-1.fc22.src.rpm
RPM URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v5/copy-jdk-configs-1.0-1.fc22.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #10 from Michael Simacek  ---
- you should use %license macro for license instead of %doc. Also, it would be
better if you didn't install the license manually and let rpmbuild handle it
(copying it into build dir in %prep and then having just `%license LICENSE` in
%files). Just FYI, you should have replaced  with "Red Hat" in
the license.
- is there any specific reason to have it installed in /usr/share? If it's
supposed to be executed by the user, it should go to /usr/bin, otherwise to
/usr/libexec.
- you should try to preserve timestamps of the files by using -p argument of cp
- is there some documentation for it? it would be nice if it had a manpage

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/copy_jdk_configs
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/doc/copy_jdk_configs
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[?]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: 

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #14 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/copy-jdk-configs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #12 from jiri vanek  ---
Spec URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v6/copy-jdk-configs.spec
SRPM URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v6/copy-jdk-configs-1.1-1.fc22.src.rpm

RPM URL: 
https://jvanek.fedorapeople.org/copy_jdk_configs/v6/copy-jdk-configs-1.1-1.fc22.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #18 from Fedora Update System  ---
copy-jdk-configs-1.1-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-1472d4279f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #11 from jiri vanek  ---
TYVM!

(In reply to Michael Simacek from comment #10)
> - you should use %license macro for license instead of %doc. Also, it would
> be better if you didn't install the license manually and let rpmbuild handle
> it (copying it into build dir in %prep and then having just `%license
> LICENSE` in %files).

Thanx for this hint. I utterly forgot it exists. Fixed.

> Just FYI, you should have replaced  with
> "Red Hat" in the license.

fixed in upstrea and new tag added.

> - is there any specific reason to have it installed in /usr/share? If it's
> supposed to be executed by the user, it should go to /usr/bin, otherwise to
> /usr/libexec.

My reason was that /usr/share was the only place where I found soem other lua
scripts.
On contrary, libexec is full of perl or so I moved it there.

It is not expected to be launched by user.. hopefully...
I'm half inclined to put it more public and in /usr/bin (with man page and
so...) But not now. Maybe later. (once people startto ask why openjdk update
requires lua...)

> - you should try to preserve timestamps of the files by using -p argument of
> cp

fixed (via -a)

> - is there some documentation for it? it would be nice if it had a manpage

Not yet:( If it will ever go to path, then I will surely create man page.
Right now -h/--help is working!
And for testing.. feel free to get inspired by:
/usr/libexec/copy_jdk_configs.lua--currentjvm
"java-1.8.0-openjdk-1.8.0.66-3.b17.fc22.x86_64" --jvmdir "/usr/lib/jvm"
--origname "java-1.8.0-openjdk" --origjavaver "1.8.0" --arch "x86_64" --debug
true  --jvmDestdir /tmp

> 
> Package Review
> ==
...
> [?]: Package functions as described.

Example usage(s) posted.

> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [x]: Description and summary sections in the package spec file contains
>  translations for supported Non-English languages, if available.
> [x]: Package should compile and build into binary rpms on all supported
>  architectures.
> [-]: %check is present and all tests pass.
> [!]: Packages should try to preserve timestamps of original installed
>  files.

Should be fixed

> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
...
> 
> 
> Source checksums
> 
> https://hg.fedorahosted.org/hg/copy_jdk_configs/raw-file/copy_jdk_configs-1.
> 0/copy_jdk_configs.lua :
>   CHECKSUM(SHA256) this package :
> 4ce4d594897b9f099c03302943042cc46460198b858064439ce7d33be97e0b24
>   CHECKSUM(SHA256) upstream package :
> 4ce4d594897b9f099c03302943042cc46460198b858064439ce7d33be97e0b24
> https://hg.fedorahosted.org/hg/copy_jdk_configs/raw-file/copy_jdk_configs-1.
> 0/LICENSE :
>   CHECKSUM(SHA256) this package :
> 44925e9dc7359ec6e978e6e7b4662785415825854f2c828f1a17694684340ecb
>   CHECKSUM(SHA256) upstream package :
> 44925e9dc7359ec6e978e6e7b4662785415825854f2c828f1a17694684340ecb


Sources changes. I will post URLs in next comment.

TY!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Michael Simacek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Michael Simacek  ---
Looks ok to me now, APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #17 from Fedora Update System  ---
copy-jdk-configs-1.1-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-dba945af4a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #15 from Fedora Update System  ---
copy-jdk-configs-1.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-c13fd741f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #16 from Fedora Update System  ---
copy-jdk-configs-1.1-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-2f6c7508b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #20 from Fedora Update System  ---
copy-jdk-configs-1.1-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update copy-jdk-configs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-2f6c7508b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #19 from Fedora Update System  ---
copy-jdk-configs-1.1-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update copy-jdk-configs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-c13fd741f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756



--- Comment #5 from jiri vanek  ---
Spec URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v3/copy-jdk-configs.spec
SRPM URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v3/copy-jdk-configs-1-1.src.rpm
RPM URL:
https://jvanek.fedorapeople.org/copy_jdk_configs/v3/copy_jdk_configs-1-1.noarch.rpm

(In reply to Mikolaj Izdebski from comment #3)
> Major issues:
> 
> In general, "When naming packages for Fedora, the maintainer must use the
> dash '-' as the delimiter for name parts. The maintainer must NOT use an
> underscore '_'" [1]

Fixed.

> 
> There is no license file installed. You should add license file to upstream
> repo and install it using %license macro.

Currently I have no intentions to add license. Maybe I will in some future
iteration (maybe when We agree with rest of team) But It wil be BSD or some
other free license for sure.

> 
> Source0 based on hg repo tip is a bad idea. You should use proper tags
> (preferably) or revision numbers / commit IDs.

Sure. For now I had added revision number. In future, when there will be
releases, it will be replaced by tags.

> 
> Minor/cosmetic issues:
> - "Epoch: 0" line is not needed.
removed

> - Empty sections (%prep, %install) can be removed.
unless you insists, I would like to keep them in. Just for "look and know"

> - "rm -rf $RPM_BUILD_ROOT" is not needed.

removed
> - Group: tag is useless, consider removing it.

removed (thanx!)
> 
> [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators

(In reply to Mikolaj Izdebski from comment #4)
> Also there are several typos that need to be fixed in %description:
> s/Utlity/Utility/
> s/jdks/JDKs/
> s/config/configuration/
> s/upates/updates/
> add dot at the end of sentence.

fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

jiri vanek  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |copy_jdk_configs  - JDK |copy-jdk-configs  - JDK
   |config files copier |config files copier



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Michael Simacek  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1287756] Review Request: copy-jdk-configs - JDK config files copier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287756

Mikolaj Izdebski  changed:

   What|Removed |Added

   Assignee|mizde...@redhat.com |msima...@redhat.com
  Flags|fedora-review?  |



--- Comment #8 from Mikolaj Izdebski  ---
Since I'm going for vacation, Michael will continue with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review