[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-28 17:58:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006



--- Comment #7 from Fedora Update System  ---
python-pyactivetwo-0.1-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-pyactivetwo-0.1-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pyactivetwo'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-3cca7ecf2c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006



--- Comment #2 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> .egg-info doesn't need to be deleted.
Why?
> 
> cp -p %{SOURCE1} → %autosetup ... -a1 
ok
> 
> Remove empty %check.
ok
> 
> BR should be one-per-line.
I'm somehow grouping it...
> 
> - license is OK
> - license file is present, %license is used
> - new python packaging template is used
> - provides/requires are ok
> - latest version
> - no scriptlets
> - builds and installs OK
> - fedora-review is happy
> 
> rpmlint:
> 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006



--- Comment #5 from Fedora Update System  ---
python-pyactivetwo-0.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-3cca7ecf2c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Igor Gnatenko from comment #2)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> > .egg-info doesn't need to be deleted.
> Why?
The guidelines say that egg *packages* cannot be distributed, but egg
*metadata* (i.e. the directory) is not the same thing. It will be recreated, if
it is deleted, but deleting it simply isn't necessary.

> > BR should be one-per-line.
> I'm somehow grouping it...
I know. OTOH, diffs are less readable. Anyway, for a simple package like that
it doesn't matter too much.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-pyactivetwo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
.egg-info doesn't need to be deleted.

cp -p %{SOURCE1} → %autosetup ... -a1 

Remove empty %check.

BR should be one-per-line.

- license is OK
- license file is present, %license is used
- new python packaging template is used
- provides/requires are ok
- latest version
- no scriptlets
- builds and installs OK
- fedora-review is happy

rpmlint:
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289006] Review Request: python-pyactivetwo - Python library for reading signal from BioSemi ActiveTwo EEG device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289006

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1276941 (fedora-neuro)
  Alias||python-pyactivetwo




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review