[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #23 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #22 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #21 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #20 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-09 15:58:34



--- Comment #19 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #18 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff632482b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #17 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9398680d9d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #16 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-efd24a03d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #15 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-dc778209ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8fc2ba4a15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #13 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8fc2ba4a15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #12 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-dc778209ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #10 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9398680d9d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #11 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-efd24a03d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #9 from Fedora Update System  ---
bitlbee-facebook-1.1.2-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff632482b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/bitlbee-facebook

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #7 from Robert Scheck  ---
Sorry, forgot to copy the spec file. Thank you very much for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
The SRPM is good though, package is accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #5 from Robert-André Mauchin  ---
The SPEC link you provided doesn't contain any change, did you forget to update
it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #4 from Robert Scheck  ---
(In reply to Robert-André Mauchin from comment #3)
>  - please only use 1 BR and R per line for clarity

If three comma separated strings make it less readable, I'm sorry for you.

> configure: error: Package requirements (json-glib-1.0 >= 0.14.0) were not
> met:
> 
> because your BR is wrong. Fix them:
> 
> BuildRequires:pkgconfig(bitlbee) >= 3.4
> BuildRequires:pkgconfig(json-glib-1.0) >= 0.14.0

My main mistake was to use json-glib rather json-glib-devel, however the
usage of pkgconfig(…) rather …-devel is IMHO not wrong per se.


Spec URL: https://labs.linuxnetz.de/bugzilla/bitlbee-facebook.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/bitlbee-facebook-1.1.2-2.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Robert-André Mauchin  ---
Hello,

 - Group: is not needed in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - %clean and rm -rf $RPM_BUILD_ROOT should not be included either.

 - BuildRoot: is not needed either

 - Not needed too: %{!?_licensedir:%global license %%doc}

 - make %{?_smp_mflags} ⇒ %make_build

 - make DESTDIR=$RPM_BUILD_ROOT install ⇒ %make_install

 - please only use 1 BR and R per line for clarity

 - you could include ChangeLog in %doc

 - I've got a build error:

configure: error: Package requirements (json-glib-1.0 >= 0.14.0) were not met:

because your BR is wrong. Fix them:

BuildRequires:pkgconfig(bitlbee) >= 3.4
BuildRequires:pkgconfig(json-glib-1.0) >= 0.14.0

 - Package contains obsolete m4 macros

[!]: Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

Please report it upstream and patch it.

See https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html

Here's a patch for it:

diff -up bitlbee-facebook-1.1.2/configure.ac.remove_obsolete_macros
bitlbee-facebook-1.1.2/configure.ac
--- bitlbee-facebook-1.1.2/configure.ac.remove_obsolete_macros2017-08-31
01:22:50.0 +0200
+++ bitlbee-facebook-1.1.2/configure.ac2017-10-01 19:56:13.313441648 +0200
@@ -29,8 +29,7 @@ AM_INIT_AUTOMAKE([no-define])
 AC_PROG_CC
 AM_PROG_CC_C_O

-AC_DISABLE_STATIC
-AC_PROG_LIBTOOL
+LT_INIT([disable-static])

 m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
 m4_ifdef([AC_PROG_CC_C99],  [AC_PROG_CC_C99])




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL", "FSF All Permissive", "GPL (v2 or
 later)", "Unknown or generated". 24 files have unknown license.
 Detailed output of licensecheck in /home/bob/packaging/review/bitlbee-
 facebook/review-bitlbee-facebook/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/bitlbee
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build 

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #2 from Robert Scheck  ---
Spec URL: https://labs.linuxnetz.de/bugzilla/bitlbee-facebook.spec
SRPM URL: https://labs.linuxnetz.de/bugzilla/bitlbee-facebook-1.1.1-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290235



--- Comment #1 from Robert Scheck  ---
Spec URL: http://labs.linuxnetz.de/bugzilla/bitlbee-facebook.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/bitlbee-facebook-1.0.0-1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review