[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260

Colin Macdonald  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2015-12-14 13:55:08



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/perl-Text-Roman

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jitka Plesnikova  ---
The version of ExtUtils::MakeMaker 6.76  is required, if you want to use
NO_PACKLIST=1

Otherwise the package looks good. 
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260



--- Comment #4 from Colin Macdonald  ---
Ok, will do re: MakeMaker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Text-Roman-3.5-1.fc24.noarch.rpm | sort | uniq -c
  1 perl(:MODULE_COMPAT_5.22.0)
  2 perl(Carp)
  2 perl(Exporter)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Text-Roman-3.5-1.fc24.noarch.rpm | sort | uniq -c
  1 perl(Text::Roman) = 3.5
  1 perl-Text-Roman = 3.5-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-Text-Roman*
perl-Text-Roman.src: W: spelling-error Summary(en_US) algarisms -> vulgarisms,
vulgarism
perl-Text-Roman.src: W: spelling-error %description -l en_US algarisms ->
vulgarisms, vulgarism
perl-Text-Roman.src: W: spelling-error %description -l en_US algarism ->
vulgarism
perl-Text-Roman.noarch: W: spelling-error Summary(en_US) algarisms ->
vulgarisms, vulgarism
perl-Text-Roman.noarch: W: spelling-error %description -l en_US algarisms ->
vulgarisms, vulgarism
perl-Text-Roman.noarch: W: spelling-error %description -l en_US algarism ->
vulgarism
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

Rpmlint is ok

BuildRequires 
FIX: Please add following BR
- coreutils - spec file - line 28, 36
- findutils - spec file - line 36, 37
- make - spec file - line 32, 35, 41
- perl(File::Find) - Text-Roman-3.5/t/00-compile.t - line 10
- perl(strict) - Text-Roman-3.5/lib/Text/Roman.pm (line 5) and tests
- perl(warnings) - Text-Roman-3.5/lib/Text/Roman.pm (line 6) and tests

FIX: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
  %install.

FIX: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
  %install.

TODO: Please replace %{__perl} by 'perl'

TODO: Remove the deleting empty directories in %install section. This is
  default behavior.

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260



--- Comment #2 from Colin Macdonald  ---
Thanks for the quick review!

> findutils - spec file - line 36, 37

This is no longer needed.

The other corrections should be made.  New files:

https://cbm.fedorapeople.org/perl-Text-Roman-3.5-2.fc23.src.rpm
https://cbm.fedorapeople.org/perl-Text-Roman.spec
https://cbm.fedorapeople.org/perl-Text-Roman.spec-1-2.diff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260

Colin Macdonald  changed:

   What|Removed |Added

 Blocks||1290259




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1290259
[Bug 1290259] biber-v2.1 is available, should work with rawhide
texlive-biblatex 3.0
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290260] Review Request: perl-Text-Roman - Allows conversion between Roman and Arabic algarisms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290260

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review