[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Susi Lehtola  changed:

   What|Removed |Added

 Blocks|505154 (FE-SCITECH) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #26 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-02 14:21:35



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #24 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #23 from Fedora Update System  ---
python-usbtmc-0.7-1.fc22 has been pushed to the Fedora 22 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f63a7ad4c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #22 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #9 from Antonio Trande  ---
(In reply to William Moreno from comment #8)
> Package Aproved
> ===
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12639772
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12639785
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12639787
> 
> [!]: Macros in Summary, %description expandable at SRPM build time.
>  Note: Macros in: python2-usbtmc (summary)

Fixed.

> 
> Hte build still fail in epel6, note the unexpandable macro.

pyusb is still on epel6-testing but works.

Last release reloaded:

Spec URL: https://sagitter.fedorapeople.org/python-usbtmc/python-usbtmc.spec
SRPM URL:
https://sagitter.fedorapeople.org/python-usbtmc/python-usbtmc-0.6-2.fc23.src.rpm

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-usbtmc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #14 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #14 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #15 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #16 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #14 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #15 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #14 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #15 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #16 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #17 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #20 from Fedora Update System  ---
python-usbtmc-0.7-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f63a7ad4c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #14 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #15 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #16 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #17 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #18 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #11 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #12 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #13 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #14 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #15 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #16 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #17 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

--- Comment #18 from Fedora Update System  ---
python-usbtmc-0.7-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8126256965

--- Comment #19 from Fedora Update System  ---
python-usbtmc-0.7-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab960671a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from William Moreno  ---
Package Aproved
===
http://koji.fedoraproject.org/koji/taskinfo?taskID=12639772
http://koji.fedoraproject.org/koji/taskinfo?taskID=12639785
http://koji.fedoraproject.org/koji/taskinfo?taskID=12639787

[!]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python2-usbtmc (summary)

Hte build still fail in epel6, note the unexpandable macro.

I do not find bloquers, any way think about to keep a more moder python spex
for Fedora an Epel7, there is no not need to support epel6 in current packaging
guidelines for Fedora and epel7

= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. 
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of 

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #7 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-usbtmc-0.6-2.fc23.src.rpm for epel7
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12639785

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #6 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-usbtmc-0.6-2.fc23.src.rpm for
el6-candidate failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12639772

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #5 from Antonio Trande  ---
(In reply to William Moreno from comment #4)
> I think than you can continue this review and focus packaging guidelines for
> Python, you must provide a python2 subpackage for Fedora, the
> python-provides macro is redirectin python-name to python2-name for the
> moment but some time the python-provides will change to point python-name to
> python3-name so I need than you provides a python2-subpackage to aprove this
> review.

Spec URL: https://sagitter.fedorapeople.org/python-usbtmc/python-usbtmc.spec
SRPM URL:
https://sagitter.fedorapeople.org/python-usbtmc/python-usbtmc-0.6-2.fc23.src.rpm

pyusb is on epel6 (see bz#1297108)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Antonio Trande  changed:

   What|Removed |Added

External Bug ID||Red Hat Bugzilla 1297108



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #3 from Antonio Trande  ---
(In reply to William Moreno from comment #2)
> Package Review
> ==
> This package do not look bad but the epel6 build fails due a a missing pyusb
> dependency. You can go for epel7 and Fedora so you can clean the spec for
> conditionals about  currente Fedora Python Packagind guidelines requires.

Maybe I can require a rebuild of pyusb on epel6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #4 from William Moreno  ---
I think than you can continue this review and focus packaging guidelines for
Python, you must provide a python2 subpackage for Fedora, the python-provides
macro is redirectin python-name to python2-name for the moment but some time
the python-provides will change to point python-name to python3-name so I need
than you provides a python2-subpackage to aprove this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #2 from William Moreno  ---
Package Review
==
This package do not look bad but the epel6 build fails due a a missing pyusb
dependency. You can go for epel7 and Fedora so you can clean the spec for
conditionals about http://koji.fedoraproject.org/koji/taskinfo?taskID=1247

Also in Fedora and Epel7 you can use %py2_build, py2_install, py3_build and
py3_install

This way you can clean than the spec for epel7 and Fedora.

The doc directoy is a python-sphinx documentation than can build to html and
include in docs.

Also looks like upstream is using MIT and not BSD as license
https://github.com/python-ivi/python-usbtmc/blob/master/COPYING
https://fedoraproject.org/wiki/Licensing:MIT#Modern_Style_with_sublicense

= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. 
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-usbtmc , python-usbtmc-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try 

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278



--- Comment #1 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-usbtmc-0.6-1.fc23.src.rpm for epel7
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12472212

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294278] Review Request: python-usbtmc - Python implementation of the USBTMC protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294278

Antonio Trande  changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review