[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #21 from Fedora Update System  ---
python-wcwidth-0.1.6-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #20 from Fedora Update System  ---
python-wcwidth-0.1.6-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-23 20:05:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #19 from Fedora Update System  ---
python-wcwidth-0.1.6-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-218ad017f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #18 from Fedora Update System  ---
python-wcwidth-0.1.6-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-218ad017f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #17 from Fedora Update System  ---
python-wcwidth-0.1.6-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-fca79c0f1b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #12 from Fedora Update System  ---
python-wcwidth-0.1.5-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ade95e6f5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
python-wcwidth-0.1.5-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-af0dbd1d66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #13 from Fedora Update System  ---
python-wcwidth-0.1.6-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-fca79c0f1b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
python-wcwidth-0.1.5-2.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b739c3d32e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #15 from Fedora Update System  ---
python-wcwidth-0.1.5-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a4a5d84d5e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #7 from Fedora Update System  ---
python-wcwidth-0.1.5-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-af0dbd1d66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #10 from Fedora Update System  ---
python-wcwidth-0.1.5-2.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b739c3d32e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #3 from Fabio Alessandro Locati  ---
Thanks a lot for the review! :)

Blocker:
1. Yes, sorry, I messed up having on bench multiple packages requiring external
LICENSE file, they got overwritten. Fixed now [0]
2. Fixed [1]

Nice to have:
1. Done [2]

I hope the package is now ready to be shipped :).

[0]: https://fale.fedorapeople.org/aws/python-wcwidth-0.1.5-2.fc23.src.rpm
[1]: https://fale.fedorapeople.org/aws/python-wcwidth.spec
[2]: https://github.com/jquast/wcwidth/issues/14

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Terje Røsten  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Terje Røsten  ---
rpmlint warns about missing -q in %setup:

python-wcwidth.src:67: W: setup-not-quiet

The rest is good.

Package python-wcwidth is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-wcwidth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #5 from Fabio Alessandro Locati  ---
Thanks and I've added the -q to the setup :) thanks a lot!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Terje Røsten  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #2 from Terje Røsten  ---
Blockers:

1)
The included LICENSE file has nothing to do with actual LICENSE,
have you mixed up files in some way?

2)
Remove the shebang in tests/test_core.py to avoid the rpmlint warning:

python2-wcwidth.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/wcwidth/tests/test_core.py 644 /usr/bin/env
python3-wcwidth.noarch: E: non-executable-script
/usr/lib/python3.4/site-packages/wcwidth/tests/test_core.py 644 /usr/bin/env

Nice to have:

1) Create upstream ticket and ask for LICENSE to be included in source tarball
and license info included in each source file.


Full review:

Package Review
==
Legend: [X] = Pass, [!] = Fail, [-] = Not applicable

= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "Unknown or generated". 10 files have unknown
 license. Detailed output of licensecheck in
 /home/gudrun/terjeros/fedora/1295152-python-wcwidth/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[X]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[X]: Package installs properly.
[X]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[X]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[X]: Package requires other packages for directories it uses.
[X]: Package must own all directories that it creates.
[X]: Package does not own files or directories owned by other packages.
[X]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[X]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[X]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[X]: Macros in Summary, %description expandable at SRPM build time.
[X]: Dist tag is present.
[X]: Package does not contain duplicates in %files.
[X]: Permissions on files are set properly.
[X]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[X]: Package is named using only allowed ASCII characters.
[X]: Package does not use a name that already exists.
[X]: Package is not relocatable.
[X]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[X]: File names are valid UTF-8.
[X]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
 process.
[X]: A package which is used by another package via an egg interface should
 provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[X]: Package contains BR: python2-devel or python3-devel
[X]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-wcwidth , python3-wcwidth
[X]: Package functions as described.
[X]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Description and 

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Blocks||1295103
 CC||terje...@phys.ntnu.no



--- Comment #1 from Fabio Alessandro Locati  ---
*** Bug 1295102 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1295103
[Bug 1295103] Review Request: python-prompt-toolkit - Library for building
powerful interactive command lines in Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fabio Alessandro Locati  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|terje...@phys.ntnu.no



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Blocks|1295103 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1295103
[Bug 1295103] Review Request: python-prompt-toolkit - Library for building
powerful interactive command lines in Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Blocks||1295154




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1295154
[Bug 1295154] Review Request: python-prompt_toolkit - Library for building
powerful interactive command lines in Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review