[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #6 from Pier Luigi Fiorini  ---
Update:

- License comment
- Desktop file validation
- Less globs

Spec URL:
https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences.spec
SRPM URL:
https://fedorapeople.org/~plfiorini/srpms/hawaii-unstable/take2/hawaii-system-preferences-0.5.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #7 from Upstream Release Monitoring 
 ---
plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12667586

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
OK, no more issues. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/hawaii-system-preferences

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Pier Luigi Fiorini  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-01-24 14:16:44



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
With mixed licesing, you should provide a description in a comment in the spec
file.

-n %{name}-%{version} is the default for %setup.

Spec file looks nice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
+ latest version
+ license is acceptable
+ license files are present, %license is used
- I'm not convinced that the license is specified correctly
+ provides and requires look sane
+ no scriptlets present or necessary
+ description and name are OK

Appdata file is not present, but I don't think it makes much sense to include
it: this package will be installed as part of the desktop, and is useless
otherwise.

There is a desktop file, maybe add
%check desktop-file-validate ...
?

More of an upstream issue, please notify developers:
DISPLAY= /usr/bin/hawaii-system-preferences
QXcbConnection: Could not connect to display 
Aborted (core dumped)

So the only notable issue is the licensing. Can you clarify which parts in the
binary rpm are under which licenses?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #4 from Pier Luigi Fiorini  ---
License: Executable is GPL2+, preference applets are LGPL2.1+.

Appdata: I didn't include it because it might be useless for other people.
Actually I can check what gnome-control-center and systemsettings do.

Desktop files: yes there are a bunch of desktop files, will add validation with
the next iteration.

Upstream issue: Yeah looks like a Qt issue, happens with other programs too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Pier Luigi Fiorini from comment #4)
> License: Executable is GPL2+, preference applets are LGPL2.1+.
OK. Please add a comment in the spec file.

> Appdata: I didn't include it because it might be useless for other people.
Right. That's what I said ;)

> Actually I can check what gnome-control-center and systemsettings do.
OK.

Hm, gnome-control-center does have an appdata file. But gnome-software refuses
to show it. It also fails validation. I'm not sure what the proper resolution
is here. You might want to ask on fedora-devel. Either way, the package can go
in without appdata.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Pier Luigi Fiorini  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231



--- Comment #1 from Upstream Release Monitoring 
 ---
plfiorini's scratch build of hawaii-system-preferences-0.5.0-1.fc23.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12432770

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295231] Review Request: hawaii-system-preferences - Utilities to configure the Hawaii desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295231

Pier Luigi Fiorini  changed:

   What|Removed |Added

  Alias||hawaii-system-preferences



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review