[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549

Kevin Kofler  changed:

   What|Removed |Added

 Blocks||1303611




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1303611
[Bug 1303611] QtWebEngine
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549

Kevin Kofler  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-01-10 17:13:07



--- Comment #15 from Kevin Kofler  ---
qt5-qtwebengine-5.6.0-0.6.beta.fc24 now successfully built in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #14 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/qt5-qtwebengine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Rex Dieter  ---
Thanks for the heroic effort here, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #13 from Kevin Kofler  ---
Wow, thanks! I requested the package creation through pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #11 from Kevin Kofler  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/kkofler/qtwebengine/qt5-qtwebengine.git/plain/qt5-qtwebengine.spec?id=560090c51468c04db69325987997b19ef3cffe0d
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kkofler/qtwebengine/fedora-rawhide-x86_64/00152190-qt5-qtwebengine/qt5-qtwebengine-5.6.0-0.4.beta.fc24.src.rpm

* Fri Jan 08 2016 Kevin Kofler  - 5.6.0-0.4.beta1
- Fix License tag
- Use %%_qt5_examplesdir macro
- Add Provides: bundled(*) for all the bundled libraries that I found

It took me 2 hours to check (and document, so that we know how to update it in
the future) all the bundled stuff. :-(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #9 from Kevin Kofler  ---
I'll update the specfile ASAP, probably tonight: 1. is already done in my local
copy, 2. is trivial, but for 3., I need to check which of the Provides from
chromium.spec actually apply here: QtWebEngine compiles only a subset of
Chromium, so I need to check in the build.log what third_party stuff is
actually being built (and the "Provides: bundled(kitchensink) = 1" probably
doesn't belong ;-) ).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #5 from Kevin Kofler  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/kkofler/qtwebengine/qt5-qtwebengine.git/plain/qt5-qtwebengine.spec?id=849178c1d044af50e13552490c81801565aef547
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kkofler/qtwebengine/fedora-rawhide-x86_64/00151796-qt5-qtwebengine/qt5-qtwebengine-5.6.0-0.3.beta.fc24.src.rpm
Description: Qt5 - QtWebEngine components.

* Wed Jan 06 2016 Kevin Kofler  - 5.6.0-0.3.beta1
- linux-pri patch: Add use_system_protobuf, went missing in the 5.6 rebase

* Wed Jan 06 2016 Kevin Kofler  - 5.6.0-0.2.beta1
- linux-pri patch: Add missing newline at the end of the log line
- Use export for NINJA_PATH (fixes system ninja-build use)

* Wed Jan 06 2016 Kevin Kofler  - 5.6.0-0.1.beta1
- Readd BR pkgconfig(jsoncpp) because linux.pri now checks for it
- BR yasm only on x86 (i686, x86_64)
- Add dot at the end of %%description
- Rebase no-format patch
- Replace unbundle-gyp.patch with new linux-pri.patch
- Use system ninja-build instead of the bundled one
- Run the unbundling script replace_gyp_files.py in linux.pri rather than here
- Update file list for 5.6.0-beta (no more libffmpegsumo since Chromium 45)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #7 from Kevin Kofler  ---
I've just noticed that the License tag is incomplete. Spot's chromium.spec has
this:
License: BSD and LGPLv2+ and ASL 2.0 and IJG and MIT and GPLv2+ and ISC and
OpenSSL and (MPLv1.1 or GPLv2 or LGPLv2)
which is closer to the truth. We don't build with OpenSSL though, and of course
we have to add the License of Qt's parts, so the License should be something
like:
License: (LGPLv2 with exceptions or GPLv3 with exceptions) and BSD and LGPLv2+
and ASL 2.0 and IJG and MIT and GPLv2+ and ISC and (MPLv1.1 or GPLv2 or LGPLv2)
I'll fix it in the next build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #6 from Kevin Kofler  ---
So, this one is now for Rawhide, as required by the review guidelines.

Successful Rawhide build (i686 (with SSE2), x86_64):
https://copr.fedoraproject.org/coprs/kkofler/qtwebengine/build/151796/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549

Kevin Kofler  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Alias||qt5-qtwebengine,
   ||qtwebengine




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #3 from Kevin Kofler  ---
pkgconfig(gio-2.0) is also not used, QtWebEngine explicitly passes -Duse_gio=0.
I guess I need to go through each and every BuildRequire and check with
build.log whether it's actually used. :-(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #2 from Kevin Kofler  ---
* I noticed at least two more BRs that appears to be unused: pkgconfig(libexif)
and pkgconfig(hunspell). I don't see these being included/linked anywhere (nor
do I see a bundled versions being built, either; the strings "exif" and
"hunspell" do not show up at all in my build.log).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549

Kevin Kofler  changed:

   What|Removed |Added

 CC||he...@kde.org



--- Comment #1 from Kevin Kofler  ---
*** Bug 1244196 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295549] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295549



--- Comment #4 from Kevin Kofler  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/kkofler/qtwebengine/qt5-qtwebengine.git/plain/qt5-qtwebengine.spec?id=a63544c8d0e9c07fbe3649f7183bff67114e0c61
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kkofler/qtwebengine/fedora-23-x86_64/00151506-qt5-qtwebengine/qt5-qtwebengine-5.5.1-4.fc23.src.rpm

* Tue Jan 05 2016 Kevin Kofler  - 5.5.1-4
- Remove unused BRs flex, libgcrypt-devel, bzip2-devel, pkgconfig(gio-2.0),
  pkgconfig(hunspell), pkgconfig(libpcre), pkgconfig(libssl),
  pkgconfig(libcrypto), pkgconfig(jsoncpp), pkgconfig(libmtp),
  pkgconfig(libexif), pkgconfig(liblzma), pkgconfig(cairo), pkgconfig(libusb),
  perl(version), perl(Digest::MD5), perl(Text::ParseWords), ruby
- Add missing explicit BRs on pkgconfig(x11),  pkgconfig(xext),
  pkgconfig(xfixes), pkgconfig(xdamage), pkgconfig(egl)
- Fix BR pkgconfig(flac++) to pkgconfig(flac) (libFLAC++ not used, only
libFLAC)
- Fix BR python-devel to python
- Remove unused -Duse_system_openssl=1 flag (QtWebEngine uses NSS instead)
- Remove unused -Duse_system_jsoncpp=1 and -Duse_system_libusb=1 flags

This is probably the last 5.5.x build I'm doing, now we need to get started on
5.6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review