[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301
Bug 1298301 depends on bug 1298307, which changed state.

Bug 1298307 Summary: nodejs-spdx-license-ids-3.0.7 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1298307

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Jared Smith  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-01-15 07:47:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Tom Hughes  changed:

   What|Removed |Added

 CC||t...@compton.nu
 Depends On||1298269




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1298269
[Bug 1298269] Review Request: nodejs-spdx-expression-parse - Parse SPDX
license expressions
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301
Bug 1298301 depends on bug 1298269, which changed state.

Bug 1298269 Summary: Review Request: nodejs-spdx-expression-parse - Parse SPDX 
license expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1298269

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Piotr Popieluch  changed:

   What|Removed |Added

 CC||piotr1...@gmail.com
 Depends On||1298307




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1298307
[Bug 1298307] nodejs-spdx-license-ids-1.2.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
%description should start with a capital letter and end with a dot.
Please put something there that it not the same as %summary.

+ license is OK (apache 2.0)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ spec file looks fine
+ fedora-review is happy
+ provides/requires look sane

rpmlint is OK:
nodejs-spdx-correct.noarch: W: only-non-binary-in-usr-lib
nodejs-spdx-correct.noarch: W: dangling-symlink
/usr/lib/node_modules/spdx-correct/node_modules/spdx-license-ids
/usr/lib/node_modules/spdx-license-ids
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301

Jared Smith  changed:

   What|Removed |Added

 Blocks||1298310




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1298310
[Bug 1298310] Review Request: nodejs-validate-npm-package-license - Give me
a string and I'll tell you if it's a valid npm package license string
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298301] Review Request: nodejs-spdx-correct - Correct invalid SPDX identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298301



--- Comment #1 from Jared Smith  ---
This package also depends on a newer version of nodejs-spdx-license-ids.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review