[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #19 from Fedora Update System  ---
pgcenter-0.2.0-3.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 23:49:32



--- Comment #18 from Fedora Update System  ---
pgcenter-0.3.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #17 from Fedora Update System  ---
pgcenter-0.3.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-bf2cfd3c17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #14 from Fedora Update System  ---
pgcenter-0.2.0-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-677e05a3bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
pgcenter-0.2.0-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-677e05a3bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #16 from Fedora Update System  ---
pgcenter-0.2.0-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-748199b57f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #13 from Fedora Update System  ---
pgcenter-0.2.0-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-748199b57f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #11 from Pavel Alexeev  ---
Thank you very much. I'll include man and changelog on import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/pgcenter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from gil cattaneo  ---
Suggestions:

install man page.
pgcenter.i686: W: no-manual-page-for-binary pgcenter

Manual page is available in pgcenter-0.2.0/doc/pgcenter.1.gz

install, also, pgcenter-0.2.0/doc/Changelog

Seem all ok. Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #9 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 6 files have unknown
 license. Detailed output of licensecheck in
 /home/gil/1302053-pgcenter/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
 pgcenter-0.2.0/qstats.h
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 pgcenter-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of 

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #8 from Pavel Alexeev  ---
Thank you gil. I took super-csv.

Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/d5f1b01151f8c0e05de363244f42fb271d3924e9
Spec:
https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/d5f1b01151f8c0e05de363244f42fb271d3924e9/SPECS/pgcenter.spec
Srpm: http://rpm.hubbitus.info/Fedora23/pgcenter/pgcenter-0.2.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #5 from Upstream Release Monitoring 
 ---
hubbitus's scratch build of pgcenter-0.2.0-1.fc23.x86_64.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12730350

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #6 from Upstream Release Monitoring 
 ---
hubbitus's scratch build of pgcenter-0.2.0-1.fc23.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12730379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #7 from Upstream Release Monitoring 
 ---
hubbitus's scratch build of pgcenter-0.2.0-2.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12731876

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #4 from gil cattaneo  ---
can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1301589 for me?
thanks in advance

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #1 from Upstream Release Monitoring 
 ---
gil's scratch build of pgcenter-0.2.0-1.fc23.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12692872

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #2 from gil cattaneo  ---
(In reply to Upstream Release Monitoring from comment #1)
> gil's scratch build of pgcenter-0.2.0-1.fc23.src.rpm for rawhide failed
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12692872

+ make -j4
make: --libs: Command not found
gcc -g -std=gnu99 -Wall -pedantic -I/usr/include -L/usr/lib -o pgcenter
pgcenter.c  -lmenu -lpq
/usr/bin/ld: /tmp/ccXlDna5.o: undefined reference to symbol 'echo'
/lib/libncurses.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
Makefile:25: recipe for target 'pgcenter' failed
make: *** [pgcenter] Error 1
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.EZNUY4 (%build)
Bad exit status from /var/tmp/rpm-tmp.EZNUY4 (%build)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #3 from gil cattaneo  ---
NOTE: you should use %license macro to handle COPYRIGHT file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review