[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-12 12:12:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547



--- Comment #10 from Fedora Update System  ---
lyra-0.5.2-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
lyra-0.5.2-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-78e6fb6dbd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547



--- Comment #8 from Fedora Update System  ---
lyra-0.5.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-78e6fb6dbd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/lyra

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
 Blocks|652183 (FE-JAVASIG) |



--- Comment #6 from Raphael Groner  ---
Thanks for the review!


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Luya Tshimbalanga  ---
Based on the guideline, this package passed all review so it is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Luya Tshimbalanga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #4 from Luya Tshimbalanga  ---
Here is the complete review following the packaging guideline for Java

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 63 files have unknown license. However the
LICENSE
 file is present which is ASL 2.0
 packaging/review/1305547-lyra/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
 Note: Ignoring rpmlint comment about spelling error because words are in
America English
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Raphael Groner  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|l...@fedoraproject.org



--- Comment #3 from Raphael Groner  ---
Hi Luya,

please take this review in swap for bug #1329424.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547
Bug 1305547 depends on bug 1305365, which changed state.

Bug 1305365 Summary: Review Request: concurrentunit - Toolkit for testing 
multi-threaded and asynchronous applications
https://bugzilla.redhat.com/show_bug.cgi?id=1305365

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547



--- Comment #1 from Upstream Release Monitoring 
 ---
raphgro's scratch build of lyra-0.5.2-1.fc23.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12902974

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Raphael Groner  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)
 Depends On||1305365, 1168017




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1168017
[Bug 1168017] Review Request: rabbitmq-java-client - Java Advanced Message
Queue Protocol client library
https://bugzilla.redhat.com/show_bug.cgi?id=1305365
[Bug 1305365] Review Request: concurrentunit - Toolkit for testing
multi-threaded and asynchronous applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547



--- Comment #2 from Raphael Groner  ---
(In reply to Upstream Release Monitoring from comment #1)
> raphgro's scratch build of lyra-0.5.2-1.fc23.src.rpm for rawhide failed
> http://koji.fedoraproject.org/koji/taskinfo?taskID=12902974

Logical reason, concurrentunit is not available yet in rawhide, see bug
#1305365.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review