[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #19 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-29 19:20:09



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #18 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #17 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d998681c55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2d8a0763ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #15 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Igor Gnatenko from comment #10)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> > $ appstream-util validate
> > /usr/share/appdata/julietaula-montserrat.metainfo.xml
> > /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED:
> > • style-invalid : Not enough  tags for a good description
> > Validation of files failed
> 
> validate-relax ;)

The spec file has validate-relax already, and that's the right thing to use for
%check. But it's sometimes good to check what the "non-relax" version says.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #14 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.el6 has been submitted as an update to
Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7dc6c6d417

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #13 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7c72af3d2a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #12 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc22 has been submitted as an update to
Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ae2c22107d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #11 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2d8a0763ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #10 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> $ appstream-util validate
> /usr/share/appdata/julietaula-montserrat.metainfo.xml
> /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED:
> • style-invalid : Not enough  tags for a good description
> Validation of files failed

validate-relax ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #9 from Fedora Update System  ---
julietaula-montserrat-fonts-20151221-4.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d998681c55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #8 from Luya Tshimbalanga  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> $ appstream-util validate
> /usr/share/appdata/julietaula-montserrat.metainfo.xml
> /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED:
> • style-invalid : Not enough  tags for a good description
> Validation of files failed
> 
> Would be nice to extend the description with a second paragraph to make
> gnome-software happy.
> 
> No other issues. Package is APPROVED.

Thank you, Zbigniew. appstram-util is too picky sometimes. I will do on the
next update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
$ appstream-util validate /usr/share/appdata/julietaula-montserrat.metainfo.xml
/usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED:
• style-invalid : Not enough  tags for a good description
Validation of files failed

Would be nice to extend the description with a second paragraph to make
gnome-software happy.

No other issues. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #6 from Luya Tshimbalanga  ---
Here is the updated files addressing following issues:
- Change %doc to %license
- Deleted oft and ttf subdirectories

SPEC url:
https://luya.fedorapeople.org/packages/SPECS/julietaula-montserrat-fonts.spec

SRMP url:
https://luya.fedorapeople.org/packages/SRPMS/julietaula-montserrat-fonts-20151221-3.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

+ license is acceptable (OFL)
+ license file is present
+ version is recent (git snapshot)
+ provides/requires look OK
+ font packaging guidelines are followed

One question: why do you add separate otf, ttf subdirs? Other font packages
don't do that afaics. There's a problem with directory ownership too: No known
owner of /usr/share/fonts/julietaula-montserrat/otf,
/usr/share/fonts/julietaula-montserrat/ttf.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #4 from Luya Tshimbalanga  ---
(In reply to Igor Gnatenko from comment #3)
> One small note - move appstream-util call to check section.

Done. Here is the updated spec and new srpm:
SPEC url:
https://luya.fedorapeople.org/packages/SPECS/julietaula-montserrat-fonts.spec

SRMP url:
https://luya.fedorapeople.org/packages/SRPMS/julietaula-montserrat-fonts-20151221-2.fc23.src.rpm

Note: appdata guideline was unclear about appstream-util located on %check
section, it mentioned either that or %install. Perhaps updating a spec file
example for good reference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208

Igor Gnatenko  changed:

   What|Removed |Added

 CC||i.gnatenko.br...@gmail.com



--- Comment #3 from Igor Gnatenko  ---
One small note - move appstream-util call to check section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #2 from Luya Tshimbalanga  ---
(In reply to Luya Tshimbalanga from comment #1)
> Scratch build result:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=13450907

Disregard the first scratch build because it is older version. 
http://koji.fedoraproject.org/koji/taskinfo?taskID=13451967

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321208] Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321208



--- Comment #1 from Luya Tshimbalanga  ---
Scratch build result:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13450907

rpmlint result:
$ rpmlint rpmbuild/SRPMS/julietaula-montserrat-fonts-20151221-1.fc23.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint rpmbuild/SPECS/julietaula-montserrat-fonts.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review