[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-08-22 03:29:43



--- Comment #7 from Igor Gnatenko  ---
Unfortunately I don't have time to work on these review requests anymore,
sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JYYA7UMRAUMAT2QAS5BCOF3POFU4M2P6/

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Marek Cermak  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Marek Cermak  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #6 from Marek Cermak  ---

Initial fedora-review output 


+ py.test-2 -v tests/
= test session starts
==
platform linux2 -- Python 2.7.13, pytest-3.1.1, py-1.4.34, pluggy-0.4.0 --
/usr/bin/python2

tests/test_forwarder.py::SSHClientTest::test_connect_via_proxy FAILED
ts/test_forwarder.py::SSHClientTest::test_deprecate_warnings_are_shown FAILED
tests/test_forwarder.py::AuxiliaryTest::test_read_ssh_config FAILED

= FAILURES ===

_ SSHClientTest.test_connect_via_proxy
_


E   OSError: [Errno 2] No such file or directory
/usr/lib64/python2.7/subprocess.py:1024: OSError


___ SSHClientTest.test_deprecate_warnings_are_shown



E   IndexError: list index out of range
tests/test_forwarder.py:656: IndexError


__ AuxiliaryTest.test_read_ssh_config
__

E   AssertionError: None is not true
tests/test_forwarder.py:1183: AssertionError

=== 3 failed, 40 passed, 1 xpassed in 20.43 seconds



+ py.test-3 -v tests/
= test session starts
==
platform linux -- Python 3.6.1, pytest-3.1.1, py-1.4.34, pluggy-0.4.0 --
/usr/bin/python3

tests/test_forwarder.py::SSHClientTest::test_connect_via_proxy FAILED
tests/test_forwarder.py::SSHClientTest::test_gateway_ip_unresolvable_raises_exception
FAILED
tests/test_forwarder.py::AuxiliaryTest::test_read_ssh_config FAILED

=== FAILURES
===

_ SSHClientTest.test_connect_via_proxy
_

E   FileNotFoundError: [Errno 2] No such file or directory: 'ssh'
/usr/lib64/python3.6/subprocess.py:1326: FileNotFoundError


_ SSHClientTest.test_gateway_ip_unresolvable_raises_exception
__

Unexpected success


__ AuxiliaryTest.test_read_ssh_config
__

E   AssertionError: None is not true
tests/test_forwarder.py:1183: AssertionError

= 3 failed, 41 passed in 15.79 seconds
=


RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.Py7mcD (%check)
Bad exit status from /var/tmp/rpm-tmp.Py7mcD (%check)


Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/mockbuild/trace_decorator.py", line
96, in trace
result = func(*args, **kw)
  File "/usr/lib/python3.6/site-packages/mockbuild/util.py", line 590, in do
raise exception.Error("Command failed: \n # %s\n%s" % (command, output),
child.returncode)
mockbuild.exception.Error: Command failed:
 # /usr/bin/systemd-nspawn -q -M eea7d073d1694b8093e8b911268aa8b6 -D
/var/lib/mock/fedora-rawhide-x86_64/root -a --private-network
--setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
--setenv=PROMPT_COMMAND=printf "\033]0;\007"
--setenv=PS1= \s-\v\$  --setenv=LANG=en_US.UTF-8 -u mockbuild bash
--login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
/builddir/build/SPECS/python-sshtunnel.spec


-


Modified spec file to bypass %check errors in such manner that: 
=

$ diff python-sshtunnel.spec.old python-sshtunnel.spec
63c63
< py.test-3 -v tests/ 
---
> py.test-3 -v tests/ || :

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 20 files have
 unknown license. Detailed output of licensecheck in
 /home/macermak/RedHat/Fedora/Reviews/1321449/review-python-
 sshtunnel/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in 

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Marek Cermak  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Marek Cermak  changed:

   What|Removed |Added

 CC||macer...@redhat.com
   Assignee|nob...@fedoraproject.org|macer...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449



--- Comment #5 from Igor Gnatenko  ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=13544422

In koji there is some other build failures which I will fix ASAP. (Those are
tests which we could skip after all)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449



--- Comment #4 from Igor Gnatenko  ---
(In reply to Ralf Senderek from comment #3)
> (In reply to Igor Gnatenko from comment #2)
> > (In reply to Ralf Senderek from comment #1)
>  
> > It requires everything from rawhide (at least paramiko 2/3 was correctly
> > splitted only in rawhide). I'm not planning to add it to f24-.
> 
> Ok, I tried a KOJI build for rawhide that had all these packages installed
> and also bytecompiled the *.py files but failed in %check.
> 
> see: http://koji.fedoraproject.org/koji/taskinfo?taskID=13544186 
> 
> t"e "tests/test_forwarder.py" file might need adaptation to the environment
> in which mock runs?

Oops, I missed this point. Fixed it by adding BuildRequires: pythonX-mock

URLs are the same. SRPm and SPEC updated. Thanks for pointing out!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449



--- Comment #3 from Ralf Senderek  ---
(In reply to Igor Gnatenko from comment #2)
> (In reply to Ralf Senderek from comment #1)

> It requires everything from rawhide (at least paramiko 2/3 was correctly
> splitted only in rawhide). I'm not planning to add it to f24-.

Ok, I tried a KOJI build for rawhide that had all these packages installed
and also bytecompiled the *.py files but failed in %check.

see: http://koji.fedoraproject.org/koji/taskinfo?taskID=13544186 

t"e "tests/test_forwarder.py" file might need adaptation to the environment
in which mock runs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449



--- Comment #2 from Igor Gnatenko  ---
(In reply to Ralf Senderek from comment #1)
> The package failed to build.
> 
> root.log gave me four errors complaining that those required packages 
> cannot be found in mock:
> 
> python2-paramiko
> python2-pytest
> python2-setuptools
> python3-paramiko

It requires everything from rawhide (at least paramiko 2/3 was correctly
splitted only in rawhide). I'm not planning to add it to f24-.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Ralf Senderek  changed:

   What|Removed |Added

 CC||fed...@senderek.ie



--- Comment #1 from Ralf Senderek  ---
The package failed to build.

root.log gave me four errors complaining that those required packages 
cannot be found in mock:

python2-paramiko
python2-pytest
python2-setuptools
python3-paramiko

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review