[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-28 01:18:03



--- Comment #9 from Fedora Update System  ---
python3-dbus-1.2.4-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python3-dbus-1.2.4-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3606e79612

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636



--- Comment #7 from Fedora Update System  ---
python3-dbus-1.2.4-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3606e79612

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-dbus

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Tim Orling  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Tim Orling  ---
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16344573

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.
- Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
  => This is ok, as 'autoupdate' is used in spec file to replace obsolete
macros


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 => expected behavior for python extensions, *.so -> site-packages
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 10 files have
 unknown license. Detailed output of licensecheck in
 /home/parallels/1324636-python3-dbus/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
 => EPEL7 has no owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python34-dbus (summary), python34-dbus (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: 

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Orion Poplawski  changed:

   What|Removed |Added

  Flags|needinfo?(or...@cora.nwra.c |
   |om) |



--- Comment #4 from Orion Poplawski  ---
Thanks for the review.

Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-dbus.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-dbus-1.2.4-2.el7.src.rpm

* Mon Nov 7 2016 Orion Poplawski  - 1.2.4-2
- Run autoupdate to remove obsolete macros such as AC_PROG_LIBTOOL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Tim Orling  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com
  Flags||needinfo?(or...@cora.nwra.c
   ||om)



--- Comment #3 from Tim Orling  ---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16285520

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
[x] This is ok, as %{python3_pkgversion}-devel is used and this is EPEL only.
- Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[!]  AC_PROG_LIBTOOL present. Suggested replacement is LT_INIT


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 10 files have
 unknown license. Detailed output of licensecheck in
 /home/parallels/1324636-python3-dbus/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a 

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|williamjmore...@gmail.com   |ticot...@gmail.com
  Flags|needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #2 from Tim Orling  ---
I will take over the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Orion Poplawski  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #1 from Orion Poplawski  ---
William - are you still handling this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org