[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1394789




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394789
[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility
and agility
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #13 from Fedora Update System  ---
libtermkey-0.18-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #12 from Fedora Update System  ---
libtermkey-0.18-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-25 09:55:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #11 from Fedora Update System  ---
libtermkey-0.18-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-da3f432a8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
libtermkey-0.18-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0cd6b1c21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #9 from Fedora Update System  ---
libtermkey-0.18-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-da3f432a8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #8 from Fedora Update System  ---
libtermkey-0.18-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0cd6b1c21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libtermkey

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Alias|libtermkey  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198
Bug 1327198 depends on bug 1327160, which changed state.

Bug 1327160 Summary: Review Request: unibilium - Terminfo parsing library
https://bugzilla.redhat.com/show_bug.cgi?id=1327160

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Josef Ridky  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #6 from Jaroslav Škarvada  ---
(In reply to Igor Gnatenko from comment #5)
> Upstream is dead -> no bugtracker, no public repository.
Hmm, from the upstream website:

> Note: This project is now DEAD; end-of-life. There will likely be no further
> releases.
>
> All of the code will be migrated into libtickit instead. libtermkey should not
> be used for new programs; use libtickit.

AFAIK it's not against any guideline to add dead/EOL code into Fedora, well you
will maintain it :) , but such packages are usually quickly orphaned or dropped
when something breaks and can also pose higher security risk.

Cannot be the project of interest switched to libtickit or some different
library? Maybe some work for now, but definitely less maintainer work in the
future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Jaroslav Škarvada  changed:

   What|Removed |Added

 CC||jskar...@redhat.com



--- Comment #3 from Jaroslav Škarvada  ---
(In reply to Igor Gnatenko from comment #2)
> >  - The MIT/X11 is not in the .spec file under License tag.
> > License:MIT
> then what's there? ;)

It's false positive from the fedora-review wrongly marked by reviewer as
failure, please ignore it.

But:
libtermkey.x86_64: W: shared-lib-calls-exit /usr/lib64/libtermkey.so.1.12.0
exit@GLIBC_2.2.5

Why it needs to call exit? Could you forward this upstream?

And it would be also great to pull request the fix-test-compile patch upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #5 from Igor Gnatenko  ---
(In reply to Jaroslav Škarvada from comment #3)
> (In reply to Igor Gnatenko from comment #2)
> > >  - The MIT/X11 is not in the .spec file under License tag.
> > > License:MIT
> > then what's there? ;)
> 
> It's false positive from the fedora-review wrongly marked by reviewer as
> failure, please ignore it.
;)
> 
> But:
> libtermkey.x86_64: W: shared-lib-calls-exit /usr/lib64/libtermkey.so.1.12.0
> exit@GLIBC_2.2.5
> 
> Why it needs to call exit? Could you forward this upstream?
i don't know. see below about upstream.
> 
> And it would be also great to pull request the fix-test-compile patch
> upstream.
Upstream is dead -> no bugtracker, no public repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #4 from Jaroslav Škarvada  ---
Otherwise it seems OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #2 from Igor Gnatenko  ---
>  - The MIT/X11 is not in the .spec file under License tag.
> License:MIT
then what's there? ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #1 from Josef Ridky  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 29 files have
 unknown license. Detailed output of licensecheck in
 /home/jridky/fedrr/1327198-libtermkey/licensecheck.txt

 - The MIT/X11 is not in the .spec file under License tag.

[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 libtermkey-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages 

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Josef Ridky  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jri...@redhat.com
   Assignee|nob...@fedoraproject.org|jri...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1327160 (unibilium)
  Alias||libtermkey




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327160
[Bug 1327160] Review Request: unibilium - Terminfo parsing library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org