[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Pete Walter  changed:

   What|Removed |Added

 Attachment|0   |1
#1259349 is||
   obsolete||



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Pete Walter  changed:

   What|Removed |Added

 Attachment|0   |1
#1256677 is||
   obsolete||



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Pete Walter  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|needinfo?(walter.pete@yande |
   |x.com)  |



--- Comment #27 from Pete Walter  ---
(In reply to Jeremy Newton from comment #2)
> I'm interested in reviewing this. Can you please update it to the latest
> (v7.2.1)?

Done, sorry for the delay. I've also incorporated various other suggestions
from the comments here.

* Fri Mar 03 2017 Pete Walter  - 8.2-1
- Update to 8.2
- Simplify files list
- Build with Python 3 (#1343710)
- Add missing python3-requests dependency (#1343710)
- Update package description

Spec URL: https://pwalter.fedorapeople.org/chrome-gnome-shell.spec
SRPM URL:
https://pwalter.fedorapeople.org/chrome-gnome-shell-8.2-1.fc25.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 Attachment|0   |1
#1237443 is||
   obsolete||



--- Comment #26 from Mark Harfouche  ---
Created attachment 1259349
  --> https://bugzilla.redhat.com/attachment.cgi?id=1259349=edit
Version 8.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Kai Engert (:kaie)  changed:

   What|Removed |Added

 CC||xzj...@gmail.com



--- Comment #25 from Kai Engert (:kaie)  ---
*** Bug 1418324 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #24 from Mark Harfouche  ---
Note, I had to add `-DPython_ADDITIONAL_VERSIONS=3` to cmake as well as change
the dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #23 from Mark Harfouche  ---
Created attachment 1256677
  --> https://bugzilla.redhat.com/attachment.cgi?id=1256677=edit
Now uses Python 3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #22 from Yuri Konotopov  ---
I also suggest to use Python 3 for this package.

See also Debian bug https://bugs.debian.org/851479

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #21 from Mark Harfouche  ---
Sure, 

I've been too busy to stay active to find a sponsor. Go for it :D.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #20 from jeremy9...@gmail.com ---
Hello,

Firefox 52 come really soon (march 7) and maybe Jeremy should take the package,
at least for now, to be in time for Firefox 52 ?

Thanks !

https://wiki.mozilla.org/RapidRelease/Calendar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #19 from Mark Harfouche  ---
Jeremy,

The process requires a little reading on my part. I'll look at it this weekend.

In the mean time, I have no issue if you want to take this on and publish it.
There will always be more packages. It seems eventually I can become a
co-maintainer.

Mark

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #18 from Jeremy Newton  ---
(In reply to Mark Harfouche from comment #17)
> Jeremy,
> 
> I'm not too knowledgeable about all of Fedora's packaging guidelines,
> especially pertaining to licensing.
> 
> In either case, I could probably take this one over until it gets too
> complicated to package. How would I go about getting sponsorship?
> 
> Mark

If you would like to become a fedora packager, please read the following wiki:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

If you don't want to be a packager, I can take the package instead and another
sponsored packager can review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #17 from Mark Harfouche  ---
Jeremy,

I'm not too knowledgeable about all of Fedora's packaging guidelines,
especially pertaining to licensing.

In either case, I could probably take this one over until it gets too
complicated to package. How would I go about getting sponsorship?

Mark

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #16 from Jeremy Newton  ---
Mark, if you can get sponsorship, you're welcome to take this package as it
seems to be abandoned.

As well, if anyone is interested in reviewing this, I am willing to take this
package from Pete.

I would personally like this package in Fedora, so I am open to being either
the packager or reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Jeremy Newton  changed:

   What|Removed |Added

 CC||walter.p...@yandex.com
  Flags||needinfo?(walter.pete@yande
   ||x.com)



--- Comment #15 from Jeremy Newton  ---
Pete, are you still interested in packaging this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 Attachment|0   |1
#1237374 is||
   obsolete||



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 Attachment|0   |1
#1237430 is||
   obsolete||



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #14 from Mark Harfouche  ---
Created attachment 1237443
  --> https://bugzilla.redhat.com/attachment.cgi?id=1237443=edit
8-6 python-requests runtime dependency

Thanks Yuri

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #13 from Yuri Konotopov  ---
Mark, python-requests runtime dependency is missing.
It was added in v8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #12 from Mark Harfouche  ---
Created attachment 1237430
  --> https://bugzilla.redhat.com/attachment.cgi?id=1237430=edit
8-5 different extensions in different packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #11 from Mark Harfouche  ---
Once this gets accepted, I don't see why we should have 1 package for chrome
chromium and firefox. It should really be split into 3 with 1 base package (and
maybe 1 package that requires all 3 browser extensions).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #10 from Mark Harfouche  ---
Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 Attachment|0   |1
#1237372 is||
   obsolete||



--- Comment #9 from Mark Harfouche  ---
Created attachment 1237374
  --> https://bugzilla.redhat.com/attachment.cgi?id=1237374=edit
8-4

As Yuri Konotopov's comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #8 from Yuri Konotopov  ---
(In reply to Mark Harfouche from comment #4)
> 
> It creates a file for firefox in /usr/lib64 even on the 32 bit platform.

You could specify CMAKE_INSTALL_LIBDIR to force library directory and skip
cmake's autodetection:

%cmake . \
-DBUILD_EXTENSION=OFF \
-DCMAKE_INSTALL_LIBDIR=%{_lib}

Also jq is build-time dependency [1] and not needed at runtime. I think
jq-devel is not needed at all.

[1]
https://wiki.gnome.org/Projects/GnomeShellIntegrationForChrome/Installation#Cmake_installation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #7 from Mark Harfouche  ---
Created attachment 1237372
  --> https://bugzilla.redhat.com/attachment.cgi?id=1237372=edit
v8 for both 32 and 64 bit

probably doesn't work for firefox 32bit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 Attachment|0   |1
#1237368 is||
   obsolete||



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #6 from Mark Harfouche  ---
https://copr.fedorainfracloud.org/coprs/hmaarrfk/chrome-gnome-shell/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #5 from Mark Harfouche  ---
Created attachment 1237368
  --> https://bugzilla.redhat.com/attachment.cgi?id=1237368=edit
Chrome gnome shell vr 8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Mark Harfouche  changed:

   What|Removed |Added

 CC||mark.harfou...@gmail.com



--- Comment #4 from Mark Harfouche  ---
Here is an updated spec file.

Unfortunately, something is off with the 32 bit build. I don't really know what
to do about it. It creates a file for firefox in /usr/lib64 even on the 32 bit
platform.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #3 from Yuri Konotopov  ---
Version 8 with Firefox support released.

See also:
https://wiki.gnome.org/Projects/GnomeShellIntegrationForChrome/ReleaseNotes/8
https://blogs.gnome.org/ne0sight/2016/12/25/how-to-install-gnome-shell-extensions-with-firefox-52/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Jeremy Newton  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|alexjn...@gmail.com



--- Comment #2 from Jeremy Newton  ---
I'm interested in reviewing this. Can you please update it to the latest
(v7.2.1)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Yuri Konotopov  changed:

   What|Removed |Added

 CC||ykonoto...@gmail.com



--- Comment #1 from Yuri Konotopov  ---
Hi Pete,

You missed python-gobject-base dependency. It was recently added in
region51/chrome-gnome-shell copr:
https://copr.fedorainfracloud.org/coprs/region51/chrome-gnome-shell/build/429413/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710

Pete Walter  changed:

   What|Removed |Added

Summary|Review Request:  -|Shell integration for
   ||Chrome



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org