[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #17 from Fedora Update System--- ansible-review-0.9.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #16 from Fedora Update System--- ansible-review-0.9.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #15 from Fedora Update System--- ansible-review-0.9.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-08-24 09:51:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #14 from Fedora Update System--- ansible-review-0.9.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-68c52c3f1c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #13 from Fedora Update System--- ansible-review-0.9.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6c98e4bcb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- ansible-review-0.9.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-24798fcf0b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #11 from Fedora Update System--- ansible-review-0.9.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6c98e4bcb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Fedora Update Systemchanged: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #9 from Fedora Update System--- ansible-review-0.9.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-24798fcf0b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #10 from Fedora Update System--- ansible-review-0.9.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-68c52c3f1c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #8 from Jon Ciesla--- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ansible-review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Igor Gnatenkochanged: What|Removed |Added Status|ASSIGNED|POST --- Comment #7 from Igor Gnatenko --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Parag AN(पराग)changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Parag AN(पराग) --- New update looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #5 from Dan Callaghan--- Thanks for taking this review, Parag. https://fedorapeople.org/~dcallagh/ansible-review/ansible-review.spec https://fedorapeople.org/~dcallagh/ansible-review/ansible-review-0.9.0-1.fc24.src.rpm * Mon Aug 01 2016 Dan Callaghan - 0.9.0-1 - upstream release 0.9.0 - use %%license properly -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #4 from Parag AN(पराग)--- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === 1) If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===> Just move LICENSE file from %doc to new line %license 2) Package Latest version 0.9.0 = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/parag/1348778-ansible-review/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Parag AN(पराग)changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Bug 1348778 depends on bug 1348775, which changed state. Bug 1348775 Summary: Review Request: python-unidiff - Python library to parse and interact with unified diffs https://bugzilla.redhat.com/show_bug.cgi?id=1348775 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 --- Comment #3 from Dan Callaghan--- Updated to upstream 0.7.5, enabled tests, added requirement on ansible-lint >= 3.0 and dropped the patch for backporting to ansible-lint 2.x: https://fedorapeople.org/~dcallagh/ansible-review/ansible-review.spec https://fedorapeople.org/~dcallagh/ansible-review/ansible-review-0.7.5-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Parag AN(पराग)changed: What|Removed |Added CC||panem...@gmail.com --- Comment #2 from Parag AN(पराग) --- ansible-lint-3.0.0 is pushed to f23+ as well as in epel7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Bug 1348778 depends on bug 1348965, which changed state. Bug 1348965 Summary: ansible-lint-3.0.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1348965 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Dan Callaghanchanged: What|Removed |Added Depends On||1348965 --- Comment #1 from Dan Callaghan --- I should probably wait until ansible-lint 3.0 is packaged, and then update this to drop the patch for backporting to ansible-lint 2.x. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1348965 [Bug 1348965] ansible-lint-3.0.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements
https://bugzilla.redhat.com/show_bug.cgi?id=1348778 Dan Callaghanchanged: What|Removed |Added Depends On||1348775 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1348775 [Bug 1348775] Review Request: python-unidiff - Python library to parse and interact with unified diffs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org