[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #22 from Fedora Update System  ---
obconf-qt-0.11.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #21 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #20 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-07 04:24:37



--- Comment #19 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #18 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-907c9f843e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #17 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9542819fdd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #16 from Fedora Update System  ---
obconf-qt-0.11.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d3d78b1f9e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #15 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-327af04953

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #14 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/obconf-qt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #13 from Christian Dersch  ---
Thank you :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Björn "besser82" Esser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 33 files have
 unknown license. Detailed output of licensecheck in
 /home/besser82/shared/fedora/newpkg/1357283-obconf-qt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in obconf-qt
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in obconf-
 qt-debuginfo

 ---> debuginfo is autogenerated by 

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fed...@besser82.io
   Assignee|nob...@fedoraproject.org|fed...@besser82.io
  Flags||fedora-review?



--- Comment #11 from Björn "besser82" Esser  ---
Taken  =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #10 from Mario Blättermann  ---
Regarding the need of a man page, just have a look at the appropriate Debian
package (if available). The Debian folks gently forces packagers to provide man
pages in many cases, especially for pure command line tools. But the obconf-qt
package in Debian doesn't contain a man page, that's why I assume we don't need
to bother with it. Moreover, usually GUI software mostly doesn't have
recognizable command line options, so its not worth the effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #9 from Raphael Groner  ---
(In reply to Christian Dersch from comment #7)
.…
> * I'll request a manpage upstream

Is there any *useful* output to console for options -h or --help? You could use
help2man to generate a manpage from that help output.
Although, obconf-qt is a GUI application in first place and can be expected to
get called in a graphical desktop environment, so no need to provide a manpage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #8 from Christian Dersch  ---
Koji build (rawhide):
http://koji.fedoraproject.org/koji/taskinfo?taskID=14936701

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #7 from Christian Dersch  ---
Thank you very much for your comments :)

* -debuginfo indeed broken, I fixed the cmake configuration to use Fedora
compiler flags (patch obconf-qt-0.9.0-fix-debuginfo.patch)
* The wrong FSF address is already fixed in upstream git:
https://github.com/lxde/obconf-qt/commit/47c1b3f6d156df769d353fe8d766b32b382a240a
* I'll request a manpage upstream

Spec URL: https://lupinix.fedorapeople.org/review/obconf-qt.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/obconf-qt-0.9.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #6 from Mario Blättermann  ---
$ rpmlint -i -v *
obconf-qt.armv7hl: I: checking
obconf-qt.armv7hl: I: checking-url https://github.com/lxde/obconf-qt (timeout
10 seconds)
obconf-qt.armv7hl: E: incorrect-fsf-address
/usr/share/licenses/obconf-qt/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

obconf-qt.armv7hl: W: no-manual-page-for-binary obconf-qt
Each executable in standard binary directories should have a man page.

obconf-qt.i686: I: checking
obconf-qt.i686: I: checking-url https://github.com/lxde/obconf-qt (timeout 10
seconds)
obconf-qt.i686: E: incorrect-fsf-address /usr/share/licenses/obconf-qt/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

obconf-qt.i686: W: no-manual-page-for-binary obconf-qt
Each executable in standard binary directories should have a man page.

obconf-qt.src: I: checking
obconf-qt.src: I: checking-url https://github.com/lxde/obconf-qt (timeout 10
seconds)
obconf-qt.src: I: checking-url
https://github.com/lxde/obconf-qt/archive/0.9.0.tar.gz#/obconf-qt-0.9.0.tar.gz
(timeout 10 seconds)
obconf-qt.x86_64: I: checking
obconf-qt.x86_64: I: checking-url https://github.com/lxde/obconf-qt (timeout 10
seconds)
obconf-qt.x86_64: E: incorrect-fsf-address
/usr/share/licenses/obconf-qt/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

obconf-qt.x86_64: W: no-manual-page-for-binary obconf-qt
Each executable in standard binary directories should have a man page.

obconf-qt-debuginfo.armv7hl: I: checking
obconf-qt-debuginfo.armv7hl: I: checking-url https://github.com/lxde/obconf-qt
(timeout 10 seconds)
obconf-qt-debuginfo.armv7hl: E: debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

obconf-qt-debuginfo.i686: I: checking
obconf-qt-debuginfo.i686: I: checking-url https://github.com/lxde/obconf-qt
(timeout 10 seconds)
obconf-qt-debuginfo.i686: E: debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

obconf-qt-debuginfo.x86_64: I: checking
obconf-qt-debuginfo.x86_64: I: checking-url https://github.com/lxde/obconf-qt
(timeout 10 seconds)
obconf-qt-debuginfo.x86_64: E: debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

7 packages and 0 specfiles checked; 6 errors, 3 warnings.


There are some warnings about incorrect FSF addresses, those needs to be filed
a s an upstream bug. But no blockers for now. Same for the missing man page.

But an empty debuginfo package needs to be taken seriously. I don't know that
much about the special behavior of cmake in this case, but mostly adding
CXXFLAGS="%{optflags}" to the "make" call helps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #5 from Christian Dersch  ---
Before the request is assigned I just replace the files listed in first comment
;) So the links are still valid.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Mario Blättermann  changed:

   What|Removed |Added

 CC||mario.blaetterm...@gmail.co
   ||m



--- Comment #4 from Mario Blättermann  ---
Please provide always new files, even after cosmetic changes. Scratch builds on
Koji get lost after two weeks, and reviewers cannot use fedora-review without
direct download locations.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #3 from Christian Dersch  ---
Another small fix (forgot to own /usr/share/obconf-qt), new Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14930436

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #2 from Christian Dersch  ---
Some small cosmetic fixes done in place, new Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14929459

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
 Blocks||1202425 (LXQt)
 Whiteboard||Trivial



--- Comment #1 from Raphael Groner  ---
Thanks for working on this!


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1202425
[Bug 1202425] LXQt
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Christian Dersch  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)
  Alias||obconf-qt




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org