[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #21 from Fedora Update System  ---
python-fadvise-5.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #20 from Fedora Update System  ---
python-fadvise-5.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #19 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-09 17:49:50 |2016-09-12 08:21:48



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #18 from Fedora Update System  ---
python-fadvise-5.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-30d3474e91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #17 from Fedora Update System  ---
python-fadvise-5.0.0-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-74ea06d61c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #16 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #15 from Fedora Update System  ---
python-fadvise-5.0.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-30d3474e91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #14 from Fedora Update System  ---
python-fadvise-5.0.0-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-74ea06d61c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #13 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-09 17:49:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #12 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6fcbadcf1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #11 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-19e20103d3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d018f640

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #9 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d018f640

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #8 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-19e20103d3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #7 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6fcbadcf1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-fadvise

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
+ package name is OK
+ latest version
+ license is acceptable (BSD)
+ license is specified correctly
+ modern python packaging is used
+ %python_provide macro is used
+ python3 support is not needed
+ P/R/BR look OK
+ builds and install OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #4 from Piotr Popieluch  ---
Thanks for reviewing.

I've switched to github source.

Made %files more specific. 

The pyadvise script got dropped:
https://github.com/lamby/python-fadvise/issues/1

I'm thinking on how to improve the api, I'll also move _fadvise.so. 

Updated spec and srpm for now:
Spec URL: https://piotrp.fedorapeople.org/python-fadvise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-fadvise-4.0.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Why don't you just build from the github tarball? That's simpler than mucking
around with pypi and a separate license file
[https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags].

It isn't strictly required, but it's considered good practice to specify more
specific patterns in %files:
%{python2_sitearch}/%{srcname}/
%{python2_sitearch}/%{srcname}-egg.info...

I would be much much better to not install a private module in the top level
python namespace: /usr/lib/python2.7/site-packages/_fadvise.so should become
/usr/lib/python2.7/site-packages/fadvise/_fadvise.so. Of course this is an
upstream issue, but maybe you could try to work with them to fix this.
Actually patching this is trivial:
1. move the .so file
2. change from _fadvise import ... → from ._fadvise import ...

There is no man page, and pyadvise --help isn't exactly verbose. It would be
nice to extend the description in --help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #2 from Piotr Popieluch  ---
(In reply to Igor Gnatenko from comment #1)
> > %{python2_sitearch}
> don't own directory.

aj.. this should be better
> %{python2_sitearch}/*

spec/srpm updated, same url.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #1 from Igor Gnatenko  ---
> %{python2_sitearch}
don't own directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org