[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-11-14 07:48:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/loopabull

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #8 from Adam Miller  ---
Ah, sure enough. Fixed, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Igor Gnatenko  ---
(In reply to Adam Miller from comment #6)
> +1 to most of the patch, but as is it doesn't build because of the extra
> preprended %{name} from the GitHub archive. I changed just the %autosetup
> line and I added a changelog with credit for the patch (I'll add your email
> or fas account info if you like.
> 
> Spec URL: https://maxamillion.fedorapeople.org/loopabull.spec
> SRPM URL: https://maxamillion.fedorapeople.org/loopabull-0.0.3-3.fc24.src.rpm

Looks like you didn't see change in Source0 line.
If you put there: %{URL}/archive/%{version}/%{name}-%(version}.tar.gz
Then it will not prepend extra name (problem is that you already had old
archive with same filename).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #6 from Adam Miller  ---
+1 to most of the patch, but as is it doesn't build because of the extra
preprended %{name} from the GitHub archive. I changed just the %autosetup line
and I added a changelog with credit for the patch (I'll add your email or fas
account info if you like.

Spec URL: https://maxamillion.fedorapeople.org/loopabull.spec
SRPM URL: https://maxamillion.fedorapeople.org/loopabull-0.0.3-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #5 from Igor Gnatenko  ---
Created attachment 1191708
  --> https://bugzilla.redhat.com/attachment.cgi?id=1191708=edit
proposed patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #4 from Igor Gnatenko  ---
(In reply to Adam Miller from comment #3)
> systemd-units got merged into the systemd package a little while back
> according to the guidelines:
> https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations
Ah, I didn't read that carefully. sorry.
> 
> Thank you for the review! I fixed everything else mentioned and look forward
> to further feedback.
> 
> Spec URL: https://maxamillion.fedorapeople.org/loopabull.spec
> SRPM URL: https://maxamillion.fedorapeople.org/loopabull-0.0.3-2.fc24.src.rpm

> Source0:
> https://github.com/maxamillion/%{name}/archive/%{name}-%{version}.tar.gz
> %autosetup -n %{name}-%{name}-%{version}
-> Source0:%{url}/archive/%{version}/%{name}-%{version}.tar.gz
-> %autosetup
and it will not prepend any name

* actually manpages stuff is still not fixed
* add "-p" flag to `install` to preserver timestamps
* %{_docdir}/%{name}/* is still there

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #3 from Adam Miller  ---
systemd-units got merged into the systemd package a little while back according
to the guidelines:
https://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations

Thank you for the review! I fixed everything else mentioned and look forward to
further feedback.

Spec URL: https://maxamillion.fedorapeople.org/loopabull.spec
SRPM URL: https://maxamillion.fedorapeople.org/loopabull-0.0.3-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #2 from Igor Gnatenko  ---
> %autosetup -n %{name}-%{version}
%autosetup

> %{__python2} setup.py build
%py2_build

> %{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
%py2_install

> %description
> %{summary}
%description
%{summary}.

> gzip man/%{name}.1
> install -d %{buildroot}%{_mandir}/man1
> install -m 644 man/%{name}.1.gz %{buildroot}%{_mandir}/man1/
> %{_mandir}/man1/%{name}.1.gz
install -Dpm0644 man/%{name}.1 %{buildroot}%{_mandir}/man1/%{name}.1
%doc %{_mandir}/man1/%{name}.1*

> # Install examples
> install -d %{buildroot}%{_docdir}/%{name}/
> cp -r examples %{buildroot}%{_docdir}/%{name}/
> %{_docdir}/%{name}/*
%doc examples

> Source0:
> https://pypi.python.org/packages/source/l/%{name}/%{name}-%{version}.tar.gz
is it really necessary to take from PyPI and not from GitHub? Also that link is
broken anyway.

> BuildRequires:  systemd
BuildRequires: systemd-units

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367769] Review Request: loopabull - Event loop driven Ansible playbook execution engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367769



--- Comment #1 from Adam Miller  ---
I have it building in a COPR here:

https://copr.fedorainfracloud.org/coprs/maxamillion/loopabull/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org