subject:"\[Bug 1369213\] Review Request\: python\-django\-netjsongraph \- Reusable django app for collecting and visualizing network topology"

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-16 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-16 14:51:12



--- Comment #47 from Fedora Update System  ---
python-django-netjsongraph-0.2.2-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #46 from Fedora Update System  ---
python-django-netjsongraph-0.2.2-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb59b6f537

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #45 from Fedora Update System  ---
python-django-netjsongraph-0.2.2-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fb59b6f537

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-03 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #44 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-django-netjsongraph

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-03 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #43 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[?]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt
 See previous comments
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-packages,
 /usr/lib/python3.6
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
 packages/tests(python-repoze-who-plugins-sa, python-libturpial,
 python-django-federated-login, python-custodia, python2-modulemd)
[?]: Package contains no bundled libraries without FPC exception.
[?]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #42 from Germano Massullo  ---
(In reply to gil cattaneo from comment #41)
> Please rebuild python-django-model-utils

Done

> > [!]: License field in the package spec file matches the actual license.
> >  Note: Checking patched sources after %prep for licenses. Licenses
> >  found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
> >  unknown license. Detailed output of licensecheck in /home/gil/1369213
> >  -python-django-netjsongraph/licensecheck.txt
> > 
> All source files are without license headers. Please, ask to upstream to
>  confirm the
>   licensing of code and/or content/s and add license headers
>   https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
>  LicensingGuidelines#License_Clarification

The LICENSE file in sources package states what is the licence of the software,
except for javascript-d3 that is BSD (as stated in the spec file).
So we do not need upstream to sign all source files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #41 from gil cattaneo  ---
(In reply to gil cattaneo from comment #40)
> Build fails:
> 
> DEBUG util.py:421:  Last metadata expiration check: 0:01:26 ago on Mon Jan 
> 2 20:20:49 2017.
> DEBUG util.py:421:  Error: nothing provides python(abi) = 3.5 needed by
> python3-django-model-utils-2.5.2-1.fc26.noarch
> DEBUG util.py:421:  (try to add '--allowerasing' to command line to replace
> conflicting packages)
> DEBUG util.py:557:  Child return code was: 1
> DEBUG util.py:180:  kill orphans
> DEBUG util.py:578:  child environment: None
> 
> Any ideas?

Please rebuild python-django-model-utils

> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
>  unknown license. Detailed output of licensecheck in /home/gil/1369213
>  -python-django-netjsongraph/licensecheck.txt
> 
All source files are without license headers. Please, ask to upstream to
 confirm the
  licensing of code and/or content/s and add license headers
  https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
 LicensingGuidelines#License_Clarification

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #40 from gil cattaneo  ---
Build fails:

DEBUG util.py:421:  Last metadata expiration check: 0:01:26 ago on Mon Jan  2
20:20:49 2017.
DEBUG util.py:421:  Error: nothing provides python(abi) = 3.5 needed by
python3-django-model-utils-2.5.2-1.fc26.noarch
DEBUG util.py:421:  (try to add '--allowerasing' to command line to replace
conflicting packages)
DEBUG util.py:557:  Child return code was: 1
DEBUG util.py:180:  kill orphans
DEBUG util.py:578:  child environment: None

Any ideas?

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt

 All source files are without license headers. Please, ask to upstream to
confirm the
 licensing of code and/or content/s and add license headers

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #39 from Germano Massullo  ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph.spec

srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph-0.2.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #38 from gil cattaneo  ---
is available a new release:
https://github.com/interop-dev/django-netjsongraph/releases/tag/0.2.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #37 from gil cattaneo  ---
you should use this format:Provides:   bundled(foo) = "fooversion"
e.g. Provides:   bundled(js-d3) = 3.5.5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2017-01-02 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #36 from Germano Massullo  ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph.spec

srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph-0.2.1-1.fc25.src.rpm

I tested fedora-review and the trivial errors of manage.py are not important
since test have been disabled

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-12-14 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #35 from gil cattaneo  ---
(In reply to Germano Massullo from comment #34)

> Concerning licences:
> - django-netjsongraph has MIT licence;
> - d3 has BSD-3-Clause licence.
> I have to ask into devel mailing list how to correctly mention both licences
> in the spec file
Just so (e.g.):
# BSD-3-Clause licence: ./django_netjsongraph/static/netjsongraph/lib/d3.min.js
License:MIT and BSD

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-12-14 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #34 from Germano Massullo  ---
Upstream also updated the README adding explicit reference to the bundled
library
https://github.com/interop-dev/django-netjsongraph/commit/e975da068bfe95cf09eb08820120cb6a3c971720

Concerning licences:
- django-netjsongraph has MIT licence;
- d3 has BSD-3-Clause licence.
I have to ask into devel mailing list how to correctly mention both licences in
the spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-12-14 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #33 from Germano Massullo  ---
After huge discussion with various Fedora senior developers, I take the
decision to not remove the javascript-d3 library and to declare it into the
spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-12-14 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Germano Massullo  changed:

   What|Removed |Added

 Whiteboard|>= F24 && >= EPEL7 ; TO DO: |>= F24 && >= EPEL7
   |unbundle javascript-d3  |
   |library |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-21 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Germano Massullo  changed:

   What|Removed |Added

 Whiteboard|>= F24 && >= EPEL7  |>= F24 && >= EPEL7 ; TO DO:
   ||unbundle javascript-d3
   ||library



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #32 from gil cattaneo  ---
Issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt


./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js
 https://github.com/d3/d3 under BSD 3-Clause License.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
 https://github.com/interop-dev/netjsongraph.js under BSD 3-Clause License.
 All source files are without license headers. Please, ask to upstream to
 confirm the licensing of code and/or content/s. and add  license headers
 licensing of code and/or content/s

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[!]: Package contains no bundled libraries without FPC exception.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
  Please, add: Provides:   bundled(js-netjsongraph) = 0.1
   Provides:   bundled(js-d3) = 3.5.5
  in each Python packages.


python2-django-netjsongraph.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/tests/manage.py /usr/bin/env python
python2-django-netjsongraph.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tests/manage.py 644 /usr/bin/env python
python3-django-netjsongraph.noarch: E: wrong-script-interpreter
/usr/lib/python3.5/site-packages/tests/manage.py /usr/bin/env python
python3-django-netjsongraph.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/tests/manage.py 644 /usr/bin/env python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #31 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt


./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js
 https://github.com/d3/d3 under BSD 3-Clause License.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
 https://github.com/interop-dev/netjsongraph.js under BSD 3-Clause License.
 All source files are without license headers. Please, ask to upstream to
confirm the
 licensing of code and/or content/s

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
 packages/tests(python3-repoze-who-plugins-sa, python3-custodia,
 python3-journal-brief, python3-django-federated-login,
 python3-oauth2), /usr/lib/python3.5/site-
 packages/tests/__pycache__(python3-repoze-who-plugins-sa,
 python3-custodia, python3-oauth2, python3-django-federated-login),
 /usr/lib/python2.7/site-packages/tests(python-repoze-who-plugins-sa,
 python-libturpial, python-django-federated-login, python-custodia)

[!]: Package contains no bundled libraries without FPC exception.

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/lib/d3.min.js

./django-netjsongraph-0.2.1/django_netjsongraph/static/netjsongraph/src/netjsongraph.js
  Please, add: Provides:   bundled(js-netjsongraph) = 0.1
   Provides:   bundled(js-d3) = 3.5.5
  in each Python packages.

[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #30 from Germano Massullo  ---
(In reply to gil cattaneo from comment #29)
> So is only a question of branch and not of interpreter. you should change
> the if in corrispondint of the pytho3 package as i wrote  in comment#7

First of all, let's start speaking about line numbers
if you mean that line number 57
%if 0%{?with_python3}
should be replaced with
%if 0%{?el7}
that is a nonsense

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #29 from gil cattaneo  ---
(In reply to Germano Massullo from comment #28)
> (In reply to gil cattaneo from comment #27)
> > (In reply to Germano Massullo from comment #26)
> > > gil, lastest files version is at
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22
> > 
> > for Fedora python3 should be the default interpreter the reason are
> > summarized in https://bugzilla.redhat.com/show_bug.cgi?id=1346243#c6.
> > I would not have done better ...
> 
> wrong
> 
> Message URL
> https://lists.fedoraproject.org/archives/list/python-devel@lists.
> fedoraproject.org/message/SXVBA55NHTX2XVPVNGFVWJUNIR2Z3WDX/
> 
> ==
> BY Miro Hrončok, core member of Python-SIG
> This package shall (on Fedora) produce two subpackages:
> python2-django-netjsongraph and python3-django-netjsongraph. See an example
> spec here: 
> http://python-rpm-porting.readthedocs.io/en/latest/modules.html#ported-rpm-
> spec-file
> ==

So is only a question of branch and not of interpreter. you should change the
if in corrispondint of the pytho3 package as i wrote  in comment#7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #28 from Germano Massullo  ---
(In reply to gil cattaneo from comment #27)
> (In reply to Germano Massullo from comment #26)
> > gil, lastest files version is at
> > https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22
> 
> for Fedora python3 should be the default interpreter the reason are
> summarized in https://bugzilla.redhat.com/show_bug.cgi?id=1346243#c6.
> I would not have done better ...

wrong

Message URL
https://lists.fedoraproject.org/archives/list/python-de...@lists.fedoraproject.org/message/SXVBA55NHTX2XVPVNGFVWJUNIR2Z3WDX/

==
BY Miro Hrončok, core member of Python-SIG
This package shall (on Fedora) produce two subpackages:
python2-django-netjsongraph and python3-django-netjsongraph. See an example
spec here: 
http://python-rpm-porting.readthedocs.io/en/latest/modules.html#ported-rpm-spec-file
==

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

gil cattaneo  changed:

   What|Removed |Added

  Flags|needinfo?(puntogil@libero.i |
   |t)  |



--- Comment #27 from gil cattaneo  ---
(In reply to Germano Massullo from comment #26)
> gil, lastest files version is at
> https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22

for Fedora python3 should be the default interpreter the reason are summarized
in https://bugzilla.redhat.com/show_bug.cgi?id=1346243#c6.
I would not have done better ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #26 from Germano Massullo  ---
gil, lastest files version is at
https://bugzilla.redhat.com/show_bug.cgi?id=1369213#c22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-19 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Germano Massullo  changed:

   What|Removed |Added

  Flags||needinfo?(puntogil@libero.i
   ||t)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213
Bug 1369213 depends on bug 1365782, which changed state.

Bug 1365782 Summary: python-django-model-utils - Django model mixins and 
utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1365782

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #25 from Igor Gnatenko  ---
(In reply to Germano Massullo from comment #24)
> (In reply to Igor Gnatenko from comment #23)
> > > Requires:   python3-django >= 1.9, python3-django < 1.10
> > such things will never work.
> > 
> > It will pull all possible packages within this range.
> 
> How would you handle it?
It's not possible.

Based on that django in F24 GA was 1.9, you can just put Requires:
python3-django

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #24 from Germano Massullo  ---
(In reply to Igor Gnatenko from comment #23)
> > Requires:   python3-django >= 1.9, python3-django < 1.10
> such things will never work.
> 
> It will pull all possible packages within this range.

How would you handle it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #23 from Igor Gnatenko  ---
> Requires:   python3-django >= 1.9, python3-django < 1.10
such things will never work.

It will pull all possible packages within this range.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #22 from Germano Massullo  ---
Files updated

spec file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph-0.2.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #21 from Kevin Kofler  ---
The file list is wrong, you are listing both the Python 2 and 3 files for the
main package. You should instead list the Python 2 files for the python2-*
package and the Python 3 files for the python3-* package. (Use "%files -n
packagename".)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #20 from Germano Massullo  ---
check now

spec file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph-0.2.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #19 from Fabio Alessandro Locati  ---
Also, python3 package does not exists, since it does not have a declaration,
nor a description nor file associated, just dependencies

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #18 from gil cattaneo  ---
hi
the spec file have the same issue reported in the Comment#14
please. fix it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #17 from Germano Massullo  ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-django-netjsongraph/python-django-netjsongraph-0.2.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-13 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #16 from Germano Massullo  ---
2) enabled Python2 and Python3 builds

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-12 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Germano Massullo  changed:

   What|Removed |Added

  Flags|needinfo?(germano.massullo@ |
   |gmail.com)  |



--- Comment #15 from Germano Massullo  ---
1) I am working on it
2) Please refer to discussion
https://lists.fedoraproject.org/archives/list/python-de...@lists.fedoraproject.org/thread/GJKSTHCLSLKWLSFICHKI6YSLKWSYUMM2/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] Review Request: python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

2016-09-12 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

Igor Gnatenko  changed:

   What|Removed |Added

Summary|python-django-netjsongraph  |Review Request:
   |- Reusable django app for   |python-django-netjsongraph
   |collecting and visualizing  |- Reusable django app for
   |network topology|collecting and visualizing
   ||network topology



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

39 matches

Mail list logo