[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #15 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-05 13:52:59



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #14 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #13 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d2daee767e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5827571429

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #11 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d2daee767e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #10 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5827571429

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
gap-pkg-automata-1.13-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5827571429

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #8 from Fedora Update System  ---
gap-pkg-automata-1.13-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d2daee767e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #7 from Fedora Update System  ---
gap-pkg-automata-1.13-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5827571429

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-automata

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #5 from Jerry James  ---
(In reply to gil cattaneo from comment #4)
> Please, fix these hints before import
> 
> gap-pkg-automata.noarch: W: file-not-utf8
> /usr/lib/gap/pkg/automata/doc/gapdoc.dtd
> gap-pkg-automata.noarch: W: file-not-utf8
> /usr/lib/gap/pkg/automata/doc/gapdoc.css

Hmm, I think those two files should not be packaged at all.  I will remove
them.

> gap-pkg-automata.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/gap-pkg-automata/README

Fixed.

> Approved

Thank you very much for the review!  Again! :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #4 from gil cattaneo  ---
Please, fix these hints before import

gap-pkg-automata.noarch: W: file-not-utf8
/usr/lib/gap/pkg/automata/doc/gapdoc.dtd
gap-pkg-automata.noarch: W: file-not-utf8
/usr/lib/gap/pkg/automata/doc/gapdoc.css
gap-pkg-automata.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/gap-pkg-automata/README

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #3 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 18 files have
 unknown license. Detailed output of licensecheck in /home/gil/1370874
 -gap-pkg-automata/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[!]: Rpmlint 

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #2 from Jerry James  ---
Hi gil.  Sure, I'll take one of those.  I probably won't have time to review it
for a day or two, though.  I'll start as soon as I can.  Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
hi Jerry
have time for this https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1370868 
or this https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=1370913 ?
i take this in return
thanks in advance

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org