[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892
Bug 1372892 depends on bug 1372890, which changed state.

Bug 1372890 Summary: Provide python3-backports subpkg
https://bugzilla.redhat.com/show_bug.cgi?id=1372890

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |EOL



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SIC7VZX4DCCASQRDPRGG7K57SMID6GUK/

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

William Moreno  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-10-23 22:24:09



--- Comment #7 from William Moreno  ---
https://koji.fedoraproject.org/koji/taskinfo?taskID=22658142

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Terje Røsten  changed:

   What|Removed |Added

 Blocks||1451066




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1451066
[Bug 1451066] Review Request:  python-cli-helpers - Python helpers for
common CLI tasks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #6 from Elliott Sales de Andrade  ---
Are you going to import this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-csv

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from William Moreno  ---
Thanks for the feedback!

If so, I am fine with this packaging, setting the fedora-review to "+", this
package have been aproved.

Upstream issue:

 - https://github.com/ryanhiebert/backports.csv/issues/18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #3 from Tom "spot" Callaway  ---
Yes, but please do ask upstream to include a copy of the license text. Lifting
FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

William Moreno  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)



--- Comment #2 from William Moreno  ---
This package have python licence but do not include a license, can be go ahead
to aprove this package?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892



--- Comment #1 from William Moreno  ---
Package Review
==

Packaging looks good but please ask upstream to provide a license text.
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: License file installed when any subpackage combination is installed.


This should be fixed by: https://bugzilla.redhat.com/show_bug.cgi?id=1372890
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.5/site-
 packages/backports, /usr/lib/python3.5/site-
 packages/backports/__pycache__

= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. 
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
---
Checking: python2-backports-csv-1.0.1-1.fc26.noarch.rpm
  python3-backports-csv-1.0.1-1.fc26.noarch.rpm
  python-backports-csv-1.0.1-1.fc26.src.rpm
python2-backports-csv.noarch: W: spelling-error Summary(en_US) Backport -> Back
port, Back-port, Backpacker
python2-backports-csv.noarch: W: spelling-error %description -l en_US Backport
-> Back port, Back-port, Backpacker

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1372893 (python-parquet)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372893
[Bug 1372893] Review Request: python-parquet - Python implementation of the
Parquet file format
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1372890
  Alias||python-backports-csv




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372890
[Bug 1372890] Provide python3-backports subpkg
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org