[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Matthias Runge  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(mru...@redhat.com |
   |)   |
Last Closed|2016-10-14 08:35:20 |2016-10-14 08:50:33



--- Comment #9 from Matthias Runge  ---
Yes, I missed that completely. Sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

   Keywords|Reopened|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

 Status|CLOSED  |POST
 Resolution|NOTABUG |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NOTABUG
  Flags||needinfo?(mru...@redhat.com
   ||)
Last Closed||2016-10-14 08:35:20



--- Comment #8 from Sandro Bonazzola  ---
So, close wontfix?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Sandro Bonazzola  changed:

   What|Removed |Added

 CC||a15...@gmail.com



--- Comment #7 from Sandro Bonazzola  ---
*** Bug 1384583 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003



--- Comment #6 from Yanis Guenane  ---
@Vit: Done. Sorry for the mistake and thanks for spotting it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #5 from Vít Ondruch  ---
Guys, what is the reason to introduce such library into Fedora? Presumably,
this presumably, this code is already built-in in Ruby 2.3. Please consider to
retire this package immediately.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-string-scrub

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Matthias Runge  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Matthias Runge  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Pure Ruby package must be built as noarch
- Package contains Requires: ruby(release).


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 7 files have unknown license. Detailed
 output of licensecheck in /home/fedora/1373003-rubygem-string-
 scrub/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003



--- Comment #2 from Yanis Guenane  ---
SPEC URL:
https://gist.githubusercontent.com/Spredzy/1475711fe822de7716b96ba3fbb6a666/raw/59d497b68c0e83614ff82ae0bf833d5d62d01ef3/rubygem-string-scrub.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/4384/15504384/rubygem-string-scrub-0.0.5-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373003] Review Request: rubygem-string-scrub - String#scrub for Ruby 2.0.0 and 1.9.3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373003

Matthias Runge  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mru...@redhat.com
   Assignee|nob...@fedoraproject.org|mru...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Matthias Runge  ---
will take the review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org