[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376783



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
> All of the above is a matter of opinion and hence the choice of the 
> maintainer.

Sure, this was just a suggestion. I do think it makes life easier (certainly
for
a reviewer, but I think also for the maintainer).

The license is specified incorrectly: it's LGPLv3+ according to the LICENSE
file.

rpmlint:
python2-can.noarch: E: script-without-shebang /usr/bin/j1939_logger.py
python2-can.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/can/util.py /usr/bin/env python3
python2-can.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/can/util.py 644 /usr/bin/env python3
python2-can.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/can/broadcastmanager.py /usr/bin/env python3
python2-can.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/can/broadcastmanager.py 644 /usr/bin/env
python3

At least the first should be fixed.

Requires

python2-can (rpmlib, GLIBC filtered):
/usr/bin/python3 <--- this looks wrong
python(abi)

Provides

python3-can:
python-can < this looks wrong
python3-can
python3.5dist(python-can)
python3dist(python-can)

Oh, it's a typo in python_provide for the py3 subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376783



--- Comment #3 from Peter Robinson  ---
SPEC: as above
SRPM: https://pbrobinson.fedorapeople.org/python-can-1.5.2-2.fc25.src.rpm

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=16708332

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376783



--- Comment #2 from Peter Robinson  ---

> You can replace the second and subsequent Summary texts with %{summary}, no
> need to repeat.
> 
> 
> Also, don't repeat the %description, it makes the spec file much harder to
> read than necessary:
> 
> %global _description \
> XXX \
> YYY
> 
> %description -n package-name %{_description}
> 
> etc.
> 
> In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
> Something like
> %{python2_sitelib}/libname
> %{python2_sitelib}/libname-%{version}.egg-info

All of the above is a matter of opinion and hence the choice of the maintainer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376783

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
The packaging tempalte from
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file should
be used. It's much better to use %pyX_build, etc.

The description should be wrapped to <= 80 columns, this is even visible in the
way that bugzilla formats the description above.

Is python fully supported? Than the executables should use python3 not python2.


You can replace the second and subsequent Summary texts with %{summary}, no
need to repeat.


Also, don't repeat the %description, it makes the spec file much harder to read
than necessary:

%global _description \
XXX \
YYY

%description -n package-name %{_description}

etc.

In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
Something like
%{python2_sitelib}/libname
%{python2_sitelib}/libname-%{version}.egg-info

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org