[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #11 from Fedora Update System  ---
python3-jinja2-2.8-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-21 09:48:14



--- Comment #10 from Fedora Update System  ---
python3-jinja2-2.8-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #9 from Fedora Update System  ---
python3-jinja2-2.8-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-45c1c0b276

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python3-jinja2-2.8-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d4293aff8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #7 from Fedora Update System  ---
python3-jinja2-2.8-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d4293aff8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #6 from Fedora Update System  ---
python3-jinja2-2.8-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-45c1c0b276

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-jinja2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Tim Orling  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tim Orling  ---
Koji EPEL7 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16727251

Koji EL6 build (fails, but not required):
http://koji.fedoraproject.org/koji/taskinfo?taskID=16727311
(needs python2-markupsafe in EL6)

All review requests addressed:
  [x] separate docs package
  [x] %make_build instead of make addresses parallel make warning

Bonus:
  [x] tests run in %check

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #3 from Orion Poplawski  ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-jinja2.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-jinja2-2.8-2.el7.src.rpm

* Tue Nov 29 2016 Orion Poplawski  - 2.8-2
- Use github tarball and run tests
- Split documentation in sub-package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934
Bug 1376934 depends on bug 1376932, which changed state.

Bug 1376932 Summary: Review Request: python3-markupsafe - Implements a 
XML/HTML/XHTML Markup safe string for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1376932

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #2 from Tim Orling  ---
Koji EPEL7 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16643818

Koji EL6 build (fail, but not required):
http://koji.fedoraproject.org/koji/taskinfo?taskID=16643910


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => OK: uses python%{python3_pkgversion}-devel is used and this is EPEL only.

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1146880 bytes in 87 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
  [!] should be split out to doc sub-package

- Should use or document reason not to use:
  [!]: Uses parallel make %{?_smp_mflags} macro.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 44 files have unknown license. Detailed
 output of licensecheck in
 /home/parallels/1376934-python3-jinja2/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
 => OK: no default owner of /usr/share/licenses in EPEL
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec 

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ticot...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Tim Orling  changed:

   What|Removed |Added

 CC||ticot...@gmail.com



--- Comment #1 from Tim Orling  ---
I am also willing to consider adding to EPEL6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Orion Poplawski  changed:

   What|Removed |Added

 Depends On||1376932




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376932
[Bug 1376932] Review Request: python3-markupsafe - Implements a
XML/HTML/XHTML Markup safe string for Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org