[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

Luya Tshimbalanga  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-09-28 17:10:48



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #13 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/f25-backgrounds

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #12 from Luya Tshimbalanga  ---
SCM request
F25: https://admin.fedoraproject.org/pkgdb/package/requests/7934
Master: https://admin.fedoraproject.org/pkgdb/package/requests/7935

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #11 from Luya Tshimbalanga  ---
Thank you, Gil!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from gil cattaneo  ---
(In reply to Luya Tshimbalanga from comment #9)
> (In reply to gil cattaneo from comment #7)
> > desktop-file-validate
> > ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.
> > noarch.rpm/usr/share/wallpapers/F25/metadata.desktop
> > /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.
> > fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop:
> > 
> > error: required key "Type" in group "Desktop Entry" is not present
> > 
> > Is usual for this kind of desktop file?
> 
> It is specific to KDE.

Ok, fix changelog entry/ies before import
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #9 from Luya Tshimbalanga  ---
(In reply to gil cattaneo from comment #7)
> desktop-file-validate
> ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.
> noarch.rpm/usr/share/wallpapers/F25/metadata.desktop
> /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.
> fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop:
> 
> error: required key "Type" in group "Desktop Entry" is not present
> 
> Is usual for this kind of desktop file?

It is specific to KDE.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #8 from Luya Tshimbalanga  ---
(In reply to gil cattaneo from comment #4)
> have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290339 ?

Taken.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #7 from gil cattaneo  ---
desktop-file-validate
~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop
/home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop:

error: required key "Type" in group "Desktop Entry" is not present

Is usual for this kind of desktop file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #6 from gil cattaneo  ---
Issues:
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

NON blocking issues:
f25-backgrounds.noarch: W: incoherent-version-in-changelog 24.0.0-1
['25.0.0-1.fc26', '25.0.0-1']

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 4 files have unknown license. Detailed
 output of licensecheck in
 /home/gil/1378971-f25-backgrounds/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/xfce4/backdrops
[?]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gnome-background-
 properties, /usr/share/mate-background-properties,
 /usr/share/xfce4/backdrops
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f25
 -backgrounds-base , f25-backgrounds-kde , f25-backgrounds-gnome , f25
 -backgrounds-mate , f25-backgrounds-xfce
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into 

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #4 from gil cattaneo  ---
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290339 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #3 from Luya Tshimbalanga  ---
(In reply to stan from comment #2)
> I don't know if it helps, but I saw your message asking for review and
> decided to try these packages.  I am not a reviewer, but I am running f25. 
> I was able to build the rpms locally from the src.rpm above, and install
> them successfully.  For what it is worth.

Good to hear.
If you are interested, please read the document about the reviewer guideline:
https://fedoraproject.org/wiki/Package_Review_Process#Reviewer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

stan  changed:

   What|Removed |Added

 CC||gr...@q.com



--- Comment #2 from stan  ---
I don't know if it helps, but I saw your message asking for review and decided
to try these packages.  I am not a reviewer, but I am running f25.  I was able
to build the rpms locally from the src.rpm above, and install them
successfully.  For what it is worth.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971



--- Comment #1 from Luya Tshimbalanga  ---
Scratch build result:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15770685

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org