[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-02 20:08:19



--- Comment #10 from Mukundan Ragavan  ---
built on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-QtAwesome

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #8 from Mukundan Ragavan  ---
Many thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #7 from Mukundan Ragavan  ---
Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-4.fc24.src.rpm

- added license tag, doc and provides.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #6 from gil cattaneo  ---
Maybe you could add %doc README.md for each pythonX sub packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 12 files have
 unknown license. Detailed output of licensecheck in /home/gil/1379092
 -python-QtAwesome/licensecheck.txt

  License:MIT and OFL

License: OFL.
./qtawesome/fonts/fontawesome-webfont.ttf
./qtawesome/fonts/elusiveicons-webfont.ttf

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
# License: OFL.
#./qtawesome/fonts/fontawesome-webfont.ttf
Provides:  bundled(elusiveicons-fonts) = 001.000
#./qtawesome/fonts/elusiveicons-webfont.ttf
Provides:  bundled(fontawesome-fonts) = 4.4.1
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned 

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #4 from Mukundan Ragavan  ---
Fixed.

Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #3 from gil cattaneo  ---
Please, use
https://github.com/spyder-ide/qtawesome/archive/v0.3.3/qtawesome-0.3.3.tar.gz
Otherwise you should use the approach shown here:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #2 from Mukundan Ragavan  ---
Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-2.fc24.src.rpm


This should address all the issues (as far as I can tell).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
hi
Source1:MIT_license.txt is useless ...?
git source archive should be contains license file
https://github.com/spyder-ide/qtawesome/archive/v0.3.3/qtawesome-0.3.3.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org