[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 Bug 1379096 depends on bug 1379095, which changed state. Bug 1379095 Summary: Review Request: python-entrypoints - Discover and load entry points from installed packages https://bugzilla.redhat.com/show_bug.cgi?id=1379095 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 Mukundan Ragavanchanged: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-10-03 20:12:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 --- Comment #5 from Jon Ciesla--- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-nbconvert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 --- Comment #4 from Mukundan Ragavan--- Thank you very much for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 gil cattaneochanged: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 --- Comment #3 from Mukundan Ragavan--- 1/ Fixed license 2/ Fixed rpmlint messages 3/ bundling - bootstrap is not bundled here. No other library is bundled with nbconvert. The css file included is based on this - https://github.com/necolas/normalize.css/blob/master/normalize.css and greatly extended. Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-nbconvert/python-nbconvert.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-nbconvert/python-nbconvert-4.2.0-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 --- Comment #2 from gil cattaneo--- Issues: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 168 files have unknown license. Detailed output of licensecheck in /home/gil/1379096 -python-nbconvert/licensecheck.txt License:BSD and MIT nbconvert-4.2.0/nbconvert/resources/style.min.css MIT [?]: Package contains no bundled libraries without FPC exception. https://github.com/twbs/bootstrap/ nbconvert-4.2.0/nbconvert/resources/style.min.css python2-nbconvert.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/nbconvert/nbconvertapp.py /usr/bin/env python python2-nbconvert.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/nbconvert/nbconvertapp.py 644 /usr/bin/env python python3-nbconvert.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/nbconvert/nbconvertapp.py /usr/bin/env python python3-nbconvert.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/nbconvert/nbconvertapp.py 644 /usr/bin/env python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 gil cattaneochanged: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from gil cattaneo --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 168 files have unknown license. Detailed output of licensecheck in /home/gil/1379096 -python-nbconvert/licensecheck.txt License:BSD and MIT nbconvert-4.2.0/nbconvert/resources/style.min.css MIT [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python2.7/site-packages/nbconvert, /usr/lib/python3.5/site-packages/nbconvert [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python2.7/site- packages/nbconvert, /usr/lib/python3.5/site-packages/nbconvert [?]: Package contains no bundled libraries without FPC exception. https://github.com/twbs/bootstrap/ nbconvert-4.2.0/nbconvert/resources/style.min.css [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release}
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 gil cattaneochanged: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 Mukundan Ragavanchanged: What|Removed |Added Blocks||1327979 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1327979 [Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 Mukundan Ragavanchanged: What|Removed |Added Depends On||1379095 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1379095 [Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org