[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #15 from Fedora Update System  ---
python-docker-pycreds-0.2.1-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-18 07:31:56



--- Comment #14 from Fedora Update System  ---
python-docker-pycreds-0.2.1-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #13 from Fedora Update System  ---
python-docker-pycreds-0.2.1-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4c91eeb23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #12 from Fedora Update System  ---
python-docker-pycreds-0.2.1-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a3a8e9dd8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-docker-pycreds

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #10 from Parag AN(पराग)  ---
I am happy to help here :)

BTW, you used bcond so I just thought lets check and python3 bcond need some
changes in spec.
e.g. rpmbuild -ba python-docker-pycreds.spec --without python
failing because conditional not used for py3_build and py3_install lines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #9 from Tomas Tomecek  ---
Thanks a lot Michael! SCM request initiated:
https://admin.fedoraproject.org/pkgdb/package/requests/8140

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

   Assignee|er...@ioerror.us|ttome...@redhat.com
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Michael Hampton  ---
All right, the Requires look right and everything else does as well. That
covers everything I could find. If something else comes up later, it should be
easy enough to update it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

  Flags|needinfo?(ttomecek@redhat.c |
   |om) |



--- Comment #7 from Tomas Tomecek  ---
Oh my, I feel really bad now. The new spec format is pretty confusing. I really
hope I got it right this time, thank you so much Michael and Parag.

(on top of the missing requirement, there was also a typo in provides macro)

Spec:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec
Srpm:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

  Flags||needinfo?(ttomecek@redhat.c
   ||om)



--- Comment #6 from Michael Hampton  ---
All right, thank you to Parag An who drew my attention to the need to pay
attention to the Python-specific guidelines more closely. I think this package
is almost ready. I was only able to find one issue, but it's a pretty serious
one.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= Issues ===

- This program requires the python six module, but neither subpackage
  Requires: it.
  %package -n python2-%{pypi_name}
  Does not contain Requires: python-six
  %package -n python3-%{pypi_name}
  Does not contain Requires: python3-six



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable. 
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
   

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

  Flags|needinfo?(ttomecek@redhat.c |
   |om) |



--- Comment #5 from Tomas Tomecek  ---
(I'm back from vacation)

I used pyp2rpm to generate the spec and expected it would conform to the
guidelines. I rewrote it then.

Spec:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec
Srpm:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #4 from Parag AN(पराग)  ---
Hi Tomas,
   1) Can you use the current recommended way of writing python specs? See we
are now using %py2_build, %py2_install macros. See
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

  2) Source0: can be used as
Source0:   
https://files.pythonhosted.org/packages/source/d/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

  Flags||needinfo?(ttomecek@redhat.c
   ||om)



--- Comment #3 from Michael Hampton  ---
OK, the LICENSE looks right now, but the Requires: python3-six is still
missing. Instead, where I expected to see it, I found BuildRequires: python-six

 %if %{?with_python3}
 BuildRequires:  python3-devel
-BuildRequires:  python-six
+Requires:   python3-six
 BuildRequires:  python3-pytest
 %endif # if with_python3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

  Flags|needinfo?(ttomecek@redhat.c |
   |om) |



--- Comment #2 from Tomas Tomecek  ---
Michael, thanks for the review well done. I wonder how my fedora-review (and
myself) missed those.

Updated:

https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

 CC||ttome...@redhat.com
  Flags||needinfo?(ttomecek@redhat.c
   ||om)



--- Comment #1 from Michael Hampton  ---
Just a couple of easy-to-fix issues, which are at the top:


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- python3-docker-pycreds requires python3-six, not listed in Requires:


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
 Note: License file LICENSE is not marked as %license
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
 python3-docker-pycreds requires python3-six, not listed in Requires:
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
 Note: Tests require a package which is not yet in Fedora.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package 

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|er...@ioerror.us



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||er...@ioerror.us
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

 Blocks||1373386




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1373386
[Bug 1373386] support docker-py 1.10: will have new unpackaged dependency:
docker's credentials store
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org