[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #18 from Fedora Update System  ---
dolphin-emu-5.0-7.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 00:23:09



--- Comment #17 from Fedora Update System  ---
dolphin-emu-5.0-7.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #16 from Fedora Update System  ---
dolphin-emu-5.0-7.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-54c2c61f57

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
dolphin-emu-5.0-7.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-445d5858db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #14 from Fedora Update System  ---
dolphin-emu-5.0-7.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-54c2c61f57

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #13 from Fedora Update System  ---
dolphin-emu-5.0-7.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-445d5858db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #12 from Fedora Update System  ---
dolphin-emu-5.0-6.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d1c2315e97

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
dolphin-emu-5.0-6.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-acb06a4eb7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #10 from Fedora Update System  ---
dolphin-emu-5.0-6.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d1c2315e97

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #9 from Fedora Update System  ---
dolphin-emu-5.0-6.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-acb06a4eb7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/dolphin-emu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #7 from Jeremy Newton  ---
(In reply to MartinKG from comment #6)
> please don't forget to mark the file font-licenses.txt as %license in the
> final package.
> 
> Package APPROVED
> 
> Issues:
> ===
> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file font-licenses.txt is not marked as %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

Thanks! I'll make sure I include that before importing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

MartinKG  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from MartinKG  ---
please don't forget to mark the file font-licenses.txt as %license in the final
package.

Package APPROVED

Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file font-licenses.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #5 from Jeremy Newton  ---
I've added the data subpackage, but decided against the data-gui package, as
the desktop file should be with the binary and the gui specific files in
%{_datadir}/%{name} are small (< 250 KB).

Let me know if you see any other issues:

Spec URL: https://dl.dropboxusercontent.com/u/42480493/dolphin-emu.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/dolphin-emu-5.0-6.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #4 from Jeremy Newton  ---
(In reply to MartinKG from comment #3)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file font-licenses.txt is not marked as %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
> 
> ==>> please include the file font-licenses.txt in %license
> %license license.txt Data/Sys/GC/font-licenses.txt
> 
> please move the following lines for better readability below %install
> 
> %post
> ...
> 
> %postun
> ...
> 
> %posttrans
> 
> 
> = MUST items =
> 
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> 
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "WTFPL WTFPL (v2)", "GPL (v2 or later)", "Unknown or
>  generated", "MIT/X11 (BSD like)", "zlib/libpng", "GPL (v2 or later)
>  (with incorrect FSF address)", "GPL (v2) (with incorrect FSF
>  address)", "BSD (3 clause)", "BSD (2 clause)". 3191 files have unknown
>  license. Detailed output of licensecheck in
>  /home/martin/rpmbuild/SPECS/dolphin-emu/licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [!]: If the package is under multiple licenses, the licensing breakdown
>  must be documented in the spec.
> ==>> Please do so. That's MUST.
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Multiple_Licensing_Scenarios

Sounds good, I've updated the SPEC. I'm not sure what's picking up the WTFPL as
I'm pretty confident there's no WTFPL licensed code in there: likely a false
positive. As well, it seems the public domain code was removed in 5.0, while
some zlib and MIT was added.

Updated SPEC (no rel bump, i'll do this after fixing the noarch subpackages):
https://dl.dropboxusercontent.com/u/42480493/dolphin-emu.spec

> = EXTRA items =
> 
> Generic:
> [!]: Large data in /usr/share should live in a noarch subpackage if package
>  is arched.
>  Note: Arch-ed rpms have a total of 6133760 bytes in /usr/share
> ==>> Please split package into e.q. a data subpackage.
> 

I'll look into this when I get home tonight. In hindsight, I'm pretty sure
there should be a data subpackage and a data-gui subpackage, as nogui probably
needs some of the files from %{_datadir}/%{name}. I'll also throw the icon and
desktop files into data-gui too for good measure.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #3 from MartinKG  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file font-licenses.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

==>> please include the file font-licenses.txt in %license
%license license.txt Data/Sys/GC/font-licenses.txt

please move the following lines for better readability below %install

%post
...

%postun
...

%posttrans


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "WTFPL WTFPL (v2)", "GPL (v2 or later)", "Unknown or
 generated", "MIT/X11 (BSD like)", "zlib/libpng", "GPL (v2 or later)
 (with incorrect FSF address)", "GPL (v2) (with incorrect FSF
 address)", "BSD (3 clause)", "BSD (2 clause)". 3191 files have unknown
 license. Detailed output of licensecheck in
 /home/martin/rpmbuild/SPECS/dolphin-emu/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
==>> Please do so. That's MUST.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in dolphin-emu
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

MartinKG  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

MartinKG  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mgans...@alice.de
   Assignee|nob...@fedoraproject.org|mgans...@alice.de



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #2 from Jeremy Newton  ---
Some updates:
-Fixed f26+ build (sed patch, upstream pull request included)
-Removed curl patch as it's not unnecessary (also fixed 7.50 typo)
-Clean up spec using macros
-Make use of %license macro

Spec URL: https://dl.dropboxusercontent.com/u/42480493/dolphin-emu.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/dolphin-emu-5.0-5.fc25.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16767110

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Jeremy Newton  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #1 from Jeremy Newton  ---
I believe that dolphin-emu meets these qualifications
https://fedoraproject.org/wiki/Licensing:SoftwareTypes#Emulators

Tom's post in regard to this matter:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/OCIB2WAZ6DF3HJZV2OWYOTNRTUZZ6VRX/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org