[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Germano Massullo  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|fedora-review?  |fedora-review-
Last Closed||2016-10-29 06:56:19



--- Comment #9 from Germano Massullo  ---
After asking in EPEL development mailing list I decided to insert darktable 2.x
into darktable EPEL7 branch[1], because:
- 1.x is no longer upstream maintained;
- there are no API/ABI that can be broken;
- it is a desktop application.


Oliver, thank you for your time. I will take care of your suggestions in main
darktable tree [1].


[1]: https://admin.fedoraproject.org/pkgdb/package/rpms/darktable/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #8 from Oliver Haessler  ---
(In reply to Germano Massullo from comment #4)
> https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/
> darktable2.spec
> https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/
> darktable2-2.0.5-1.fc24.src.rpm
> 
> (In reply to Oliver Haessler from comment #3)
> > However for a
> > later build we should see if we can remove the rpath link in the binaries
> > and add a file in /etc//ld.so.conf.d/ like the one below.
> > 
> > $ cat darktable-x86_64.conf
> > /usr/lib64/darktable/
> 
> Could you explain in detail the problem? I would like to patch the Fedora's
> darktable too.
> Thank you

The feedback was based on
https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #7 from Kalev Lember  ---
I think this applies mostly to libraries in order to keep ABI/API stable in
EPEL. I don't think the policy is meant to keep leaf desktop apps on old,
unsupported versions forever.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #6 from Germano Massullo  ---
(In reply to Kalev Lember from comment #5)
> Wouldn't it make sense to just update the existing darktable package to 2.0?
> I am not sure it's worth keeping around both 1.x and 2.x, it's just
> confusing users.

https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Some_examples_of_what_package_updates_that_are_fine_or_not

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Kalev Lember  changed:

   What|Removed |Added

 CC||klem...@redhat.com



--- Comment #5 from Kalev Lember  ---
Wouldn't it make sense to just update the existing darktable package to 2.0? I
am not sure it's worth keeping around both 1.x and 2.x, it's just confusing
users.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #4 from Germano Massullo  ---
https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/darktable2.spec
https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/darktable2-2.0.5-1.fc24.src.rpm

(In reply to Oliver Haessler from comment #3)
> However for a
> later build we should see if we can remove the rpath link in the binaries
> and add a file in /etc//ld.so.conf.d/ like the one below.
> 
> $ cat darktable-x86_64.conf
> /usr/lib64/darktable/

Could you explain in detail the problem? I would like to patch the Fedora's
darktable too.
Thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #3 from Oliver Haessler  ---
to get rid of the .gitignore file we just need to add the second rm:

# Remove bundled lua
rm -rf src/external/lua/

# Remove .gitignore file
rm -f data/lua/darktable/external/pygy_require/.gitignore


The other Errors are rpath errors and can be ignored for now. However for a
later build we should see if we can remove the rpath link in the binaries and
add a file in /etc//ld.so.conf.d/ like the one below.

$ cat darktable-x86_64.conf
/usr/lib64/darktable/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #2 from Germano Massullo  ---
Downgrading to 2.0.5 due upstream request (Nikon support broken in 2.0.6)

https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/darktable2.spec
https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/darktable2-2.0.5-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #1 from Germano Massullo  ---
There should not be problems in the spec file since it has already been
reviewed when darktable 2 landed into Fedora repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1281478

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Germano Massullo  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Oliver Haessler  changed:

   What|Removed |Added

 CC||oli...@redhat.com
   Assignee|nob...@fedoraproject.org|oli...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org