[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516



--- Comment #10 from Fedora Update System  ---
python-reproject-0.3.1-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-15 12:10:08



--- Comment #9 from Fedora Update System  ---
python-reproject-0.3.1-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516



--- Comment #8 from Fedora Update System  ---
python-reproject-0.3.1-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1d5751865a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #7 from Fedora Update System  ---
python-reproject-0.3.1-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-688cfa6470

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516



--- Comment #6 from Patrick Uiterwijk  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-reproject

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Björn "besser82" Esser  ---
Looks fine now!  =)

Package APPROVED!!!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516



--- Comment #4 from Christian Dersch  ---
Thank you, indeed I have overseen the astropy_helpers licensing...

Spec URL: https://lupinix.fedorapeople.org/review/python-reproject.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/python-reproject-0.3.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516



--- Comment #3 from Björn "besser82" Esser  ---
Created attachment 1208230
  --> https://bugzilla.redhat.com/attachment.cgi?id=1208230=edit
output of licensecheck

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516



--- Comment #2 from Björn "besser82" Esser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Header files in -devel subpackage, if present.
  Note: python2-reproject : /usr/lib64/python2.7/site-
  packages/reproject/spherical_intersect/mNaN.h python2-reproject :
  /usr/lib64/python2.7/site-
  packages/reproject/spherical_intersect/overlapArea.h python2-reproject :
  /usr/lib64/python2.7/site-
  packages/reproject/spherical_intersect/reproject_slice_c.h
  python3-reproject : /usr/lib64/python3.5/site-
  packages/reproject/spherical_intersect/mNaN.h python3-reproject :
  /usr/lib64/python3.5/site-
  packages/reproject/spherical_intersect/overlapArea.h python3-reproject :
  /usr/lib64/python3.5/site-
  packages/reproject/spherical_intersect/reproject_slice_c.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

  ---> No issue for Python-packages; python{2,3}-numpy does it the same way.
   rpmls python2-numpy | grep -e '\.h$'
   -rw-r--r-- 
/usr/lib64/python2.7/site-packages/numpy/core/include/numpy/__multiarray_api.h
   -rw-r--r-- 
/usr/lib64/python2.7/site-packages/numpy/core/include/numpy/__ufunc_api.h
   -rw-r--r-- 
/usr/lib64/python2.7/site-packages/numpy/core/include/numpy/_neighborhood_iterator_imp.h
   -rw-r--r-- 
/usr/lib64/python2.7/site-packages/numpy/core/include/numpy/_numpyconfig.h
   -rw-r--r-- 
/usr/lib64/python2.7/site-packages/numpy/core/include/numpy/arrayobject.h
   …


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

 ---> Fine for Python-packages.

[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Apache (v2.0)", "PSF", "Unknown or
 generated". 150 files have unknown license. Detailed output of
 licensecheck in /home/besser82/shared/fedora/review/1381516-python-
 reproject/licensecheck.txt

 ---> please fix License-tag and document license-breakdown in spec-file.
  Apache (v2.0)
  -
 
reproject-0.3.1/astropy_helpers/astropy_helpers/sphinx/themes/bootstrap-astropy/static/bootstrap-astropy.css

  BSD (3 clause)
  --
  reproject-0.3.1/LICENSE.md
  reproject-0.3.1/astropy_helpers/LICENSE.rst
  reproject-0.3.1/astropy_helpers/licenses/LICENSE_NUMPYDOC.rst

  PSF
  ---
  reproject-0.3.1/astropy_helpers/licenses/LICENSE_COPYBUTTON.rst

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package

 ---> explained above

[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[!]: Package complies to the Packaging Guidelines

 ---> See License-tag.

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is 

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fed...@besser82.io
   Assignee|nob...@fedoraproject.org|fed...@besser82.io
  Flags||fedora-review?



--- Comment #1 from Björn "besser82" Esser  ---
taken…  =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org