[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595

Michael Schwendt  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-12-08 11:22:30



--- Comment #5 from Michael Schwendt  ---
I advise comparing the spec files for the two packages. This one contains a
multitude of packaging mistakes. It would have needed a lot of work to get it
through the review process.


> When doing a review, the reviewers use fedora-review -b
> which automates some tasks.

Packagers ought to do that, too.

"fedora-review -b 1390595" would try to retrieve the latest spec file and
src.rpm package from this ticket, perform local test builds and run lots of
checks on the result.

*** This bug has been marked as a duplicate of bug 1394275 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595



--- Comment #4 from Derek Ditch  ---
Radovan, thanks for the update. That review was submitted after I submitted
this one. I do need this package in EPEL if possible until it is included
upstream. There are other packages that I'd like to submit but they depend on
librdkafka.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595



--- Comment #3 from Piotr Popieluch  ---
(In reply to Radovan Sroka from comment #2)
> There is another finished review for this package: 1394275, so this review
> can be closed. I add that reviewed package into the fedora repository, but
> not into EPEL. librdkafka will most likely be in next RHEL7.

Good to hear. With "next" do you mean current 7.3 beta or next 7.4? If it will
be 7.4 it would be nice if EPEL7 would provide it for the time being.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595

Radovan Sroka  changed:

   What|Removed |Added

 CC||rsr...@redhat.com



--- Comment #2 from Radovan Sroka  ---
There is another finished review for this package: 1394275, so this review can
be closed. I add that reviewed package into the fedora repository, but not into
EPEL. librdkafka will most likely be in next RHEL7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595

Piotr Popieluch  changed:

   What|Removed |Added

 CC||piotr1...@gmail.com



--- Comment #1 from Piotr Popieluch  ---
I'm interested in having librdkafka in Fedora and EPEL. I'm no sponsor so I
can't sponsor you, but I can help you with this package.

When doing a review, the reviewers use fedora-review -b which automates some
tasks. F-R downloads the files from the urls in the bugreport, builds the
packge and runs some tests. Please make sure "fedora-review -b 1390595" builds
correctly. rpmlint might be helpful too.

To become sponsored, you will have to do a couple unofficial reviews to show
you understand the package guidelines [1]. You can post the urls to those
reviews here.

Some comments: 
version/release needs to be defined in the uploaded specfile.
Group tag is deprecated, remove it unless you still want to support EL5 (which
will EOL soon).
License tag must match the short license as listed in [2]
Source needs to specify the upstream source url. [3]
BuildRoot tag is deprecated (unless EL5 support)
description needs to be wrapped at 80 chars
requires for rhel >=7 is openssl-libs, I would expect this to be the same for
Fedora (didn't check)
%clean is deprecated
don't rm -rf %{buildroot} in %install
%build you will probably want to define CFLAGS='%{optflags} to have all default
options and hardening.
%doc, put license files in %license, not %doc.
Why is the permission set to 444 in %files?


[1] https://fedoraproject.org/wiki/Packaging:Guidelines
[2] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
[3] https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org