[Bug 1393129] Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Merlin Mathesius  changed:

   What|Removed |Added

  Flags|needinfo?(mmathesi@redhat.c |
   |om) |



--- Comment #4 from Merlin Mathesius  ---
Thank you for the additional helpful review comments.

I missed the snapshot versioning guidelines. I have now corrected that, along
with addressing all of your other comments. I have kept Python 3 support, but
am only including the Python 2 version of /usr/bin/aexpect-helper with no
renamed versions or symlinks to it--I'll address that when Python 3 support is
no longer considered experimental.

Regarding the order of running the %py2_install and %py3_install macros, I
found that the second one run does *not* overwrite the first
/usr/bin/aexpect-helper. Just to avoid the unexpected, I changed the spec to
run %py3_install first, remove aexpect-helper, then run  %py2_install so only
the Python 2 version remains to be go into the python2-aexpect subpackage.

New Spec URL: https://merlinm.fedorapeople.org/python-aexpect.spec
New SRPM URL:
https://merlinm.fedorapeople.org/python-aexpect-1.2.0-2.20161010gitaca459d.fc24.src.rpm
New Koji scratch build URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16388717

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393129] Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Stephen Gallagher  changed:

   What|Removed |Added

  Flags||needinfo?(mmathesi@redhat.c
   ||om)



--- Comment #3 from Stephen Gallagher  ---
(In reply to Merlin Mathesius from comment #2)
> Thank you for the detailed and helpful review comments.
> 
> The selected commit and version (1.2.0) were unofficial in upstream.
> However, an official tag for that commit was added just today
> (https://github.com/autotest/aexpect/issues/14).
> 
> I believe I addressed all of your other issues. I also attempted to include
> support for both Python 2 and Python 3. The tagged version 1.2.0 of aexpect
> does not support Python 3--although the current HEAD does. The upstream
> maintainers have suggested a version 1.3.0 will be coming soon. Thus, in the
> interim, I updated the package version to 1.2.1, set the source to use the
> current HEAD commit, and included a patch to update the version string
> embedded in setup.py.

You can't do this. It's not safe to name something 1.2.1 because upstream could
eventually opt to release a 1.2.1 that is entirely different from what you
called 1.2.1. Then users of this package will be confused. Please drop the
version hack.

If you want to release with the python 3 support, you need to follow the naming
guidelines at
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshot_packages

The result will end up looking like:

aexpect-1.2.0-1.20161109git%{shortcommit0}.fc26


> 
> New Spec URL: https://merlinm.fedorapeople.org/aexpect-1.2.1.spec
> New SRPM URL: https://merlinm.fedorapeople.org/aexpect-1.2.1-1.fc24.src.rpm
> New Koji scratch build URL:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=16378886


OK, a few more comments:
1) I should have thought of this earlier, but aexpect-helper is probably
important to operation. So we should ship a version of it in the python3
subpackage, renamed to python3-aexpect-helper (at least until the support
becomes stable). It probably wouldn't be a bad idea to rename the python2
version to python2-aexpect-helper and carry a symlink for the
/usr/bin/aexpect-helper name. This would be future-compatible whenever we
decided to swap over to python 3 as the preferred version.

If this is getting too complicated, feel free to skip Python 3 support entirely
for the first pass here. It can be a quagmire.

2) The master name of the package should be python-aexpect, not just aexpect.
The subpackages it produces are correct.

3) The order you run the %py2_install and %py3_install macros matters. Because
both builds provide /usr/bin/aexpect-helper, whichever one builds second will
overwrite the one that builds first. In this case, that means that you are
actually installing the Python 3 version of the binary into the python2-aexpect
subpackage. Oops! (If you follow my symlink suggestion in 1), you'll want to do
the rename between the %py2_install and %py3_install calls and create the
symlink last.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393129] Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Merlin Mathesius  changed:

   What|Removed |Added

  Flags|needinfo?(mmathesi@redhat.c |
   |om) |



--- Comment #2 from Merlin Mathesius  ---
Thank you for the detailed and helpful review comments.

The selected commit and version (1.2.0) were unofficial in upstream. However,
an official tag for that commit was added just today
(https://github.com/autotest/aexpect/issues/14).

I believe I addressed all of your other issues. I also attempted to include
support for both Python 2 and Python 3. The tagged version 1.2.0 of aexpect
does not support Python 3--although the current HEAD does. The upstream
maintainers have suggested a version 1.3.0 will be coming soon. Thus, in the
interim, I updated the package version to 1.2.1, set the source to use the
current HEAD commit, and included a patch to update the version string embedded
in setup.py.

New Spec URL: https://merlinm.fedorapeople.org/aexpect-1.2.1.spec
New SRPM URL: https://merlinm.fedorapeople.org/aexpect-1.2.1-1.fc24.src.rpm
New Koji scratch build URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16378886

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393129] Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Stephen Gallagher  changed:

   What|Removed |Added

 CC||mmath...@redhat.com
  Flags||needinfo?(mmathesi@redhat.c
   ||om)



--- Comment #1 from Stephen Gallagher  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel
  Currently, the package has `BuildRequires: python`, but it should be one or
both of `BuildRequires: python2-devel` or `BuildRequires: python3-devel`

- If the package only supports Python 2, then it needs to indicate that in a
comment in the spec file. If it supports Python 3, then it must build the
Python 3 version as well and only the python3-aexpect package may ship
aexpect-helper

- Non-blocking, but instead of `%{python_sitelib}/aexpect*`, use
%{python_sitelib}/aexpect/
%{python_sitelib}/aexpect-%{version}-py%{python2_version}-.egg-info

This has the benefit of intentionally failing a build if an unexpected file
starting with "aexpect" turns up in that location. It's better to be explicit
about what ends up in the RPMs.

- The URL is wrong: it points to the Avocado documentation. It should probably
just be https://github.com/autotest/aexpect

- Drop the %defattr line from %files. It's not needed on Fedora or any
currently supported version of RHEL.

- Where does the version 1.2.0 come from? I don't see that in the tarball or
upstream anywhere.

- The commit doesn't match the latest HEAD or any tags. Why pick that one? It
needs to be in a comment.

- Upstream includes a script called `selftests/checkall`. Why isn't this run in
%check?. If it doesn't work or isn't meaningful, it should be added to the spec
but commented out with a note about why for future packagers.

- in %description, drop the "Aexpect is" lead-in. It doesn't need to duplicate
the name.

= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2)", "GPL (v2 or later)", "Unknown or generated". 26
 files have unknown license. Detailed output of licensecheck in
 /home/fedorareview/1393129-aexpect/licensecheck.txt
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not 

[Bug 1393129] Review Request: aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Stephen Gallagher  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sgall...@redhat.com
   Assignee|nob...@fedoraproject.org|sgall...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org