[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #22 from Fedora Update System  ---
librdkafka-0.9.2-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-02-03 15:49:00



--- Comment #21 from Fedora Update System  ---
librdkafka-0.9.2-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Michael Schwendt  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)
 CC||de...@rocknsm.io



--- Comment #20 from Michael Schwendt  ---
*** Bug 1390595 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #19 from Michael Schwendt  ---
> Name: librdkafka  
> Group:Development/Libraries

The base Group for runtime library packages has been "System
Environment/Libraries" for many years back to very old releases of Red Hat
Linux.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #18 from Fedora Update System  ---
librdkafka-0.9.2-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b48ed650ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #17 from Fedora Update System  ---
librdkafka-0.9.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2e06f45c93

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #16 from Fedora Update System  ---
librdkafka-0.9.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-02b847f9d7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #15 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/librdkafka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #14 from Jakub Jelen  ---
Thanks for the explanation. I though there was something like this, but I was
unable to find it. So it is certainly bug in fedora-review, which would be good
to resolve. For the reference, there is already a ticket in the fedora-review
[1], but it was not touched yet.

[1] https://fedorahosted.org/FedoraReview/ticket/278

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #13 from Igor Gnatenko  ---
(In reply to Jakub Jelen from comment #10)
> Igor, thanks for amendment.
> 
> The compilers (gcc, gcc-c++) are not needed according to Fedora review tool,
> but I can't find the actual paragraph in the Guidelines. Can you point to
> this one? If so, we should probably fix the tool not to report this kind of
> issue.
There were changes in guidelines couple of months ago. There was section about
BRs which you don't need to include, now you have:
"It is important that your package list all necessary build dependencies using
the BuildRequires: tag. You may assume that enough of an environment exists for
RPM to function, to build packages and execute basic shell scripts, but you
should not assume any other packages are present as RPM dependencies and
anything brought into the buildroot by the build system may change over time."

I'm not sure if there is open ticket for fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Jakub Jelen  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Jakub Jelen  ---
Now it looks good.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

>>> Missing reference to evaluate this item, but not a blocker

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "BSD (2 clause) MIT/X11 (BSD like)",
 "zlib/libpng", "BSD (2 clause) ISC", "BSD (3 clause)", "BSD (2
 clause)". 100 files have unknown license.

>>> Please, make sure with upstream that the licence headers are added to the 
>>> missing files (src/rdkafka_queue.c, src/rdkafka_queue.h, tests/test.h, ...).

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully 

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #11 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-9.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #10 from Jakub Jelen  ---
Igor, thanks for amendment.

The compilers (gcc, gcc-c++) are not needed according to Fedora review tool,
but I can't find the actual paragraph in the Guidelines. Can you point to this
one? If so, we should probably fix the tool not to report this kind of issue.

Please, remove the %clean section.

Also the %dir is needed (not sure what was meant by the 5th item above). If
removed we end with

- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/include/librdkafka/rdkafka.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #9 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-8.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #8 from Igor Gnatenko  ---
* Missing BuildRequires for compiler (gcc, gcc-c++)
* make %{?_smp_mflags} -> %make_build
* %clean section should not be used
* don't use 0644 permissions on shared objects
* %dir %{_includedir}/librdkafka -> %{_includedir}/librdkafka/
* Group tag is not needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #7 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-6.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #6 from Jakub Jelen  ---
The testsuite requires python

  [librdkafka-0.9.2]$ grep -r "python"
  tests/LibrdkafkaTestApp.py:#!/usr/bin/env python
  [...]

so I guess we need BuildRequires python for the tests.



Rpmlint (installed packages)

sh: /usr/bin/python: No such file or directory

> probably bug in fedora-review in rawhide

librdkafka-devel.x86_64: W: only-non-binary-in-usr-lib

> The *.so files in the non-devel should have reasonable permissions (but it 
> does not look like helping the message above). A bug in rpmlint (bug 
> #1251505)?:

> %attr(0644,root,root) %{_libdir}/librdkafka.so.*
> %attr(0644,root,root) %{_libdir}/librdkafka++.so.*

librdkafka-devel.x86_64: W: no-documentation

> We should have some manual page. Though it is not crucial

librdkafka.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/librdkafka++.so.1 /lib64/libz.so.1
librdkafka.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/librdkafka++.so.1 /lib64/librt.so.1

> Make sure the libraries (libz, librt) are used in the code or the proper 
> configure flags are used to build the package with these dependencies.

3 packages and 0 specfiles checked; 0 errors, 4 warnings.

===
Otherwise it looks good

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #5 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-4.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #4 from Jakub Jelen  ---
Few more notes from fedora-review:

Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #3 from Jakub Jelen  ---
Rpmlint
---
Checking: librdkafka-0.9.2-2.fc24.x86_64.rpm
  librdkafka-devel-0.9.2-2.fc24.x86_64.rpm
  librdkafka-debuginfo-0.9.2-2.fc24.x86_64.rpm
  librdkafka-0.9.2-2.fc24.src.rpm
librdkafka.x86_64: W: devel-file-in-non-devel-package /usr/lib64/librdkafka.so
librdkafka.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/librdkafka++.so

> Non-versioned *.so files should go to the *-devel package

librdkafka-devel.x86_64: W: only-non-binary-in-usr-lib
librdkafka-devel.x86_64: W: no-documentation
librdkafka-devel.x86_64: W: spurious-executable-perm
/usr/include/librdkafka/rdkafka.h
librdkafka-devel.x86_64: W: spurious-executable-perm
/usr/include/librdkafka/rdkafkacpp.h
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

in specfile:
> %defattr(444,root,root)

> The %defattr directive in the %files list SHOULD ONLY be used when setting a 
> non-default value, or to reset to the default value after having set a 
> non-default value. 

From https://fedoraproject.org/wiki/Packaging:Guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Jakub Jelen  changed:

   What|Removed |Added

 CC||jje...@redhat.com
   Assignee|nob...@fedoraproject.org|jje...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #2 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #1 from Daniel Kopeček  ---
Found a small issue in the spec. Here's the pagure PR:

https://pagure.io/librdkafka/pull-request/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org