[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255

Orion Poplawski  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||python3-zope-interface-4.3.
   ||3-1.el7
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-05-03 17:36:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255
Bug 1395255 depends on bug 1395244, which changed state.

Bug 1395244 Summary: Review Request: python3-zope-event - Zope Event Publication
https://bugzilla.redhat.com/show_bug.cgi?id=1395244

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-zope-interface

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Randy Barlow  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 81 files have unknown license. Detailed
 output of licensecheck in /home/rbarlow/reviews/1395255-python3-zope-
 interface/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/python3.5/site-
 packages/zope(python3-zope-i18nmessageid, python3-zope-interface)
 randy: This seems to be how zope is doing things.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 204800 bytes in 16 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include 

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255

Aurelien Bompard  changed:

   What|Removed |Added

  Flags|needinfo?(aurelien@bompard. |
   |org)|



--- Comment #2 from Aurelien Bompard  ---
Ah, my older version of rpmlint did not report that, but now that I'm on F25 it
does, nice :-)

Thanks for the review, I fixed both issues.

Spec URL:
https://abompard.fedorapeople.org/reviews/python3-zope-interface/python3-zope-interface.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/python3-zope-interface/python3-zope-interface-4.3.2-1.el7.centos.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255

Randy Barlow  changed:

   What|Removed |Added

 CC||aurel...@bompard.org
  Flags||needinfo?(aurelien@bompard.
   ||org)



--- Comment #1 from Randy Barlow  ---
To pass this, fedora-review wants the COPYRIGHT.txt file to be marked with
%license as well.

Optionally, you could remove the .gitignore file that rpmlint is marking as an
error, and then you'd have a clean rpmlint.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395255] Review Request: python3-zope-interface - Zope 3 Interface Infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395255

Yanko Kaneti  changed:

   What|Removed |Added

 CC||yan...@declera.com
Summary|Review Request:  -|Zope 3 Interface
   ||Infrastructure



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org