[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #36 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #35 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-27 00:18:58



--- Comment #34 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #33 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f51669220c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #32 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6841e63ca1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #31 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6841e63ca1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #30 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f51669220c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #29 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3ddc4480c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #28 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-3.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-33843a76b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #27 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-33843a76b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #26 from Fedora Update System  ---
dnscrypt-proxy-gui-1.2.3-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b3ddc4480c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #25 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/dnscrypt-proxy-gui

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

greg.helli...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #24 from greg.helli...@gmail.com ---
It also looks like it's been resolved now. Hearing no other objections to
approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #23 from Fl@sh  ---
# uname -r
4.9.0-0.rc8.git0.1.fc26.x86_64

# rpm -qR systemd | grep crypt
libcrypt.so.1()(64bit)
libcrypt.so.1(GLIBC_2.2.5)(64bit)
libgcrypt.so.20()(64bit)
libgcrypt.so.20(GCRYPT_1.6)(64bit)

So, this conflict in systemd dependencies. It seems, this is temporarily
problem with libcrypt package naming.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #22 from greg.helli...@gmail.com ---
I think it's worth noting that the package does not compile against f26. I'm
not certain if this is a fault of this package or of its dependencies. This is
the output I see when trying to build for Rawhide targets:

There is no installed groups file.
Maybe run: yum groups mark convert (see man yum)
Error: libcrypt conflicts with libcrypt-nss-2.24.90-21.fc26.x86_64
Error: libcrypt-nss conflicts with libcrypt-2.24.90-21.fc26.x86_64
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest
ERROR:
Exception(/home/vagrant/1397089-dnscrypt-proxy-gui/srpm-unpacked/dnscrypt-proxy-gui-1.2.3-3.fc26.src.rpm)
Config(f26-candidate-x86_64) 0 minutes 18 second

Can you briefly look into that to discern if it's a problem with this package
or with the libcrypt packages? That's my last outstanding concern.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #21 from Fl@sh  ---
fixed:

Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec

SRPM URL:
https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.3-3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #20 from Zbigniew Jędrzejewski-Szmek  ---
Then you should add it back ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #19 from Fl@sh  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #17)
> (In reply to greg.hellings from comment #16)
> > - All build dependencies are listed in BuildRequires, except for any that
> >   are listed in the exceptions section of Packaging Guidelines.
> >   Note: These BR are not needed: gcc-c++
> >   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> 
> fedora-review is not up to date here. The guidelines changed to require
> everything to be specified, in particular the compile and make and so on.
> [https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2]

i'm remove gcc-c++ already :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #18 from Fl@sh  ---
fixed release (without rpmlint warning "W: spelling-error %description -l en_US
resolvers"):

Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec

SRPM URL:
https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #17 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to greg.hellings from comment #16)
> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.
>   Note: These BR are not needed: gcc-c++
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

fedora-review is not up to date here. The guidelines changed to require
everything to be specified, in particular the compile and make and so on.
[https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

greg.helli...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #16 from greg.helli...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in dnscrypt-proxy-gui
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Need to add a %license entry to the files section
- You need to either take ownership of /etc/dbus-1/system.d or depend on a
  package that does
- Is it necessary for you to list all of the Requires out, explicitly?
  Some of them seem to be pulled in, automatically, by the packaging
  macros. Please evaluate whether all of those are needed or not.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 28 files have unknown license. Detailed
 output of licensecheck in /home/vagrant/dev/source/packaging/1397089
 -dnscrypt-proxy-gui/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/dbus-1/system.d
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/dbus-1/system.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 

[Bug 1397089] Review Request: dnscrypt-proxy-gui - GUI wrapper for dnscrypt-proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089

Fl@sh  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |dnscrypt-proxy-gui - The|dnscrypt-proxy-gui - GUI
   |GUI wrapped over|wrapper for dnscrypt-proxy
   |dnscrypt-proxy  |



--- Comment #15 from Fl@sh  ---
fixed summary in new version:

Spec URL: https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui.spec

SRPM URL:
https://f1ash.fedorapeople.org/DNSCryptClient/dnscrypt-proxy-gui-1.2.3-1.fc26.src.rpm

Success build : http://koji.fedoraproject.org/koji/taskinfo?taskID=16783203

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org