[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #14 from Fedora Update System--- python-idstools-0.5.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #13 from Fedora Update System--- python-idstools-0.5.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 Fedora Update Systemchanged: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-12-31 01:48:08 --- Comment #12 from Fedora Update System --- python-idstools-0.5.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #11 from Fedora Update System--- python-idstools-0.5.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9f3d307043 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #10 from Fedora Update System--- python-idstools-0.5.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0684e943f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 Fedora Update Systemchanged: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- python-idstools-0.5.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-736b58c885 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #8 from Fedora Update System--- python-idstools-0.5.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9f3d307043 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #7 from Fedora Update System--- python-idstools-0.5.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-736b58c885 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 Fedora Update Systemchanged: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #6 from Fedora Update System--- python-idstools-0.5.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0684e943f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #5 from Jon Ciesla--- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-idstools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 gil cattaneochanged: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #4 from marcindulak--- Spec URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r02/python-idstools.spec SRPM URL: https://marcindulak.fedorapeople.org/packages/py-idstools/r02/python-idstools-0.5.4-1.fc23.src.rpm (In reply to gil cattaneo from comment #3) > Issues: > > [!]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. I've asked upstream to include a license file https://github.com/jasonish/py-idstools/issues/32 > > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", > "Unknown or generated". 17 files have unknown license. Detailed output > of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt > Removed the libraries bundled under the compat folder, and with them: MIT/X11 (BSD like) -- py-idstools-0.5.4/idstools/compat/ordereddict.py The setup.py file is explicit about BSD license so there should be no licensing problem for other files > The following source files are without license headers: > py-idstools-0.5.4/bin/idstools-dumpdynamicrules > py-idstools-0.5.4/bin/idstools-eve2pcap > py-idstools-0.5.4/bin/idstools-gensidmsgmap > py-idstools-0.5.4/bin/idstools-rulecat > py-idstools-0.5.4/bin/idstools-u2bench > py-idstools-0.5.4/bin/idstools-u2eve > py-idstools-0.5.4/bin/idstools-u2fast > py-idstools-0.5.4/bin/idstools-u2json > py-idstools-0.5.4/bin/idstools-u2spewfoo > py-idstools-0.5.4/doc/conf.py > py-idstools-0.5.4/idstools/__init__.py > py-idstools-0.5.4/idstools/compat/argparse/argparse.py > py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py > py-idstools-0.5.4/tests/test_classificationmap.py > py-idstools-0.5.4/tests/test_signaturemap.py > > Please, ask to upstream to confirm the licensing of code and/or content/s, > and add license headers > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification > > [!]: License file installed when any subpackage combination is installed. see above, we don't have explicit license file yet > > [!]: Package contains no bundled libraries without FPC exception. > py-idstools-0.5.4/idstools/compat/argparse/__init__.py > py-idstools-0.5.4/idstools/compat/argparse/argparse.py > py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt addressed above > > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. see above > > [!]: Package does not include license text files separate from upstream. > > [!]: Package consistently uses macros (instead of hard-coded directory > names). > > "%{!?py2_build: %global py2_build > CFLAGS="%{optflags}" /usr/bin/python2 > setup.py build --executable="/usr/bin/python2 -s"}" > > [?]: Package complies to the Packaging Guidelines > why customized the py?_build/install macros? I've removed the macros. Without those macros the RPM does not build on a standalone CentOS7, but it builds in koji and mock. > > Please, fix these problems > > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py > /usr/bin/env python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 > /usr/bin/env python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env > python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env > python > python3-idstools.noarch: E: wrong-script-interpreter > /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env > python > python3-idstools.noarch: E: non-executable-script > /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 > /usr/bin/env python > python3-idstools.noarch: E:
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #3 from gil cattaneo--- Issues: [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt The following source files are without license headers: py-idstools-0.5.4/bin/idstools-dumpdynamicrules py-idstools-0.5.4/bin/idstools-eve2pcap py-idstools-0.5.4/bin/idstools-gensidmsgmap py-idstools-0.5.4/bin/idstools-rulecat py-idstools-0.5.4/bin/idstools-u2bench py-idstools-0.5.4/bin/idstools-u2eve py-idstools-0.5.4/bin/idstools-u2fast py-idstools-0.5.4/bin/idstools-u2json py-idstools-0.5.4/bin/idstools-u2spewfoo py-idstools-0.5.4/doc/conf.py py-idstools-0.5.4/idstools/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py py-idstools-0.5.4/tests/test_classificationmap.py py-idstools-0.5.4/tests/test_signaturemap.py Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification [!]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. py-idstools-0.5.4/idstools/compat/argparse/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. [!]: Package consistently uses macros (instead of hard-coded directory names). "%{!?py2_build:%global py2_buildCFLAGS="%{optflags}" /usr/bin/python2 setup.py build --executable="/usr/bin/python2 -s"}" [?]: Package complies to the Packaging Guidelines why customized the py?_build/install macros? Please, fix these problems python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/rulecat.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/gensidmsgmap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2eve.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2fast.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2spewfoo.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/eve2pcap.py 644 /usr/bin/env python python3-idstools.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py /usr/bin/env python python3-idstools.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/idstools/scripts/u2json.py 644 /usr/bin/env python NON blocking issues: python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2fast python3-idstools.noarch: W: no-manual-page-for-binary idstools-eve2pcap python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2eve python3-idstools.noarch: W: no-manual-page-for-binary idstools-gensidmsgmap python3-idstools.noarch: W: no-manual-page-for-binary idstools-rulecat python3-idstools.noarch: W: no-manual-page-for-binary idstools-u2json manual pages should be generated with sphinx in py-idstools-0.5.4/doc ? --
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 gil cattaneochanged: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from gil cattaneo --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "*No copyright* BSD", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/gil/1398369-python-idstools/licensecheck.txt The following source files are without license headers: py-idstools-0.5.4/bin/idstools-dumpdynamicrules py-idstools-0.5.4/bin/idstools-eve2pcap py-idstools-0.5.4/bin/idstools-gensidmsgmap py-idstools-0.5.4/bin/idstools-rulecat py-idstools-0.5.4/bin/idstools-u2bench py-idstools-0.5.4/bin/idstools-u2eve py-idstools-0.5.4/bin/idstools-u2fast py-idstools-0.5.4/bin/idstools-u2json py-idstools-0.5.4/bin/idstools-u2spewfoo py-idstools-0.5.4/doc/conf.py py-idstools-0.5.4/idstools/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/scripts/dumpdynamicrules.py py-idstools-0.5.4/tests/test_classificationmap.py py-idstools-0.5.4/tests/test_signaturemap.py Please, ask to upstream to confirm the licensing of code and/or content/s, and add license headers https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification [!]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. py-idstools-0.5.4/idstools/compat/argparse/__init__.py py-idstools-0.5.4/idstools/compat/argparse/argparse.py py-idstools-0.5.4/idstools/compat/argparse/LICENSE.txt [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 --- Comment #1 from gil cattaneo--- have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1244657 ? thanks in advance -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398369] Review Request: python-idstools - Snort and Suricata Rule and Event Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1398369 gil cattaneochanged: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org