[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #19 from Fedora Update System  ---
qrmumps-2.0-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #18 from Fedora Update System  ---
qrmumps-2.0-4.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-19 01:01:55



--- Comment #17 from Fedora Update System  ---
qrmumps-2.0-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #16 from Fedora Update System  ---
qrmumps-2.0-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b67f3530e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #15 from Fedora Update System  ---
qrmumps-2.0-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ec29baa85

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
qrmumps-2.0-4.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2036a8c913

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #12 from Fedora Update System  ---
qrmumps-2.0-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b67f3530e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #11 from Fedora Update System  ---
qrmumps-2.0-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ec29baa85

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #13 from Fedora Update System  ---
qrmumps-2.0-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2036a8c913

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qrmumps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Jerry James  ---
(In reply to Antonio Trande from comment #8)
> This is a private source link provided by upstream directly.

If there is no public link for the sources, then Source0 should refer to just
the filename, not to a URL.

That's a minor issue.  This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #8 from Antonio Trande  ---
(In reply to Jerry James from comment #7)
> Issues
> ==
> 1. The Source0 URL is not correct.  The webserver returns an HTTP 404 for
> that
>URL.
>

This is a private source link provided by upstream directly.

> 2. The license should be LGPLv3+ instead of LGPLv3, as the source files
> contain
>the "any later version" language.
> 

Fixed.

> 3. Can make be invoked with %{?_smp_mflags}?
> 

It's not supported.

Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #7 from Jerry James  ---
Issues
==
1. The Source0 URL is not correct.  The webserver returns an HTTP 404 for that
   URL.

2. The license should be LGPLv3+ instead of LGPLv3, as the source files contain
   the "any later version" language.

3. Can make be invoked with %{?_smp_mflags}?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0:
 http://buttari.perso.enseeiht.fr/qr_mumps/releases/2.0/qr_mumps-2.0.tgz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
 translations for supported 

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #6 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16730343

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #5 from Antonio Trande  ---
Sorry, let me check again later; something is changed after renaming of
libraries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #4 from Jerry James  ---
It still fails to build in mock (building for fedora-rawhide-x86_64):

make[1]: Leaving directory '/builddir/build/BUILD/qr_mumps-2.0/build'
~/build/BUILD/qr_mumps-2.0/build/lib ~/build/BUILD/qr_mumps-2.0
+ pushd build/lib
+ gfortran -shared -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
-fPIC -Wl,-z,now -Wl,--whole-archive libqrm_common.a -Wl,-no-whole-archive
-Wl,--as-needed -L/usr/lib64 -lmetis -lgfortran -lm -lrt
-Wl,-soname,libqrm-common.so.2.0 -o libqrm-common.so.2.0
+ gfortran -shared -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
-fPIC -Wl,-z,now -Wl,--whole-archive libdqrm.a libqrm_common.a
-Wl,-no-whole-archive -L./ -lqrm-common -Wl,--as-needed -L/usr/lib64 -lblas
-llapack -lscotch -lscotcherr -lmetis -lgfortran -lm -lrt
-Wl,-soname,libdqrm.so.2.0 -o libdqrm.so.2.0
/usr/bin/ld: cannot find -lqrm-common
collect2: error: ld returned 1 exit status

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #3 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

Just a little typo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #2 from Jerry James  ---
This package does not build in mock:

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.kXF2PG
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf qrmumps-2.0
+ /usr/bin/gzip -dc /builddir/build/SOURCES/qr_mumps-2.0.tgz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd qrmumps-2.0
RPM build errors:
/var/tmp/rpm-tmp.kXF2PG: line 37: cd: qrmumps-2.0: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.kXF2PG (%prep)
Bad exit status from /var/tmp/rpm-tmp.kXF2PG (%prep)
Child return code was: 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James  ---
I will take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org