[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #18 from Fedora Update System  ---
configsnap-0.11-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #17 from Fedora Update System  ---
configsnap-0.11-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #16 from Fedora Update System  ---
configsnap-0.11-2.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-01-28 22:16:35



--- Comment #15 from Fedora Update System  ---
configsnap-0.11-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #14 from Fedora Update System  ---
configsnap-0.11-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-33ef43756a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #13 from Fedora Update System  ---
configsnap-0.11-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9eceee16d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #12 from Fedora Update System  ---
configsnap-0.11-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4e3b8f8b55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
configsnap-0.11-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-454e58d905

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #9 from Fedora Update System  ---
configsnap-0.11-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-454e58d905

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #10 from Fedora Update System  ---
configsnap-0.11-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-33ef43756a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #8 from Fedora Update System  ---
configsnap-0.11-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4e3b8f8b55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #7 from Fedora Update System  ---
configsnap-0.11-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9eceee16d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/configsnap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

   Assignee|christos.triantafyllidis@gm |ricardo.corde...@tux.com.pt
   |ail.com |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Ricardo Cordeiro  changed:

   What|Removed |Added

   Assignee|ricardo.corde...@tux.com.pt |christos.triantafyllidis@gm
   ||ail.com
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Ricardo Cordeiro  ---
Hi Christos,

Thanks for your update, modified specfile and patch. The package is ready to be
included in the package DB.

Please find below my last review.

Kind Regards,
Ricardo Cordeiro


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown
 license. Detailed output of licensecheck in
 /home/makerpm/reviews/configsnap/1406786-configsnap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[-]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or 

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

  Flags|needinfo?(christos.triantaf |
   |ylli...@gmail.com)  |



--- Comment #4 from Christos Triantafyllidis 
 ---
Thank you Ricardo,

Updated SRPM:
https://ctria.fedorapeople.org/packaging/configsnap/configsnap-0.11-2.fc25.src.rpm

Updated SPEC:
https://ctria.fedorapeople.org/packaging/configsnap/configsnap.spec

Included patch (as I don't think that needs to go to upstream, that is a Fedora
implementation issue):
https://ctria.fedorapeople.org/packaging/configsnap/python_executable.patch

On your comments:
[!]: Package obeys FHS, except libexecdir and /usr/target.
Correct, changed!

[!]: Package meets the Packaging Guidelines::Python
Correct, changed!

[?] - getData script provided by upstream is not included. I understand that
  its purpose is limited as it only serves to warn the user that the script
  has been renamed to configsnap. I guess you've not included it by design,
  although, if included, /usr/bin/getdata would not collide with any
current
  packages on Fedora, RHEL and EPEL repositories. Please confirm that this
was
  done by design.
That is done by design that was added as part of the deprecation of the old
project name. There is no need to introduce this in Fedora/EPEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

 Whiteboard|AwaitingSubmitter   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Ricardo Cordeiro  changed:

   What|Removed |Added

 CC||christos.triantafyllidis@gm
   ||ail.com
 Whiteboard||AwaitingSubmitter
  Flags||needinfo?(christos.triantaf
   ||ylli...@gmail.com)



--- Comment #3 from Ricardo Cordeiro  ---
Hi Christos,

Please review the following official review results. Once you're ready for a
2nd pass, please drop "AwaitingSubmitter" from the Whiteboard. Thanks.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed

 "The %defattr directive in the %files list SHOULD ONLY be used when
setting a
  non-default value, or to reset to the default value after having set a
  non-default value."
  Reference:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

  I would recommend removing it per guidelines but I will not fail this
review if
  it remains unchanged.

[!]: Package obeys FHS, except libexecdir and /usr/target.

 /usr/bin/configsnap fails to run if not done as root. This being the case,
it
 should be placed under /usr/sbin instead
 Ref.: http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s10.html

[!]: Package meets the Packaging Guidelines::Python

 "Packages in Fedora should not depend on where /usr/bin/python happens to
point
 but instead should call the proper executable for the needed python major
version
 directly, either /usr/bin/python2 or /usr/bin/python3 as appropriate."
 Ref.:
https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes

 /usr/bin/configsnap's shebang is set to /usr/bin/python, I would suggest
upstream
 to change this or alternatively patch the source when packaging the for
Fedora
 and EPEL as it has been done for unoconv 
 http://pkgs.fedoraproject.org/cgit/rpms/unoconv.git/tree/

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown
 license. Detailed output of licensecheck in
 /home/makerpm/reviews/configsnap/1406786-configsnap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does 

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

gryfrev8-redhat.com-rj...@tux.com.pt changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

gryfrev8-redhat.com-rj...@tux.com.pt changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||gryfrev8-redhat.com-rjmco@t
   ||ux.com.pt
   Assignee|nob...@fedoraproject.org|gryfrev8-redhat.com-rjmco@t
   ||ux.com.pt



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Sachidananda Urs  changed:

   What|Removed |Added

 CC||s...@redhat.com



--- Comment #2 from Sachidananda Urs  ---
This is an unofficial review of the package:

Looks good to me.

rpmlint results:

[sac@dhcp35-44 1406786-configsnap]$ rpmlint
results/configsnap-0.11-1.fc24.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[sac@dhcp35-44 1406786-configsnap]$ rpmlint 
results/configsnap-0.11-1.fc24.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

fedora-review runs successfully. No issue seen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

  Alias||configsnap



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #1 from Christos Triantafyllidis 
 ---
Fedora 25 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015371

Fedora 24 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015375

EPEL7 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015377

EPEL6 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015384


It is not possible to do a scratch build for rawhide currently as it fails on
dependencies that are not related to that package:
Error: nothing provides libpython3.6m.so.1.0()(64bit) needed by
gdb-headless-7.12-31.fc26.aarch64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org