[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Peter Robinson  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-04-25 12:26:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mimic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Paul Whalen  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(pwha...@redhat.co |
   |m)  |



--- Comment #4 from Paul Whalen  ---
Looks good, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Peter Robinson  changed:

   What|Removed |Added

  Flags||needinfo?(pwha...@redhat.co
   ||m)



--- Comment #3 from Peter Robinson  ---
I believe 1.2.0.2 resolved the license issues between the actual copying file
and associated source file updates:

https://github.com/MycroftAI/mimic/blob/master/COPYING

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009



--- Comment #2 from Peter Robinson  ---
Mostly updated. I believe according to the upstream COPYING file the license is
correct. I need to verify that based on this output:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later) (with incorrect FSF address)", "Apache",
 "LGPL (v2.1 or later)", "Unknown or generated", "BSD". 451 files have
 unknown license. Detailed output of licensecheck in
 /home/pwhalen/1410009-mimic/licensecheck.txt

SPEC: https://pbrobinson.fedorapeople.org/mimic.spec
SRPM: https://pbrobinson.fedorapeople.org/mimic-1.2.0.2-1.fc26.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=18475280

Please confirm the rest is OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Peter Robinson  changed:

   What|Removed |Added

Summary|Review Request: mimic - |Review Request: mimic -
   |Mycroft's TTS engine, based |Mycroft's TTS engine
   |on CMU's Flite  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine, based on CMU' s Flite

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Peter Robinson  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine, based on CMU' s Flite

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009



--- Comment #1 from Paul Whalen  ---

Issues to be resolved:
==

* Source url doesn't seem to work
* License should be reviewed, doesn't match
* rpath should be removed
* Shorten the description
* Fix version in the changelog
* undefined-non-weak-symbol should be looked at/reported upstream, but not a
blocker


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
 Note: See rpmlint output
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later) (with incorrect FSF address)", "Apache",
 "LGPL (v2.1 or later)", "Unknown or generated", "BSD". 451 files have
 unknown license. Detailed output of licensecheck in
 /home/pwhalen/1410009-mimic/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0:
 https://github.com/MycroftAI/mimic/archive/mimic-1.1.0.tar.gz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in 

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine, based on CMU' s Flite

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Paul Whalen  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|pwha...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410009] Review Request: mimic - Mycroft's TTS engine, based on CMU' s Flite

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410009

Paul Whalen  changed:

   What|Removed |Added

 CC||pwha...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org