[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413038

Jiri Konecny  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-05-30 02:22:28



--- Comment #6 from Jiri Konecny  ---
The package is now in Rawhide.

Thank you for your help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413038



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-simpleline

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413038

Orion Poplawski  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #4 from Orion Poplawski  ---
I would still get rid of:

# This is a Red Hat maintained package which is specific to
# our distribution.  Thus the source is only available from
# within this srpm.
# This tarball was created from upstream git:
#   git clone https://github.com/rhinstaller/simpleline
#   cd simpleline && make archive

as that does not appear to apply.  Otherwise looks good, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413038



--- Comment #3 from Jiri Konecny  ---
Spec file and srpm are updated.

Spec URL:
https://jkonecny.fedorapeople.org/packages/simpleline/python-simpleline.spec
SRPM URL:
https://jkonecny.fedorapeople.org/packages/simpleline/python-simpleline-0.1-2.fc27.src.rpm

I hope I've fixed all the issues.

Thank you for your review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413038

Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||or...@cora.nwra.com
   Assignee|nob...@fedoraproject.org|or...@cora.nwra.com



--- Comment #2 from Orion Poplawski  ---
- I don't your comments about the source are right - they appear to come
directly from github
- Drop %clean.
- Use %make_build for parallel make
- Group is not needed
- I prefer %check after %install since that is the order sections are run
- Even though this may be python3- only at the moment, I would still suggest
naming the package "python-simpleline".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1413038



--- Comment #1 from Jiri Konecny  ---
I'm attaching output from fedora-review tool:

I want to react on two issues there:
1) Sources used to build the package match the upstream source, as provided
  in the spec URL.
 - This is because I changed summary in spec file which is in repo already but
it's not tagged as new version.

2) Uses parallel make %{?_smp_mflags} macro.
 - No reason for this. Makefile will only start python3 setup.py and do a bunch
of shell commands.

Jirka

===


This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /tmp/simpleline-build
  /review-python3-simpleline/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL


= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 115 files have
 unknown license. Detailed output of licensecheck in /tmp/simpleline-
 build/review-python3-simpleline/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/wba/LC_MESSAGES,
 /usr/share/locale/kw@kkcor, /usr/share/locale/kw_GB,
 /usr/lib/python3.6, /usr/share/locale/kw_GB/LC_MESSAGES,
 /usr/lib/python3.6/site-packages,
 /usr/share/locale/kw@kkcor/LC_MESSAGES,
 /usr/share/locale/kw@uccor/LC_MESSAGES, /usr/share/locale/kw@uccor,
 /usr/share/locale/wba
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/locale/kw@uccor/LC_MESSAGES,
 /usr/share/locale/wba/LC_MESSAGES, /usr/share/locale/kw@uccor,
 /usr/share/locale/kw@kkcor, /usr/share/locale/kw_GB/LC_MESSAGES,
 /usr/share/locale/kw_GB, /usr/share/locale/wba, /usr/lib/python3.6
 /site-packages, /usr/lib/python3.6,
 /usr/share/locale/kw@kkcor/LC_MESSAGES
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either