[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390

Thomas Andrejak  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-12 07:35:13



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #12 from Fedora Update System  ---
prewikka-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #11 from Fedora Update System  ---
prewikka-3.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #10 from Fedora Update System  ---
prewikka-3.1.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #9 from Fedora Update System  ---
prewikka-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c319dbf2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #8 from Fedora Update System  ---
prewikka-3.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c77da35627

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
prewikka-3.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-298e644db4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #6 from Fedora Update System  ---
prewikka-3.1.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-298e644db4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #5 from Fedora Update System  ---
prewikka-3.1.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c77da35627

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #4 from Fedora Update System  ---
prewikka-3.1.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-73c319dbf2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags||fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Two small issues:
- COPYING is listed twice in %files
- the %description suggests that this is a GUI application. It'd be nice to
reword it somehow to say that this is a backend for a browser interface.

+ package name is OK
+ license is acceptable (GPLv2+)
+ license is specified correctly
+ latest version
+ builds and installs correctly
+ Provides/Requires/BuildRequires appear correct
+ no scriptlets

> I try another approch, it add a new warning in rpmlint but the SPEC is more 
> clean. What do you think ?

Nah, I think this is OK.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #2 from Thomas Andrejak  ---
New files : 
SPEC : https://fedorapeople.org/~totol/prewikka.spec
SRPM : https://fedorapeople.org/~totol/prewikka-3.1.0-1.fc26.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> fedora-review complains:
> [ ]: Package requires other packages for directories it uses.
>  Note: No known owner of /usr/lib/python2.7/site-
>  packages/prewikka/locale/de, /usr/lib/python2.7/site-
>  packages/prewikka/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/de/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/fr, /usr/lib/python2.7/site-
>  packages/prewikka/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/en, /usr/lib/python2.7/site-
>  packages/prewikka/locale, /usr/lib/python2.7/site-
>  packages/prewikka/locale/es, /usr/lib/python2.7/site-
>  packages/prewikka/locale/ru, /usr/lib/python2.7/site-
>  packages/prewikka/locale/pt_BR, /usr/lib/python2.7/site-
>  packages/prewikka/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka, /usr/lib/python2.7/site-
>  packages/prewikka/locale/it, /usr/lib/python2.7/site-
>  packages/prewikka/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-
>  packages/prewikka/locale/pl
> This should be covered by -f %{name}.lang, looks like this doesn't work for
> some reason.

I try another approch, it add a new warning in rpmlint but the SPEC is more
clean. What do you think ?

> 
> I don't think you need to provide the versioned symlinks: they are only used
> when two versions of an application can be installed that behave
> *differently* for python2 and python3. Here, if python3 support is added in
> the future, there will be no difference in behaviour when running under
> python2 and python3, IIUC.

Done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
fedora-review complains:
[ ]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python2.7/site-
 packages/prewikka/locale/de, /usr/lib/python2.7/site-
 packages/prewikka/locale/pl/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/fr/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/it/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/de/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/fr, /usr/lib/python2.7/site-
 packages/prewikka/locale/es/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/en, /usr/lib/python2.7/site-
 packages/prewikka/locale, /usr/lib/python2.7/site-
 packages/prewikka/locale/es, /usr/lib/python2.7/site-
 packages/prewikka/locale/ru, /usr/lib/python2.7/site-
 packages/prewikka/locale/pt_BR, /usr/lib/python2.7/site-
 packages/prewikka/locale/ru/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka, /usr/lib/python2.7/site-
 packages/prewikka/locale/it, /usr/lib/python2.7/site-
 packages/prewikka/locale/en/LC_MESSAGES, /usr/lib/python2.7/site-
 packages/prewikka/locale/pl
This should be covered by -f %{name}.lang, looks like this doesn't work for
some reason.

I don't think you need to provide the versioned symlinks: they are only used
when two versions of an application can be installed that behave *differently*
for python2 and python3. Here, if python3 support is added in the future, there
will be no difference in behaviour when running under python2 and python3,
IIUC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1423390] Review Request: prewikka

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1423390

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=222070
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org